From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id 64A283853C20 for ; Thu, 12 Aug 2021 11:07:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64A283853C20 X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="215315206" X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="215315206" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 04:07:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="517422914" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 12 Aug 2021 04:07:27 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 12 Aug 2021 04:07:26 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 12 Aug 2021 04:07:26 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 12 Aug 2021 04:07:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HwxNRi4uMA5JUShkcYZWtKG2aFnLAnZjfXR0to45ODUW6mMvVyecnTOQqSliljDz+61nzGGuwmEQHOUAoM5sSfh3tqXM/9/2B9aMs65Su++0CojGT3ZCMIFzrwYlzXIOFOr4Q36bbqPmL6tC2qbPeM9en1p08vlqxiFPMCSLwCLUaGHBIz0n1zKeo1FKsibY3YkJ/kMAyaWj4AEnZCl0TbNq+mWLX5wdWc9vuBX2PM+X0FrUTlubY+ZRWsr4wUUJQq0N/XzWbUPmv75bMCHZtcRiTlzXLMy26+aTIkhAKYBXj5iN+MZajW0Emhn26HNHgyMvczkB5VuqOOljrpHXMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E4ujw5Ouv0b0h0HGKl8iGmiPOa+nUgCn0KXkUPlkOBM=; b=dEwQkzX2r/HX9e/dI0XHbU4TjB9NqkIYyAu9YI4xbQ9NtNth6I1qQlub3i6AZMpLIX27LhBupTNwpjl4/TauHWTEUjdc4bcYnFyzpBQFJfBLS5k9Bs+VIdwijFZV8udXFXzAKj4e+EjVSvI8cq7IY9dOaJm5mpcTbZJm9o6bCBzdRjy8nggMY+Y77fdP5fkQ4nOFw3MkmRXXzI3tMhYeFDf64+JYYqVQ19kwNQFN66N0ZegJpxKkX48txP6fC/GfeLC3JCF3KDo5gE8kCDughTsyPui9rmGf3Uk2BhVFpMPx+t2nqvy7GzBppY2D4S7V8dHxW3/g5ZwjjWz6XE7WOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by DM6PR11MB3724.namprd11.prod.outlook.com (2603:10b6:5:13c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Thu, 12 Aug 2021 11:07:25 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963%9]) with mapi id 15.20.4415.016; Thu, 12 Aug 2021 11:07:25 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v3 05/12] python: Introduce gdb.RecordAuxiliary class. Thread-Topic: [PATCH v3 05/12] python: Introduce gdb.RecordAuxiliary class. Thread-Index: AQHXYoPOP0R4k3xj/UaosEOl+6xWGKtwAWzA Date: Thu, 12 Aug 2021 11:07:25 +0000 Message-ID: References: <20210616074205.1129553-1-felix.willgerodt@intel.com> <20210616074205.1129553-6-felix.willgerodt@intel.com> In-Reply-To: <20210616074205.1129553-6-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 972b90e9-0951-452e-482b-08d95d815dda x-ms-traffictypediagnostic: DM6PR11MB3724: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XKElfH1hqrDT/asixTtuSLfcgSEoi0Eom2mcMzwC9XEfh6RkMpFXf9JlEwQ3a6nkY4Jvg44OqVqkL4NyXn5CdTKH+eD7OXiZqgrFnK3nnrFzIrRUrnIehXfzK+KmzV5rYKIjWjgpThhTj3gMBKg9L2JhuA3mLMnvACoP/vNs34qGAJZ7JukQr4A88Gz1srBaAIbWM1O9lnCIf5GEUV/gXtmMvppbehbytqXYQHxhZLi3NprlDNPnbn1LIjim0mOH2ZkrJcpsLnHerRyXdFlzHYzTcy6BGTVemNZhA04VHYRPVygNllYRTNRBG0Y2lqDSuUT0CSj3OxbJ2K9MEYuj6Q4OYAnCTNr8SQV5/ScvE5uMu/bF+nd/dwjo2AytW1LDPU97UKLGq58PkfhUDC7HLy/Ef531iLAEplph2SzhvSwTv9Ks58iZhNO7MpmVxsPTSkKOujDICUutTRedvC+2tkdr25TD5+zfJQfmB6vXYB5EA2iW8FCI6Y0070/OsIFHoV204TwfvdJoqMTkPHOFRE9Ngy+frUF0uD1UfmUYGjzZgXP5A04G3IZHCkf3nycqseKdgKu5j2AsM1/7d/E+Q1DzMgasunAvWkvIpdXou0CeyPL8ztMzesyYz64NbSj0JHZI2Du/Q0MrVPQPoZvp8gJvF6BbJcq1kmia5pw+PHP87urhkVm351g3dYt+FVdo0m0kO2K/xTY4+Hzr/XPFog== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(86362001)(33656002)(2906002)(4744005)(6636002)(5660300002)(6862004)(316002)(8676002)(122000001)(38100700002)(7696005)(66946007)(66476007)(66556008)(64756008)(26005)(52536014)(76116006)(186003)(66446008)(55016002)(6506007)(9686003)(38070700005)(508600001)(4326008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oGS5oUJ0PapXXKNFnPCbwS9Jxe80ryWOKYCa3n54ZnV3yUEohIYX/nT3RzXr?= =?us-ascii?Q?IzBG8pByz3LtlW5/em3i693QM6MINNfN43Zu1B5NfO8r8eIsfff6EuTq9rsX?= =?us-ascii?Q?DNmJ9Fk/cgLpCUSuePqGLEhEuk/lTgFTwFDfQozvwKdpLdRnCGT8ciK2ck4r?= =?us-ascii?Q?U5B8gZqHyj0WdBZASwob3/TLjCcQxHxdjTl6KEQ8qfUpIJgsC8e1tFQSQ+jm?= =?us-ascii?Q?3UG61ziSVAFTgjmmZZ0ZjUPYl+zUUio3IMooWYKpKhY9XSYt8mxkyBSpYcfo?= =?us-ascii?Q?ZoyHxP3qINpc6ZDINH2BNHfZZlb9FJbyhC9F8kJ/qgAmHE4m/R6aOiXrXl7I?= =?us-ascii?Q?h+8qhj+n5jDzGSiqY933jBM/np6n7i76Fe4/fkmIQHZKL9NKsi5sC4Rbhf+O?= =?us-ascii?Q?slRPqQDTswGshWIzb4lKM/E3FTz/qiBUL1BoebSe7KOssqrKrFKfVzCCmIM5?= =?us-ascii?Q?Fk3LjuPUjgPmbhCvLNr6R/ZQ2WaagOfEHnPvMwC98snvp3XPQBlVF0jYY7BY?= =?us-ascii?Q?LuX/NUc/IonSmUogsXoamM8iTLQnDXnNa77gamGEqlA+4RvtnL0MwIrpg6SV?= =?us-ascii?Q?bFJV1aCpUAJUwFzLjLlIiv4tcJlim9iMy6nuDcrwJDwwZpN1iBizJtcLElty?= =?us-ascii?Q?mx7ZEgyvNcic0wMPUtj5QP4wwoAIVnAVuI+ijkJmQPO7Ywd9TUtWGrfUW0Pq?= =?us-ascii?Q?Wwya4ABypBHxLdDxz/X8XfCUvYWVg1XD2NhJwXZlUdQbTkrrIOEbSXNE6Ocx?= =?us-ascii?Q?lc7jy9Dz035WCLXUN9CGIuFBWG/IXW0CAc0NTdjkDu7YWHOBwcGoK0PfM7Lz?= =?us-ascii?Q?pCYC59gafscosjiyuSPT4+2Jh6VSUqnN4HVGoYbnCkcFeocQNXy6Em5vwaI3?= =?us-ascii?Q?kXLzKusjeKWmcbTsHf2EEz/Wpunoj1Xe8R+o8QSa0dW1OwI6mUW6z5bBwEr0?= =?us-ascii?Q?Jt4uTMUmf6XNhGpdhmJgAxgYnY/uojBjMusMEA6/sCG5y3klijqIPfUsidJm?= =?us-ascii?Q?+LQ7lkgrtb/kn7w1u1eeHA1ZCxrWBVna5oySVXYsKthFuCc8VNTGFGVmpd38?= =?us-ascii?Q?hO0M2HGQfK3bm3qSqsYU9KsStUiDd1qKwjGzsj9mB1E3s+DYXRIG1wcwzXAY?= =?us-ascii?Q?siaMC+Yv/H7Ap898Eyd+TBbm2BScpErvOG/oeP/K3F31E1J3ySetgwTOQHbU?= =?us-ascii?Q?+oSKJ2pGcPTvZtBBRq8SvbfrIm6+AopgCDcwCYNCxf7+6siT2UL+LW7YvDSS?= =?us-ascii?Q?JLXqyaBTaFGrlxeIJtONEqE3Oze1MMdz6hSc36l+YZci+S7v8+AAxiEWxQgH?= =?us-ascii?Q?Fpw=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 972b90e9-0951-452e-482b-08d95d815dda X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 11:07:25.5410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cVyNNEQS1DJpttMYeFNHRLfSLMuGaxrwymYKoPejISFVQ8k8SCUwbrBF/+yeIidUccnFp3ed5NfMR2bJBl5R9lYtO09Uvua2baSH7z00sqk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3724 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 11:07:30 -0000 Thanks, Felix, This patch looks good to me with a few nits. > return recpy_gap_new (err_code, err_string, number); > } > >+ const struct btrace_insn *insn =3D btrace_insn_get (&iter); >+ >+ if (insn->iclass =3D=3D BTRACE_INSN_AUX) We already checked that this is no gap, so INSN should really be non-nullpt= r. Shall we assert this? >+ return recpy_aux_new (iter.btinfo->aux_data[insn->aux_data_index].c_s= tr (), >+ number); Let's check bounds. >+/* Python RecordAuxiliary type. */ >+ >+PyTypeObject recpy_aux_type =3D { >+ PyVarObject_HEAD_INIT (NULL, 0) NULL is spelled nullptr. More below. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928