From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by sourceware.org (Postfix) with ESMTPS id B27943858281 for ; Tue, 19 Jul 2022 07:14:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B27943858281 X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="286431028" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="286431028" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 00:14:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="924662963" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 19 Jul 2022 00:14:40 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Tue, 19 Jul 2022 00:14:40 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 19 Jul 2022 00:14:40 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 00:14:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LN0VeM0KpArqbtJwXh4zic+yjx5P3Scjpe1aTmBMZhkayCf8ifLBFF+TagqQdlSpzbrD/iUNx1JY6wHXVG4aDkeowW5rGXIK8XYIC0iZDiTPDjuh5byIgHetmmt0Lbfw61ANVMC8yFaycHt1TptVyX9LAjCtalnf+BnyiwlKl3r1Y9uMEwVjioUiQEFtfhRWJT5E9Vk2r6sz85RuFXSdM/cR0JzqZzrxfsO3ZCV9cAaj/olPzIMKdMgjERXp5atJ3eKThEGS4PL+DQhNTSMRF5hD4r7/+FK+ddHVARPx/OKTLkjgI51ATIuUexT60E+DTr6iaHHFrDxKGSIf7HwiZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ScX4njI2d3o2tCTTZ0jmFSllgADS8gQZ2wigH3BxvQo=; b=I9WfEoDI2lgj9lF4558ZQHgKyrfVbZyzetSIsHc0EpKkE7kXWgsfKeLnSK0CxPc2T+YBcud5fg99ANyoMitQachhtah7vw1UMhW+FjjISfhx+gsYz0HLF2Ps7WuIkVqHUn8B/AowgkbAELEIp5TeF05pD4C7NbY41M+MPdYtov5m66IhEolh9v6tlQmNwziR0s8y79QqK1x3vZUsJSnenbPxzlHKikNx8Gt33PHGn+LMLnnaapF499pJMPT6N+lJl7UhL5B+2/1gybbSAL0bI7q0HwfGXdf15pcj/+qHQ21I6u3KkzR5rINuy+/klIf+edL5e9vw6n4pH+TjxuRIKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by BL1PR11MB5383.namprd11.prod.outlook.com (2603:10b6:208:318::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Tue, 19 Jul 2022 07:14:38 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%8]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:14:38 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: Markus Metzger via Gdb-patches Subject: RE: [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym Thread-Topic: [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym Thread-Index: AQHYdo0l5Pw44DIZFkiqb6xR0kgucq2Eo4kfgADOReA= Date: Tue, 19 Jul 2022 07:14:37 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-10-markus.t.metzger@intel.com> <87bktml5gz.fsf@tromey.com> In-Reply-To: <87bktml5gz.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7693b113-b43c-4e5a-5033-08da69565758 x-ms-traffictypediagnostic: BL1PR11MB5383:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3kX6A2CA9t36IFcL6tk2JgNGdUKdEyZxXvoxfFxDQKZvKyDpL3ELklqwolA8WmA2lvtsf5FcjYafnRo0d/f1fG6gbYBXFjRNmTI7wPeOVLHoHR0FqhTED7uLK/C8JcW/wxQMd1nl7Rl8Si+rgd1WV80UxRQQtWFIoW3s7d/SsaFDqzXWxTntEl1dHYuj55CUI8z3tYU8b/YIQGYDmas5e58Ete3uQUq41kToVTS6ePbfh0TkxxyY2WyXk1xODZrBT4zgfr/iAfei5MXXNSvLFJCWkEFyGsYcTkuI3O246pZjRtJBGnfpCeG1rIbGPC+hI/483LLog5nX5BeoHZafI3LbMfIJXPJl9bDoELMCV516YDQmTPfzFfBPbPjOq94gilymcItAhlh+GOAA33aCLxeRRy+peAzImPf5BjWVjhwtoRT/DiYVcbEM3Ouz8q5gsCqRWs/RJNy7a4Sn20axnU3ucbiXvbAT0ueJmixB2PE1c2nRRYLiNpyEaj/dpbQw2ksJak4k0dKDbdPHg7GMqONYoT9rPxTXlGpoIBICtjH3FUS8IDpmLSkTy7qzQOO/ralSjCrqvq2/GFc/aADs7frF8vm0JmELlrWTs5M0M3HtH8ZHY+/7QV5tX6Rz2HqP1XzxRwJCdWfYVdIuqnDk5PV43lbmL70Mh0ffI4ahOoJplLgrI6xkcFf/UJQVDDQECAhTv6yoNav2zaJ63fdZG1FxTE+4qS1AfdrU7JcjYlk4WBL8RrqinPh8vBnpBVMdjsQqKpYZIcD8Ys96Fhay85d13omHyNiq3Uqji/HQFyKvyzsE8bYcL4ITEq8yG35rVPhdK558Zq1DCZSwsM7dQQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(136003)(396003)(376002)(366004)(52536014)(478600001)(8936002)(66446008)(66476007)(4326008)(66946007)(5660300002)(6916009)(316002)(66556008)(8676002)(64756008)(76116006)(86362001)(4744005)(71200400001)(38070700005)(6506007)(41300700001)(83380400001)(82960400001)(84970400001)(38100700002)(122000001)(7696005)(2906002)(9686003)(26005)(186003)(55016003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/noWYvIlgK3+GOI0iE/VPasvCbDAZwkt6BYzp8P3afGfYY6Zth7Dyt2JhCjn?= =?us-ascii?Q?bKsatT1+7H9mRcIdHtSmkORGsh1HXN4sS0YXpbLJL58RTo70Nf6gSX6iqWsb?= =?us-ascii?Q?G692lRUZ8Hm2ZJrdO/Z9/7Q00yvUISIKVR979Eesc6Msw0qfGRr5+XnOg5f5?= =?us-ascii?Q?vh3deRJQpmtheU++d3dCWgxkO9daMijrHhqZ6u74UC9v0YBVB1HJ6WKADlX2?= =?us-ascii?Q?2tUa+eFDvG+FoanPnPsCTpaOTKteB6Z9Eyjs/U532dOM36Sk+2ZYkSeosEWU?= =?us-ascii?Q?aPglggY1QNrNlMjZ+hQmFN/UFNmcWOFHxIDRD48Dc2OEJIvZBUrrk6nggGFu?= =?us-ascii?Q?tc4WjNnbYq3lNn0/UBO4TrA8zeeNmDyScwUcFPXArmRG5whtAyNVBlKc3fsD?= =?us-ascii?Q?yrSX7A9Ne70PdgnwgZdyKRlhXOBvpmlPu+GUrx8LX7gwhrLjfjiiQ+3UzWHF?= =?us-ascii?Q?ErbFjiCX8JktEc8AUIsgY2B5n1fsqJ/YJRHKt3KBqS7bASlc+uB5qESHJ+mn?= =?us-ascii?Q?P5hVglqZMrU2osN0cNujqNcWm8/e3gtGIR8JsIYqmZNtg92LBqhN5M9PWEg1?= =?us-ascii?Q?WqfpLB3AvUOC6ntWYKo238M4sXwFS4BlOOS8r1WmzsMVxRxKNVv2dD3zyZ2k?= =?us-ascii?Q?kQy6m2SF5NOtZJ/nrhVLlLkVfUjNHJLkzgOicY5ykK6lUSYSyBIyBnqylTEU?= =?us-ascii?Q?l2bRsY8dAu2OiO8LWkGorga5CLClqQn0yUDpLjUWrw+Z718z/VhbyRXpPQym?= =?us-ascii?Q?EwffGA8oHrHb74LxZ+tSNRrAuODzzgv713Px0JUwUj5A1CPo5s9IeGZsiMeE?= =?us-ascii?Q?Ck3Ms2mDBZl6wxhgERkF2UKrfoRYtJH73N8ggbotpkOMo4jdZ7MhzqI73UXM?= =?us-ascii?Q?ymg0+KRVPjpoGHxgvu6UGkkXA4u9LMyCpPLHyg/2DdcoS2T87mQi24UcfhNf?= =?us-ascii?Q?Y5JuIIW4QhWlVjLkDHbLs+dcHnwOJlHXdKFesRHLlY3/ZengZp4mzyQCvv4g?= =?us-ascii?Q?RnSzVxpulAlN1cv465q820/HReekEXT9LS1xDi3hzRTMLYb8y2TiqqsYnE67?= =?us-ascii?Q?Jn0d572D56HzOAigsN2bfk607rIXdxZxkhwyeuPNfSFaZwzhjxkPBEZaL+aD?= =?us-ascii?Q?sRvPj5CR7dAtk4LKM48D7qf/305RNga36E3TILIJ6GLj6pBXG+BRwzuDpw8n?= =?us-ascii?Q?fGhYnoqKkftTdiiOxlHRSu3QwpB9rWV/ZKlPS+WLvJc3aEZQxmG/ctZHnBlN?= =?us-ascii?Q?YsXUSVHbLkjL6mp4TdTeQfff6Wu97dRqpu6J7sFjWJWxSeC3VVJdCuSr4ox/?= =?us-ascii?Q?HcwdpV9Tz1Pi/sl17zm8NK+DjYU/oQam2Ivu+HoysrcWF4/ikkTH/Eq847SF?= =?us-ascii?Q?bWbyEZc1APf1Me9+OAORgOP+nRBdQc0hWdpUEOmWg2F45lbDl5LoEUgD3yfD?= =?us-ascii?Q?OUWsvyoEX6kutVdHvTC5tQiSswJ/2A8cWVclY6Q+gtMRabrDmd8KvHThygvu?= =?us-ascii?Q?IQjNEqip6DnrCn0z3/fKnOlppTtxpRdrpFCexUPSSNyzhAOIrTDhf9tFD7D7?= =?us-ascii?Q?kG18gKcNB98DUG1+JLVsMko1K/SlhcfbopykMoafea2u1FGarjpzwrekSCSG?= =?us-ascii?Q?GA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7693b113-b43c-4e5a-5033-08da69565758 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 07:14:37.9231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1bSfdLuVc/JPsDkhXzDv1ST/tFPruFnMTrjBUjnG03ey7POPTAbIzSw5jkeeugD4HbPMcsfzlpUbsRKs5Yx86A6iAlwm8nTuwMVp9nYKKI8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5383 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 07:14:59 -0000 Hello Tom, >Markus> diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y >Markus> index 8660205809a..85569b841eb 100644 >Markus> --- a/gdb/ada-exp.y >Markus> +++ b/gdb/ada-exp.y >Markus> @@ -1700,8 +1700,15 @@ write_var_or_type (struct parser_state >*par_state, >Markus> } >Markus> else if (syms.empty ()) >Markus> { >Markus> + if (block =3D=3D nullptr) >Markus> + block =3D get_selected_block (nullptr); > >I don't think 'block' can be null here, since it's handled at the top of >the function: > > if (block =3D=3D NULL) > block =3D par_state->expression_context_block; It can be null. When I removed the check gdb.ada/minsyms.exp ran into an internal error. The question is whether calling get_selected_block (nullptr), here, is the right thing to do or whether we should just leave objfile null in that case. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928