RE: [PATCH v2 3/7] gdb, ptid: add is_lwp() and is_lwp_or_pid()

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Simon,

Thanks for your review.

>> +  /* Return true if the ptid represents a light-weight process.  */
>> +
>> +  constexpr bool is_lwp () const
>> +  {
>> +    return (*this != make_null ()
>> +	    && *this != make_minus_one ()
>> +	    && !is_pid ());
>
>What about the tid field?  Just reading the name `is_lwp`, my intuition
>would be that it checks for a null tid field.  So calling is_lwp on (1,
>2, 3) or (1, 0, 3) would return false.
>
>At this point it might be easier to write it as:
>
>	return m_pid > 0 && m_lwp > 0 && m_tid == 0;

My interpretation was that the tid comes from some user-space
threading library that may or may not use light-weight processes
as their threads.

The tid field would hence not be relevant.  Is that interpretation wrong?

Thanks,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928