From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id 7F7D83850215 for ; Wed, 14 Sep 2022 08:19:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F7D83850215 X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="324619887" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="324619887" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 01:19:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="616777427" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 14 Sep 2022 01:19:47 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 01:19:46 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 01:19:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 14 Sep 2022 01:19:46 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 14 Sep 2022 01:19:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHUs9dXINPJvc0Q3kFfQwEmFKUNmu2RMDEq5F9+EW3dOdz/4BiSlF/4Xnx11PPHphi6kC/IeejK7nuB1vpYTASY55h/A2qtMabPeJn/NnRoHsPFx2i72eLS7DG/mfML6Y3f8rkomo+zVg9moaqfYZBFzHlNNzffPZo5xPGwETDALtYWxht8VaSSjrXRNdU4ZrvN0CIZ+6+XZGJMGGjjkYL0uZC8RaYRqk3MQrUBOzDjPDljP5+1aXb5jX7l6RQASw27QNJM6ZoZcilBgzY4f3EnpSiaUF7uri8ryKkiDJQNMP1C1qJ+LHlA4hWLVU+sF/beoDLa+gFLBtg+KmopA9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0xhZAgwFfJWWyhQqfX0WF+d/DjmaDppYE8ttGFVHWFU=; b=h4/UwJs20sZcKnSwHo3QqtHaHXWJ0Qr5PN8VR9dFSOMAsA1yGu2jp1cJ9A3ms+jlj7BayMZ3PS9Oxhgv+Y7cnoUJ57F4RCnU+MsoCz4I4+e3Ul7VzXYlAOrDuczeDw2QgTugMVmJKmUq9AnvAZL25tmbYNzUzDZ+u3L/IPg6lUDJjGEyCveUr+R2SM6Gr70eHs7Lmd+YBE0LYjvhUfV8ZXlfqlHhQnzuL7Oa3UggLpHCz37gJcwiZhp9BlNxA1PV0J9Zih9wEo6hAb9klstpRP7hR4e6eQ3igWJtSwn4Fct2TFp3JNX2ZAVD9rZea4khA39Ytd5pljFuw2xwKzmoMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MN2PR11MB4614.namprd11.prod.outlook.com (2603:10b6:208:268::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Wed, 14 Sep 2022 08:19:44 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::31a4:5c1a:9107:3ba6]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::31a4:5c1a:9107:3ba6%7]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 08:19:44 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: Markus Metzger via Gdb-patches , "Kevin Buettner" Subject: RE: [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym Thread-Topic: [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym Thread-Index: AQHYdo0l5Pw44DIZFkiqb6xR0kgucq2Eo4kfgADOReCAWcYkEA== Date: Wed, 14 Sep 2022 08:19:44 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-10-markus.t.metzger@intel.com> <87bktml5gz.fsf@tromey.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|MN2PR11MB4614:EE_ x-ms-office365-filtering-correlation-id: cb4b40ee-dc43-4f8f-798c-08da9629e184 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RHGaF953hFSPNvTCzAI/7m3XHFP36YBt8wabCJpdbrtGYw5JVtGhXe572K2uQLzwI6tY2gk7i2DP6ZbD2HuVguGTmacmkX68KWvJ5aAexcE8TnKt90HTTmC5KaHXTiRwvzqV3WjYqHLwdKC/8n4K/0/f7LV2E89UbKHtSz5YXvUaSFGO539gN/AItwH0Zdm1gM3WmUdFTrdPBQCr6U6Emk3iNacRYOHni/SkuSKx+sYr8mNxHU3ieD1BLPgfLw9+hdhFKwkwJDMSQtefb3PjT6B3hKL90Hi6FvdlLrqlPZTqvgtJsj+hSNRrL+N0TtjYvsjy/re2HpftAHSAPvNuNlh0UOhsFfFz3K/PWqcnwPll71LaqIHIbCZHb1zGnSlVzNM3x621x5j24sHrakqaAzhBjizHlLHjCNajikTzsilXUmOE8C3tc+348hjsINHozAjYb5DtiUDzvtXm/UZeJHlVHsh00h2lfrmqgtNN7jsJXWLrH9y1AU+Vr4lWC/PiMxZf6Ykooyr/P556rnu8DQM64ZSszYMs7j0m6ZmfRQqi4EFnuOzveQrII+R4QHA6doUUy9Jv0PNOWfBYROqbZNtqAlprlXG6LFFhg3V9J0iX2tU+5HWOvR9JxKu2BZHtpxsEcdrgSNTyj4Z3RtRGDvthN1HRkiFno/M/qU+J5X/CEQ7La4mXmq7+Glj95uLiOvFDU8oTXn4lSWcl+Kc9cCfOK28QMbzFRYRThe5dP15+wU49NyFjeXHjrh66ujnnMIMeltx+q30PIGgogP42fIpRp4VyT4Q9uJnul8GxNEQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199015)(6506007)(316002)(2906002)(55016003)(41300700001)(5660300002)(66556008)(9686003)(478600001)(82960400001)(38100700002)(8676002)(64756008)(26005)(71200400001)(15650500001)(8936002)(66476007)(38070700005)(66446008)(186003)(6916009)(76116006)(83380400001)(66946007)(54906003)(33656002)(52536014)(84970400001)(4326008)(86362001)(122000001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mpZc/7eA8DaKAQ1VWjogknK1KNR6l0hwt9C1J1xpk6sXLGqgrXwoII7nXieq?= =?us-ascii?Q?iFZMozYvNICfKOTYU6js60pgyX96pJpFIyPn4Ok6DVwSFQQDzq41P08W1H5G?= =?us-ascii?Q?KsEiqqL2FbULyT1dN9Y8DkIZ59sPutcoWpKdgzMyyREZ/MPjSv7acJUscBRA?= =?us-ascii?Q?4VaYWoHLJdcPsXCPQwCIoAd2mUvPvKPrEgcaPDthwXthVuaCk6LMR/S7rPl0?= =?us-ascii?Q?gmhdtaqA0E0XHZsdbXre/wS5OwuG4PjnWeSBCQ1FiZArFZp+h5ffsaNg2azy?= =?us-ascii?Q?MQWEaQvZXLf9uUnv7yLfWWA4peDwUVZdnrKj3C+b9T/s178YAOQWoJkTcde6?= =?us-ascii?Q?Izm1FZioVVgPYqLM/wbd9aXo8fckC3Crbr8nz1NzTxqcerz9V+iohAon9RZd?= =?us-ascii?Q?W83hhcl8cP+BgRLYZlcP5Q+Jar2HBnNGyhjVGrxgGiWVKWxNs0+2PzJXre/e?= =?us-ascii?Q?fWF6+Mlm2e0kBt5Ft4wI+7GxCIVoBhwaFfKmChj7aHHjdqpFEZtDGBpsSmkT?= =?us-ascii?Q?9XKK7N9NxF3rGkXvSnrZHtEQMyJ/iJTaoxJ83VdwcVkP+9zqC9bc+rDMmWuK?= =?us-ascii?Q?evQAJGKUpWMSg1oEkQ3WuBaahm+Qh5vjCsQMaxTfNnEZkSs7IcJ+TDFnbF6g?= =?us-ascii?Q?XVDl6lcQ/wen44noNgQymOgMicmECYYQEXmLj41o1R0SFd3JwXcteBFBcHgm?= =?us-ascii?Q?euBYJ3tB/O8t5uVU5agtiGYYFjNj1vMDh2IbI8Na4TC2c2mPrEFv5VDVNb3Z?= =?us-ascii?Q?33ikck4TzlE3edz7HdHB2b0VECsjZhhbj5d3bpINdXT0O0xXrONgv/OVxlXf?= =?us-ascii?Q?0TUGymx6slx33OI09xsJCnOWG00vBiAbyDSD4/FwoE0zeVnGdXc6fOuEDojI?= =?us-ascii?Q?IdqokK3XG68pxteCA1Joq+XzP5RPomRC64g14wdj4bQ1h5EqyBJhauoCKqME?= =?us-ascii?Q?rgI1cPVkR1qfykWz/7KWY4mKJM3WDDuB+0ndMWBLsQxE/43RB/GXoT/HoIjX?= =?us-ascii?Q?KI8CW/wC2VgN5A2Swu6Hg2148ljN0cDP2E3kWQzOWY6D8Nt78PB22RsVFMm1?= =?us-ascii?Q?rf2xGR+P8NA/midOCO60OATSFp9tbcLU0WnvQHM5z2smJUqawqq5a4UGhN15?= =?us-ascii?Q?GkU6oeW4vu0VQgHTZammdtUJb+o7HxPmCifAfymJrHDE4FTWbIAtgKWh/5kd?= =?us-ascii?Q?U3HAIehTc1HHFvADG5OCyQMS9iVt95OaTa3UsZ1smbToOOVVy9ATPEbW+lu/?= =?us-ascii?Q?Jb2wlxNHEeqjoKzGdFqArrJrefTrz6DwqnOSridrcwDtvN7SMFw6/l6uj/4j?= =?us-ascii?Q?or7c/mA8Ytxcc6dYCSxk0LUeneNBAONqJiHFHiOg/Blv3ulJbl5zoI2hExpT?= =?us-ascii?Q?duvDsaihvaoHuS0ULrpRMXJ+C3Xf4zMhJGc4DlH4fNAVpd3VPvoY7g5lHpCS?= =?us-ascii?Q?Nf8lpfLmdu5CdE9O8jMxdEXmH4x4pr2xbH23CXUsRr7ncCJdvR7vkU4ud0ay?= =?us-ascii?Q?yKIYF4H8vqMkvOdORyCtkr+0EKQzysNOIxAQamb9+4PtOBovxMA3UExMtryM?= =?us-ascii?Q?LB4qxbwMMXLMlMgwFdl7ucQOHsl0Hhxhx/psAxq6LHLnGJt6KD3t88LaW4Fk?= =?us-ascii?Q?Zg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb4b40ee-dc43-4f8f-798c-08da9629e184 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 08:19:44.7259 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1XRkHmSKJGX3M6SjrwqPCyoV+HvOjhEUMkRN8CNwUtW8hlUJRXWYrUtOtflf9YjCNqW+WrJTSMvGDhg70WxRRL0XaVDRjxNnw2kEl5aGv20= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4614 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 08:19:51 -0000 ping. >-----Original Message----- >From: Metzger, Markus T >Sent: Dienstag, 19. Juli 2022 09:15 >To: Tom Tromey >Cc: Markus Metzger via Gdb-patches >Subject: RE: [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym > >Hello Tom, > >>Markus> diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y >>Markus> index 8660205809a..85569b841eb 100644 >>Markus> --- a/gdb/ada-exp.y >>Markus> +++ b/gdb/ada-exp.y >>Markus> @@ -1700,8 +1700,15 @@ write_var_or_type (struct parser_state >>*par_state, >>Markus> } >>Markus> else if (syms.empty ()) >>Markus> { >>Markus> + if (block =3D=3D nullptr) >>Markus> + block =3D get_selected_block (nullptr); >> >>I don't think 'block' can be null here, since it's handled at the top of >>the function: >> >> if (block =3D=3D NULL) >> block =3D par_state->expression_context_block; > >It can be null. When I removed the check gdb.ada/minsyms.exp ran >into an internal error. > >The question is whether calling get_selected_block (nullptr), here, >is the right thing to do or whether we should just leave objfile null >in that case. > >regards, >markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928