From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id 3ADDF3853C18 for ; Thu, 12 Aug 2021 11:06:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3ADDF3853C18 X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="215315145" X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="215315145" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 04:06:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="421873498" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 12 Aug 2021 04:06:55 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 12 Aug 2021 04:06:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 12 Aug 2021 04:06:54 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 12 Aug 2021 04:06:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUkA0h9qkDFCd8Gr/e745nKtANk1ZdxQqfI2pgsFOqXOyVXxrQti9W3bamuP7egrvClIyGROUhI+vRQ8Lorw241z0e7mKtY9PuU22ktTRL982J9m1RZ6SwTeEMPdSYlRDzjlYUSsB2JcgLrBZKXiFN3abw+PEMWeuZvlNZ3eE0MkEprlc4X85ft4grDK/6UJUpICPejJRs22UXYu0sOFah7qDA15lVnzEdeRIkQzILEupNNJC/8Kkkl39CylBwp9sC/4ITWxz+cnG4uKWZgHLMsBnV3nuCGXpVSb7ldKKutNRnT+x4E2ZbGFHB2K0WjLq8e6R3+g7imhQ2/fbzTxlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pj3jKYvqt+bupeuOycpqHH5NVaydV0SjgyujyHE3fuI=; b=JR9SvlU27AerWcGa/9c9oC7V5KkxLoJ+rITi5oFon8m/Sg0+2nOBMtoCd4POYNzUjnZMBcs9H88hFk23AyfvvZOGC2JtArIobDfEs7ABtgLnOHknOrocH0UO0Rl9LEIaxXaNDmO8dbLfjzMjbf0zMuMloaLDGUpKQq5CPM4UXVF4Au4lxELgnNaF6F4+TO3VKwLEILIKLpU9otZcEVEZiNd8+D+y0FWnnjtXBL7zhJwravcL2Kj6oDa7K/dI2p9iZUh6bsIrFTN9xzlp4jZTsrATIc9WYS2iTOFpPjEOyGwnEn5PFafzeWnzaRPeDGyg1RStaH1SiMylheqKs71UHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by DM6PR11MB3724.namprd11.prod.outlook.com (2603:10b6:5:13c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Thu, 12 Aug 2021 11:06:53 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963%9]) with mapi id 15.20.4415.016; Thu, 12 Aug 2021 11:06:53 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v3 02/12] btrace: Enable auxiliary instructions in record instruction-history. Thread-Topic: [PATCH v3 02/12] btrace: Enable auxiliary instructions in record instruction-history. Thread-Index: AQHXYoPNuJnKjM9dd0Www81ZOTWlnKtv+m5A Date: Thu, 12 Aug 2021 11:06:53 +0000 Message-ID: References: <20210616074205.1129553-1-felix.willgerodt@intel.com> <20210616074205.1129553-3-felix.willgerodt@intel.com> In-Reply-To: <20210616074205.1129553-3-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b9b7794-61fe-4a56-0f05-08d95d814a83 x-ms-traffictypediagnostic: DM6PR11MB3724: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gJ0OMpAEQkSD25ckFnRnqhlDmRYXv9FHKJD1UN32qjFJvmnrMoUrlYnogmD/k8etlCJ+Ap/kJp5mDIiocaGq+51zPsJTFBM9zUxfRlVR9hSiSB+MukwADH1yNXraqLQsWGLvC8NbFfIzfCt56MYwmeYBDFmcJCHZ5ySIJHifgrmubznp2xTpMswQr2DaBkH4dXr14wT+/44i853/nXcEEDr5r6GeN2nl2dn66zfHom1CrpASpWcTmyzEkFGL8dpbkS7kz4OgTLQpLj1z4xm6zInXTQ/8UWkoOoE2lQHdMAaSSKpRhz5d/1Sx3kuYfQQnRcQGFsoyerVM7prQyetAZ630W9kOSkA3xaHa9pskmnlJetcKde+E3fUQ/+elkCUwgT0gMCOtQSN9FyIfLYMEXqmIraUtZpeKQGmCuYCn52lkqYuS7mMU3kNN6RSLIx1hxRtSeBLnYpkglE3exODTNsjX4FDo8GlrGNFaIJBTByZkD9zwsovX/mnBcmRVvWTcgRmviHRtcd2qnPvSYKvE3w4hi2STYYdorNNYcO95pVPjHBmVEoRSGYJiKViC6+g6ngbzssCeuK6cWDKg4oOPqhBfkJnvRg5enNYWDmbMtB5z3mG6Q3ekA3c5hIHaDMzJyaJV8rT9/GamDNl5RtVsZQXKeZ6ANyiv6s7MkDR7bI1LM4Y82uO65Z5INdgbQVM9BG+fejZ4pgPj2w04Sr9Gnw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(86362001)(33656002)(2906002)(4744005)(6636002)(5660300002)(6862004)(316002)(8676002)(122000001)(38100700002)(7696005)(66946007)(66476007)(66556008)(64756008)(26005)(52536014)(76116006)(186003)(66446008)(55016002)(6506007)(9686003)(38070700005)(508600001)(4326008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ehKLG/IZ1futVvGRSTpLyk9C2qVFSrIWQFWkV2GLVGlszXPbmrG+aoVvqKg9?= =?us-ascii?Q?ul/2cUSBHSCZLaYU3Flrpofoo/cmQn2KNOoLtg+jcyRXquOxNi5a/AfQra1o?= =?us-ascii?Q?4/2PQD5jlGa+fNhKfWD5zqeZmmkDpRmhuY1/vT/hytns9y4353bVfXy5APK2?= =?us-ascii?Q?KVvv96andmMG9hslL74GU3WGxsNGiPffyfn0AT6PAPXwLqxQ6WuGVLdII+40?= =?us-ascii?Q?9YX7O5uvBQphHsFyyrscgpt6BwWJcxTPnc4tq4R4sIf2i4wjAWVSr5p92vPq?= =?us-ascii?Q?AoDnrCa+5RAn3vc92QrpkJb7/Bhs22t9v5YFApldkw5+HQjF51bSVgf9agx7?= =?us-ascii?Q?0du26wsd9xSMuDkNU6qOK6R8gAV4WaIJNouog5cpQqQgEtDP/4snYHAE/nKO?= =?us-ascii?Q?+G0QQyRXcjtluA6aJ7LhDpNsIVsfIKgcJflobDOp0P/aIrejk6euyWleVh7r?= =?us-ascii?Q?McpP8C40quRp/Ht+Od969OKR2CPd9WIoo+bsVhL8J3lK0iCIW1g10aKfoQYA?= =?us-ascii?Q?yIglCBBhV9dErvLr10c+n86XluyKb5EB66a1oyf2l+31Ej24Fm7o+HKyb+Nz?= =?us-ascii?Q?XH9VcWa1EkN/9ecIsVgeVKYToNSCmV+DUlFGNXL7egUfCwckCu/wLHVg1Yzs?= =?us-ascii?Q?ZvlbwTMIw36GBRQhAmQCMwRT1ZJgF7HXfUkKOpyxzWovk93R6KZa/WLMC5Sv?= =?us-ascii?Q?OqDtZ8EttcCn8vcUEii8fuuS/k9AnTdp3UR09vicTsxTzCwfiDFRCWyUC10t?= =?us-ascii?Q?Z7vaF5qEeWX6DxwoxiA7LsfDgHbXChP8yabnxNavTsEg6BlGFK9E/78BVO6a?= =?us-ascii?Q?e+q7bR2z0okoclyN9c7y6NZ1o77yMkQboYBxWn1+W0sbvB/WyO1U7qX1mNMF?= =?us-ascii?Q?6HS0zkeQ8SK8Pq1j62zIKdJm+1dgxnJ7/bYsUdWO+uixS5sh1QXsvNT7fcy7?= =?us-ascii?Q?c5KoXwRtJlc83iq9WO2Pa5HJ+5OQs4fpmZduTuQoPQZNwJxVDBDVQaxNfzJR?= =?us-ascii?Q?5yC8SpPx+omDuvw8mCMKq9YMCjJTLaTz7w2MYiyinzNIx+N+Fp1VYwhHnzzC?= =?us-ascii?Q?53H6nQWJGAf66AE55E04l4XLhhnZtX2N3+45eYblFB3IA7EbVOPkiPnKioN0?= =?us-ascii?Q?FRoUp+y/+o+5cxomXQZ5SEUQkON0BNnB+cmPzrzBNbx1O0SNWZPRFGWqfuoP?= =?us-ascii?Q?a5OmbUpTSMW12RSqbb+WOiS7YO1lBokFHb/JfYOqAkx/qc6uAOLvj0D1v06r?= =?us-ascii?Q?en1UljzPKobd8Z8xx1YhXCCVQlBN3ZNOWCbakacgL5dwWjHj//a7J0wRpdIJ?= =?us-ascii?Q?i0A=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9b7794-61fe-4a56-0f05-08d95d814a83 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 11:06:53.0569 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JcG/Pfux1ywMJiI88DYTvo075VEuppQIkzm2cl8sQb/3bFIBwiPv+sDe5/Jr9jcAnvf+MLFvghovOTa1yzf5063kPz3A8NhBHHJGwxOBtug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3724 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 11:07:09 -0000 Thanks, Felix, The patch looks good to me with one small nit. >+ uiout->field_fmt ("insn-number", "%u", btrace_insn_number (&it)); >+ uiout->text ("\t"); >+ uiout->spaces (3); >+ uiout->text ("["); >+ uiout->field_fmt ("aux-data", "%s", >+ it.btinfo->aux_data[insn->aux_data_index].c_str ()); I think we should check bounds, here, e.g. by using at() instead of []. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928