From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Tom de Vries <tdevries@suse.de>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH][gdb/testsuite] Fix gdb.btrace/tsx.exp on system with tsx disabled in microcode
Date: Mon, 12 Jul 2021 11:54:51 +0000 [thread overview]
Message-ID: <DM8PR11MB5749C811C593FA625DA6DC13DE159@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210712112738.GA2111@delia>
Hello Tom,
>diff --git a/gdb/testsuite/gdb.btrace/tsx.exp b/gdb/testsuite/gdb.btrace/tsx.exp
>index ccde1ea807e..7f96313f1b1 100644
>--- a/gdb/testsuite/gdb.btrace/tsx.exp
>+++ b/gdb/testsuite/gdb.btrace/tsx.exp
>@@ -59,6 +59,11 @@ set abort_2 [multi_line \
> "\[0-9\]*\t 0x\[0-9a-f\]+ <test\\+\[0-9\]+>:\tmov\[^\\\r\\\n\]*" \
> "\[0-9\]*\t 0x\[0-9a-f\]+ <test\\+\[0-9\]+>:\tret\[^\\\r\\\n\]*" \
> ]
>+set abort_3 \
>+ [multi_line \
>+ "$decimal\t $hex <main\\+$decimal>:\tcall\[^\\\r\\\n\]*" \
>+ "$decimal\t $hex <test\\+$decimal>:\tmov\[^\\\r\\\n\]*" \
>+ "$decimal\t $hex <test\\+$decimal>:\tret\[^\\\r\\\n\]*"]
The patterns do not include the call since this is compiler-generated. The actual
TSX test is written in assembly so we know the instructions.
> set test "speculation indication"
> gdb_test_multiple "record instruction-history" $test {
>@@ -68,6 +73,9 @@ gdb_test_multiple "record instruction-history" $test {
> -re "$abort_2.*$gdb_prompt $" {
> pass $test
> }
>+ -re -wrap "$abort_3" {
>+ pass $gdb_test_name
>+ }
Does this '-wrap' add ".*$gdb_prompt $"?
Note that we need the ".*" after the pattern since this code is compiler-generated
and we don't really know when we will stop after returning from test ().
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2021-07-12 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 11:27 Tom de Vries
2021-07-12 11:54 ` Metzger, Markus T [this message]
2021-07-12 14:05 ` Tom de Vries
2021-07-12 14:35 ` Metzger, Markus T
2021-07-12 15:08 ` Tom de Vries
2021-07-12 15:19 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB5749C811C593FA625DA6DC13DE159@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).