From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id A12033831C90 for ; Tue, 28 Jun 2022 09:16:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A12033831C90 X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="345684561" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="345684561" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 02:11:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="565007466" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 28 Jun 2022 02:11:05 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:05 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:02 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 02:11:02 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lyoqiYXcWljl/Cqwl/CAgwgUsxq7iT8SKnAeAIgKDbtV/+2B2CnObVflEG+2ZrhutVsABXfpZ08umZug8iQLUCm/x71IHL2dverjHzNsvKQU6jTXvOjvBFTMu+QUDdq308ER+kZRZFrfjsfKiOw5LX/7opzQMfnzFB/r/yDdav+XPbbB1GI6/rfiweu715i4jKyY8K5ediwRwmnUVHsDwh0Xt4YGXcRAYdvfVfa4/JkuDtEluL17mGomWYUKNhmZnWzknhby2KL/rpTMRFaF+StmZId+X1DZRTFeRofWN8tArWqaaYQ7cPpwKqYi/Trd4qH0eokHo1UQ7ccto3mTFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xj/LIfi6zlWIyvOHn4B6dG+z1MfjJDQA17gXII+czlg=; b=PTohhKz/S4IVGFLCWJKhdXjJhIXyBo4AgXUcgbkIyPpRxRSB8VYF1HpG9+w6N3SGjhZMtnavgZWmy6X+zuj9NhyhWhknZ9OPLGM2H5OSGDrzN9EShCadjlYFa0LCh71KLW2b19DgY9g/a0dAkfggsQCLTMhQEugutrYlu6vKwaJUKsshMiQUzW0P0vJFVtU6CD3CG1ududcICL0hKq2i3W7QNlywbtGRXWq+riYm3IDgNx3bW78q68Ji4p3E3n6XboxlUQJJYv3pas6lP41UDT5a/++1x6wfdAV+2BHHjiIpKz4Tp/qWCbJEhHijT/JClkKLFtF2TL97b1c1IoeiMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by PH0PR11MB5610.namprd11.prod.outlook.com (2603:10b6:510:e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 28 Jun 2022 09:11:00 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%6]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 09:11:00 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 04/10] btrace: Handle stepping and goto for auxiliary instructions. Thread-Topic: [PATCH v5 04/10] btrace: Handle stepping and goto for auxiliary instructions. Thread-Index: AQHYhi2o+RZARBs3uEi8+vsP7jnDAa1kdMhw Date: Tue, 28 Jun 2022 09:11:00 +0000 Message-ID: References: <20220622114340.55830-1-felix.willgerodt@intel.com> <20220622114340.55830-5-felix.willgerodt@intel.com> In-Reply-To: <20220622114340.55830-5-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa35a1da-a7ba-4367-b6cf-08da58e61eb3 x-ms-traffictypediagnostic: PH0PR11MB5610:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: quQgXsv+IwN0rH8wWY1RdRU89mNvwEjtI5JXTd9pQSZU/aX0jIAAcKIcwyFiAjTu4juj7Hv0MBwWM5mwDKUIhNaYqQSLsqs/iX7h17VePCcJo2JlBr0jLIPQo7XB8PNTEvy0Pd/v3LerefmRz4IKNy2UoJMrykPamN/vEDWd/6m72Rg9MVrthNK6OWLlGVQzMVIzWoafplJr7Iy6KwufAww9riWt0iDGlh7TXofDBziMcurTLPd4VQmXFE3VeRJA3GAwsZEmtV1upbIVaBg/IIcujF/sIXlMzfJ7cGilSku0+F0qCQeSF1rAowHI2185lMw6DnGFOzI984ucNIXFBZOnBDk2Ehg//hYYmYdZAI5AHve6dvvxDVP3Nd676u/HYZ7q2nlcKZPtED6C1lOucN6J719IopHM+DZmhEKJIsrmcN/e/IziCeZj0tniQMpI7npOQxt0eIWuxQm8v/tpVUqtF8/MfezJgrFLmvqoNruITpAIThURY5oKGyI8xsu5NLuJbrD6Oha5Jc0zqBPMgc4qFkzXPXaI23H6Wix35+T6Rf61SPdMxyDXV8cNAKU8PICcEYYbocBJ345L6kVl6I7s24BmS8CiA9wxv8N6w/EKea9FoIHG8F+bNjOagUS1kEnGuwKt/1giXVY+SgV8lFvw2CaRxtow7tP73qbCv56BvHdNwDIG4AUEKt0LEUUYrtiFmQaWi0d0NL6Wu/TwM9GdwJMfjJr3JT3dGDVmlCXAm+B1Opj1GZUpYZudiEc5czh55EWiuS6CFA24jkQH7Ec92drtosw4w2iH/wu6LBI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(346002)(136003)(376002)(39860400002)(82960400001)(8936002)(9686003)(6506007)(5660300002)(478600001)(26005)(52536014)(2906002)(7696005)(71200400001)(316002)(110136005)(55016003)(4744005)(33656002)(38100700002)(186003)(66556008)(66946007)(76116006)(86362001)(41300700001)(66446008)(38070700005)(8676002)(122000001)(64756008)(66476007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EJ6doulX1/WWLamAD6cmwK9B6UQ8OzDodUbt+piK8fS5AIJpkGlQiL1nQmvK?= =?us-ascii?Q?aOdm4I/g8kLFQwj/mwfFIdephiMXElOfv/OXftf4dcXsEznD0OLRfbxOxUFn?= =?us-ascii?Q?GbT7GWVxUrZU7MgenXVbet9Zwz6w9rQvpv0aK45KHsD1fZHFMuqz52cmrQm/?= =?us-ascii?Q?c9oP9Brq4rgVd2itXhnINBigr2sMw9dzU9asZE0fBr+qYZLAfmh8Vc2HLD7a?= =?us-ascii?Q?ezIDjxIBs7STooJYMHeLcqor4i+9pRakyCu6wbBpR1Zq63d/3wLtXnZU+8qs?= =?us-ascii?Q?pfKpsVqbw43gnwv9l87Cto1V+5mjRoeY30bIH34W9+qD+uTPZUcmD8ULXHlU?= =?us-ascii?Q?X00EDLFlHGyuqSsyXEniQINkg9OMh5RnYuQxyMWiU/M5k+x9Qm4tmkgYE69Q?= =?us-ascii?Q?aAqByoT/6CGP/wdtchuOXTlQwG7Doz7vr9t6jhxGtYnouZ/rhUOCcqX4MZuy?= =?us-ascii?Q?o8zj17QXSsVooCnkhfHv6ESeXPJIprFQKw9IawcVBx+8LJSyAry4pPgkqxGW?= =?us-ascii?Q?N2tMyAHAG9Ok5SBZSlrhpVlM9ZZd+ccz3BE9LGgdh8T/CKPIUy9JAJUBj131?= =?us-ascii?Q?IGVM5RJWxsz62NWJgNMZlCtHdcwqUBFmR/9pfeW44Mg/LfMXg0Bi76PgSMmP?= =?us-ascii?Q?bh36Jq2Dj9NFv2OeqV0f879mRDDWVgxXEx+desUjEpFa3WbgcfmT3XJ021l4?= =?us-ascii?Q?bW25ggwevek4yZnUwdJb7DQeSsIHgZjwITdSBaYSDZYy2o8OqcB5AEwR5eEd?= =?us-ascii?Q?JoW7Pd0xDNX1ILr0r9Av5fUteWhEMZl/L7Wo6WnjfYkvnRS9ioNczSbnYQBa?= =?us-ascii?Q?rVU46Baq/O+A1hIscCepxku7xZgbgxTwV2YxKQ4QviGlcvzPr0eJrcj0LpKC?= =?us-ascii?Q?yObXD1583EZ9Zh4/+iJT+thr+9Ljmg8o/3ceSX92kOoLpQ2FJmcXm3pVp9z7?= =?us-ascii?Q?ICJalQMgsT2HxbPSBmOCVxkvzFQpSDj0JMQCwEp9/6mXBzZsVjWYgr6/7a0V?= =?us-ascii?Q?vZ3PdRcIElK7qt1Ez6wfnRwiP0JO+QMZ3qocitAerLrbs2h7UnxdL+3Mayk9?= =?us-ascii?Q?O/MMV7cqTmaSqaueru8WrKk26063td7mwjb5JxO0Qj/l8dKHkH79RSlGKnRX?= =?us-ascii?Q?L6a4j6HITcoYDI9GEfzNRCRmnp2LsupWezovZ3pVorvL9lK3la/CeYV1fHbD?= =?us-ascii?Q?HnMHevqRZAns0od3tExKlDOuOizvrn8Z0ocJ+wrsRJqHDe7FjqtJanjlF2ip?= =?us-ascii?Q?4hKFMyevSUYn1pXWToOSPCJClxxw6F+s0nwRWMGAfbB+cMX1W7fQ74RQLnIE?= =?us-ascii?Q?mPn9/3av77oKwOjXkiQ9tDHfDzgXWHa9xUPRlWC2ZttjfYwcFQMomNVIBltr?= =?us-ascii?Q?Vl3qViipcnXUUFWLYizefhVMCaIR7F4zoMB15ql294ROWo6IalxERBdNufpy?= =?us-ascii?Q?BGcOAj3V42nktdYaDSCNGzMSLe2lN4JlWntIOf4yV4EvdX25Gp9gC90Mqqg3?= =?us-ascii?Q?mArTasaiTp4DXbayL/UQrQ+cZb3G58EZPiDWJ9buRiOnK6U0K2rp1vqpzyrG?= =?us-ascii?Q?Ag3lkNm8t579oDYaQCbDdniWJbBA28ek+wJhg+j8?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa35a1da-a7ba-4367-b6cf-08da58e61eb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 09:11:00.6694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eJx/i+jsujbTN8HZbumJl0/EchMJdNbXexFknUC4QqLrvvSAnzb/CblQqXMWF9RRDLhNGN83DUEJ0ghE4y+2D3Gn90JT1KajreKDxOfH8ds= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5610 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:16:50 -0000 Hello Felix, >Print the auxiliary data when stepping. Don't allow to goto an auxiliary >instruction. > >This patch is in preparation for the new ptwrite feature, which is based on >auxiliary instructions. >--- > gdb/record-btrace.c | 68 ++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 55 insertions(+), 13 deletions(-) LGTM. >+ const struct btrace_insn *insn =3D btrace_insn_get (&it); >+ >+ if ((insn =3D=3D NULL) || (insn->iclass =3D=3D BTRACE_INSN_AUX)) > error (_("No such instruction.")); Let's remove the empty line between those two statements to group them. thanks, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928