From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 4D45938346BD for ; Tue, 28 Jun 2022 09:16:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D45938346BD X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="264727917" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="264727917" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 02:12:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="594709486" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 28 Jun 2022 02:12:03 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:12:03 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:12:02 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 02:12:02 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 02:12:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4OBOMcIrVCFpjChntTLcQHj2hxbEohPpxk5E7uDAYRsNod47gE6N1cC3GYIrKOMgJ9xuHdH38Z2g8ZGTOg2ME8xzUPuzhi2dntBoLqkI6yDoFQiW4rYYA657pS9KiMpyCEpW33JbMaDqTKoCBj2Sy7VCrlbIIZT4s/F6t2McPtoRuOaXuYr43mbyp5MNTdfzMoluUp1/gPQUpMYec4V3aD+uE/PqncW9NdLqTTCizWwlkY8wVG2tDbZFyw4oBqrED7+NXG52l0Q6wryHL1p9EcMKkDRaHhvl8FPF/NVb0TYW9D5sDYcXvX5sIgb5GcCvfmWtgfUTyfGXyUesbIMdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SVNuOQ8RSI+nmRfYbRVBbmo6ypcsHMGj1aWVnHzGN3Y=; b=iEnAbp8UrNZGJIY4jqsi8fTSKcgwsuWuBXDdcUilXKKHLNFi4zyLDqeMS4EEq9baSJqDWca475LHBLuSSEekKkqfUCaJhXMe5Sam8w/ZtkWheRol7NqMd3snONU19A93EvJ5K7NVPPPTLFYCggRuMWkIZTY+8qAZeTA8zhIbeu0+hl+LYRtr5qjBQZbCaBDk4YmPBi8QMq9osMTsyccy598BLV6N4LhqUz7wj7u9Ue5kuPKLIOChFdSzxrHK8u31jqeAGM6jjl7JNPOydUTIuwvlmmT3qJzgRq6jfGd3EuCMAaMwZzOwkhNq0BO1C1YL4/7SwFCNFlY0JYoItU7hpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MN2PR11MB4680.namprd11.prod.outlook.com (2603:10b6:208:26d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Tue, 28 Jun 2022 09:12:01 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%6]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 09:12:01 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 08/10] btrace, linux: Enable ptwrite packets. Thread-Topic: [PATCH v5 08/10] btrace, linux: Enable ptwrite packets. Thread-Index: AQHYhi2/UEBZ1bZ96kmD3OCmqub+Fa1kjbCA Date: Tue, 28 Jun 2022 09:12:01 +0000 Message-ID: References: <20220622114340.55830-1-felix.willgerodt@intel.com> <20220622114340.55830-9-felix.willgerodt@intel.com> In-Reply-To: <20220622114340.55830-9-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 19097846-c38c-4de8-6de7-08da58e642fd x-ms-traffictypediagnostic: MN2PR11MB4680:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UskimI5BZQnySx9qE8S31Gacly9ILXwhATfSIQZ61Xo2WWIgIQTfNXw/B7CYECFEH0SchUgkQiR/7r81vAQDGqIOTgQnLRGwlKLpcygWzlXCuN9OZHm9D98Lksqnkbay0ErpZfQIEn60cTFhMsf2g29qAvk9TDaUUmDBPNVbuGB4sXz9kHYhIPEVyn/8qTp6zTb2cD9DcuCvXehpxyHM31Ic7xT7U61O6wv5PfOOxX6p+HApI+4IP8LxwKYzaN7R/VhT+14Eo5hB1AyP53SsLQEjTbBacF7MSDF7RdE3cH4RyZtZbTZY0S7xk1OSb7XS6kZ7aMXQzMvw0z2/YRmSl/5X6539icrGeK6oh0IvE67AAqTl2p+OJ18U4SHdQgH07Muf5E2DcHbPrBKcCk2F9TmUbJLm/K39u0IsXuIrh1VyVa7kFLlyM24bGcPbRvdsEwcH9CkfjHspS2KfIYMejJxFDWNux7K+RN/PFOOKvnxEvDicqsAfEBA2nunuoaZhKWpUJUWdAJtG3n8vCN4avrnF+Muh/Et7wRNL8nR4eN6rfxY9xkJ/10iv2Iju6MtW8ghvwbFmwSbtbNzp6m0iStKUb5Fu8rd6RyNfgun64MDp7v7ozzSSy/oziAJCa89eUvh9hsdKcsVSmiKQ+5xe+444iB7vsfSijDGyedh3IoJAX+831C2WJR4W2shiCxNqQz3DG8ZG/Ms6h7e194k8aKqzOtL89bcPQiMz05WjbVDiYhTjQodYdlfyrgXLEs+QSniCR9Drlv0/fZYqNrdJUGuNWqbdu+nMB0nZmryG7vs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(39860400002)(376002)(346002)(366004)(478600001)(64756008)(66446008)(8676002)(66476007)(66556008)(76116006)(4744005)(2906002)(7696005)(316002)(33656002)(186003)(82960400001)(122000001)(8936002)(52536014)(86362001)(38070700005)(66946007)(110136005)(71200400001)(55016003)(9686003)(26005)(41300700001)(5660300002)(38100700002)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sqeebi2stsN/4eJxMlVEGWBzcHP71rPmbk86Ua1cyHK100/Lg7o1CleTUnNP?= =?us-ascii?Q?Ew5XOccUATzHTJPkyPBnX/XjftcULPoeHwsCkkzSIWxcDK4tucBfdf6zkSXU?= =?us-ascii?Q?ZnuRLv5Jiae/yzNTtE1uMyoKQz2wmMz93rvNV31A8/MCh4sLCkDkopG+85at?= =?us-ascii?Q?QygE74p4i+SZKxZ7/ygF7TqI2wZ4T5MYFkrokAG8nTL9Ut8Mx4mPkkFXZdLj?= =?us-ascii?Q?skZ/GUkQeElnh/zYjjzqLujRsOPArHP25K+VPUGtxFXZ/sKk2lnUawpq/Vl2?= =?us-ascii?Q?Lf5fzHIUC+4weScAc9Y2Tz9WniaZEyzw8+f3cpy/eglUYymlK62TJsR2dHjM?= =?us-ascii?Q?XrjkHPkMFDa/qE/lgcoZaeJMmWFn3+gOi2KunGD5ANKg5RMsbDQbM6NeZwtP?= =?us-ascii?Q?iAjN1633TWG/hdmWOtnpoObuc9fkZuxLKL2RjWUxaJA1pUZXLs3WSblYeLQ2?= =?us-ascii?Q?YdDd+3reRASynw5pWSujR6ImKmtm7+9r3saNVMs9uU493MbTeWeodg3SOYV0?= =?us-ascii?Q?zi2DiUDox7SwcyBj4C8g47hz8BR0APg3c3r80ZTIRNR7A3uhKP0zCGbSUuCM?= =?us-ascii?Q?U13WZdDqZDaJpT2B1EmF6nZWsqo1+7xmLDNz65TL78VFADcAAsYhOVMYHlup?= =?us-ascii?Q?oS2k90iB7B4c+IAkmoRfdXgDztN5zIDuWsQcUw4HfncvmgQL6B4+VbeUXKFz?= =?us-ascii?Q?DuKbHJ0UguF8Bsq0/7MEextqFkud7xZEXXj/PtLMLAo1cC7p54RAj3N8ANkZ?= =?us-ascii?Q?0PQ9eG03ARrX2aF91pajeC28ljdr0JCG/LdQM1t24SyEF9n0yRd2v/UdXM1T?= =?us-ascii?Q?F81yrhmFMIDIyPSkBjWrbZAg15KG+zjWk+1tBeD9Me8vSLFNzFyg7mbIr+2B?= =?us-ascii?Q?CuyW5npE81fS9ubAVOl2xcFQI+wWRXvww9CAUPeNA43ttlrBBH/hfVVZkCj9?= =?us-ascii?Q?ygFetZFmaJNe0MO5gmVa6+tcbjMmbwWMAMaynHrJsGhxmMjKz0lafBMUbtSD?= =?us-ascii?Q?bs+m0WQg+V79Y0Bh6Wc4o6Qv9yO2JtpQJmkvWfLEB49ulqulBCenGzvVTZ25?= =?us-ascii?Q?Onej06hOAdizMM+UIPsmrlOKnrSyqXN6l+Qb5QUH08gfiKTnxl7cniSivKIG?= =?us-ascii?Q?g5+7ZZ8yRICDWtOOVoKM0WRygnintEf2oNa/qlbsi5YWXVhdaopocOMJbIdN?= =?us-ascii?Q?UDCNUw+aJl3swVFse6bse/FCwDEmcoXkqF/u/YjS+gvyUwVVuAE0cacaimV6?= =?us-ascii?Q?t8GmdzArRIB9hk6yDC9VmHwhEqEoCYvcvG38t5FmlGpL56uqOQDS4mdy//ry?= =?us-ascii?Q?IL25m1FG4gGtdx9xH644qlo8dX4vGyjZSo1wpRJXZqH09Fus0oEP7fNA+40f?= =?us-ascii?Q?dgys/XBoPPMQspHWfOQlVYrXojC7s3NEWOpIXnbXn+id53/NhVIbw83mVnqU?= =?us-ascii?Q?aCl26FRBofGDIN4tUrozahhs3fAnHXGsxYSj28+J3CePlkJrWg4u9NrBJbzO?= =?us-ascii?Q?YhNDefDukXvjvYliPgtZjmLpIL6CxFZ46G0k/X9oXuE2ar7xsxeJOYff95wC?= =?us-ascii?Q?YEZR/K0/GGwr0ecX1lycY0wJcQedUouwXudgvL++?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19097846-c38c-4de8-6de7-08da58e642fd X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 09:12:01.5348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FeMOONTsETvcMZNFPWF7hiBqbxnUQDHr4C8p9NXKc7Vd++eaCyF8GYb1LsUVv0xKK+Mi/LBcwfCsfIW9B1Tc6q15hqU9RKxOuxO/vZpotVE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4680 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:16:47 -0000 Hello Felix, >Enable ptwrite in the PT config, if it is supported by the kernel. >--- > gdb/nat/linux-btrace.c | 29 +++++++++++++++++++++++++++++ > gdb/record-btrace.c | 5 +++++ > 2 files changed, 34 insertions(+) LGTM. >+ int status, found =3D fscanf (file.get (), "%d", &status); >+ >+ if (found !=3D 1) Let's remove the empty line to group the statements. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928