From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by sourceware.org (Postfix) with ESMTPS id 7C3713857B8D for ; Tue, 28 Jun 2022 09:16:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C3713857B8D X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="270435521" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="270435521" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 02:10:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="836597858" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 28 Jun 2022 02:10:24 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:24 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:24 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 02:10:24 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/gDCUHwMu+yE/CPiTvCPADjgh9Kfq28vEe4ChAtaP+up6kzXP5fL2OczW2NvejYeYskflo07jx4OXN8xk4wXeX7AznYIbCfCLGSrhk39u9rNjbyry2OmQce0MeS4Xtjw5XQrwkzwK7ec/cLKuSxNRpKnXGsji1Izx7yiAC/8uoH/UgNqrQUTjUUKfMDPgFoJ9KFuPOD5ktsyi98hAE/JOXYKjH6Y5/EylWP8bo0CJLNlpqjyqa/3Y7Dgwn3CCzBnhTum3QlsPa/0rSZPfBGx4Zld1/GNXKdHLRG7FAUnso1SIbOtNuuTDNtsLH38NTGTcWRd06VWK5mcqkAicGTVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tL3JIk7wRzIrcSBl6DpNhoGvzyV+/hIiER18VHfEHm8=; b=T/KQiV9jkn868jSmH0vDXOrfwFO3ggUf+BzbCb3C8LgDqFChpE4L2703+DX5KLY1808b54tlExkJXmSTRglmeshC7+PZ2DxWvsM/Dmucehr0CTy56VhCerxd8MwBXT0anOfgtJutC6o0WyX1dpdVLwhI2HrOT6nsqJOn/maXVa8CKZE0wMcoG5Ki7r1LA0Xaf/vVGvBeD+yTp+mDgHNr0EQNp4whKyiaafA03WEl27Jwx/ieA4X8Y7m7bhn+eBKNL/iPX4z4pbNyvc1p5r9tPMnwWmVaCILJduchUPURcUe7eSKa3RJ3u572yzBX9/1LP90H7rltN1tmqPDqYY7cGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by PH0PR11MB5610.namprd11.prod.outlook.com (2603:10b6:510:e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 28 Jun 2022 09:10:20 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%6]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 09:10:20 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 01/10] btrace: Introduce auxiliary instructions. Thread-Topic: [PATCH v5 01/10] btrace: Introduce auxiliary instructions. Thread-Index: AQHYhi2fidBE3twSt0ePLvWCkcwFMq1kdT1Q Date: Tue, 28 Jun 2022 09:10:20 +0000 Message-ID: References: <20220622114340.55830-1-felix.willgerodt@intel.com> <20220622114340.55830-2-felix.willgerodt@intel.com> In-Reply-To: <20220622114340.55830-2-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a96e29b-3975-40f4-8a78-08da58e606da x-ms-traffictypediagnostic: PH0PR11MB5610:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3OPQG00o+QideLEajZUYmq7PBOamFuK1byoFK8h5yL8rxiCU2TBKjmmpZUvTWIUJtIQRQ6AN1ynTjj5ETmFZPPoctoD9HpDR/PEYUb2tMr7LWrOvmbt5EREKAxGrdFAPo9XmML39ZbOBUtvLWuAhAzlnGIQYXMDcK/kTZewTJP1SG6MogLNbkNoOS87TrbbikiDqYmdPzQErolsU3qG3ctJj2GKxd1YyJCQBYAD7un1kF+RknGRqam58se14kdHj2/f7bYCIlOKoqg0ct85ftdjjEYKe9buBU5+ZJ1kM5GwcrxiHN30QhUUKWpLPqaUdN/HPjEn/vDWUUVn0mSYlpevnd/N2JoboIzqZwcDQaJeNdPmygSb3/rqJ9aCWfTz2X93IGeWl3fBOnZ5uxFyVr7lR2vOPNzJHwzfPJXKtEbUiNszu9iKrwO1mAHg2nGOHRiLTl1auSY0fDbF8YXZiQlarfo83zZteXXlDumaw/3lWU/VV4fXBh9Jhakmyemn/czr1DriAf5GsLO2aR80J+9UZi+x8QLCqcvS+14ZqDWfaF6pACUwgwoTV0FOQ15K8z3b9fjGkHDU5vPqFOdTH9SZo6gD27u1iq2tjqqwRcWyLEo1YocRjSWkv+4DdtvuRV3RMcV4LxDXrkg22SRTAdnDyVgImmCrOuH/j8pRJL4k6ccnOu6kysn/aGbRDvL/35aQ9YV3HzsZ29QoJz4KsDBOe4mVGmKMhBDA/6HEifJlmLb2r+ntVMpLFUjgp/+MIdPcI3hEtaxSwAPAal8zjYi0ftCNAWjFG1VIq4OBzftA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(346002)(136003)(376002)(39860400002)(82960400001)(8936002)(9686003)(6506007)(5660300002)(478600001)(26005)(52536014)(2906002)(7696005)(71200400001)(316002)(110136005)(55016003)(4744005)(33656002)(38100700002)(186003)(66556008)(66946007)(76116006)(86362001)(41300700001)(66446008)(38070700005)(8676002)(122000001)(64756008)(66476007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?InYO9pH0mbktRaf9fMF+7EsWREzBHgdNLboiEFLPFPDoZocRxjOU36rrUGBp?= =?us-ascii?Q?kpuA/3lhyFKNURT9HZDP5IH4whWpxXe3ff8G8QHVBPQJuUxAKIVFb1Qd0Tvz?= =?us-ascii?Q?P6JMJk5G0ODq3ZTn8hP3CbpKoEJg0YAIlNdot+HgeRjVZpQ/Sk3Luet+QBoE?= =?us-ascii?Q?hGoINsroOt+AwYlsMgHoW3ZnuTwb+9vkidkBDmI6ngaPGj38hjqSXs04BpsK?= =?us-ascii?Q?a4fBICGt6OVMLccPOwUuy1KCZplHX92H/NN5BCRcQB6ml8DlVXByF7YF2EZT?= =?us-ascii?Q?Vrcd2jKmvolHkDWMwFJp4AFJUTvgjoFBFwnVFu5MyldKnwpFrSKdYpbMzX5o?= =?us-ascii?Q?/xpbpdX+1vbOcuMR8iVz6NpdAdu04RV3h8dfwGYoZzZLeQFm+AMQZSLpTNTJ?= =?us-ascii?Q?af0t4pozcip65V0lv6S9s0vFlCd6t51AIsmswHHZNwrEVDaWk6ObHN4ru1t0?= =?us-ascii?Q?2wKsVaxNYQMqxNGP+rQecZcEYXIZl5KEbQwrXMWvjoamKVbHTCUZp+TT6LEB?= =?us-ascii?Q?mmjiE7xsLtenEVFK0DvuG2jRjuvHGA7zz9qZoHFNZZuFYoUL4TBZ3TOjYYCh?= =?us-ascii?Q?MVLgPzS52G05R2lBZI1c9P1d6H07KmOjqLiohpYZBxh/56fiXQcmA0KOilci?= =?us-ascii?Q?CC4Cc8auoIGNMOak48XbGx2Ofxyd35tcd7LTTqRmR7A/0bUaBkfWLgYEs/t9?= =?us-ascii?Q?NAGIfnaxg4gCx0IM9eNoVj7pqEywrxy9PvhB/1SxrYsKXGJYE35FaBiMeoXP?= =?us-ascii?Q?5mP3w0vdo98Gekia6cz0pRmXuDrCOj0+b5L4RjX51jzJ0yQMAOzzYsmRnvyE?= =?us-ascii?Q?qqXH2dYCPS6PEH51AswmlnQa+i8QM5+4x1OSzfLvyadlTpKXYD+2w1bv6QZg?= =?us-ascii?Q?s9SiJ/LV1LQGOxnti/Yst9de1B23RyqJTr2AXj7lWRNyPmo0CeRgetudSdkF?= =?us-ascii?Q?co09tJR3gQZTkvTxe7p3eOz7Oh77SmoHlCNhaJfTanNSSmRUkCeYcHFaYkt3?= =?us-ascii?Q?fDV9U6rg/qY8LD29mGs3X7MKyUcaokjWLcLAr+dX74qtGgBQj+cjwGtt981z?= =?us-ascii?Q?FrZOuqZDyVZoaFjzoJ82l9Qp0pvu3GcwvdMPYH64GIimk1lez9LjRfZK6YAf?= =?us-ascii?Q?IuM0ebXLiuKUSC9uYXESdBd8tRwjlcoIgE5TGOSPGfjK5/LIIyU+OvaiPrG7?= =?us-ascii?Q?vxI2xjc1G5e97+fW+3idECBdBM7JedcW8V69RJmQI8jEthtDKbd6pyUtXuYY?= =?us-ascii?Q?6omyvDMp07WQdP6e4SOiJaviTKbKpDmPoMq+iuSRZabNe/N5RCdIVY0Ajn05?= =?us-ascii?Q?4M6r13YqdBWn2B6cFZ4Xr/ys+p0j3FYY1gHu/iBeLtpRNmnH2xS/51eSJ8Xu?= =?us-ascii?Q?UYnoN36lCA18Kh6K6GPohDoTltBj3Y5SblP7EXIMQpce6rtRRT26hhclUnVP?= =?us-ascii?Q?MTlD62ZHqRbOa6uUuuAi7gUDkwDIaJF8iRkq2fjtdJER9mWIbBwWVSNqyqtl?= =?us-ascii?Q?OUbo3zlp+RoxAf8EH4dbDTC1aHqMyClGp1sVcVoCIwRaJcaIOscea8UMU5Fs?= =?us-ascii?Q?BwrAFHvkNzJplc8du0spdmOqcBo9jNMpO5QbQNQz?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a96e29b-3975-40f4-8a78-08da58e606da X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 09:10:20.6429 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SzZpk5cAnBUA9soE9QXbug4p0OvyxhOFG8nB+Z1q23tKV2V0O4BGnX2FhDMJJpZE05EgfB60NotWIMhcMqs0AIeJ0R1EvAALt55U3C2GE8w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5610 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:16:38 -0000 Hello Felix, >Auxiliary instructions are pseudo instructions pointing to auxiliary data. >This auxiliary data can be printed in all commands displaying (record >function-call-history, record instruction-history) or stepping through >(stepi etc.) the execution history, which will be introduced in the next >commits. > >This patch is in preparation for the new ptwrite feature, which is based on >auxiliary instructions. >--- > gdb/btrace.c | 2 ++ > gdb/btrace.h | 24 +++++++++++++++++++++--- > gdb/doc/gdb.texinfo | 4 ++++ > 3 files changed, 27 insertions(+), 3 deletions(-) LGTM. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928