From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 1B0743858404 for ; Mon, 11 Sep 2023 09:53:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B0743858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694425998; x=1725961998; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=8EsAIRJzqZIOzDWYTH7tmvYMtF1ZBMDKkOtfQWvvGDk=; b=b7fuPyTv7fbeS27RfBuTM7VoH6WdnWD/wwP5wnZhkxAlRnlf9+fMB6d/ ctVxeXNj+S/e57IXWpTeIQeKGk+/cxNiNSydQghiLuAPdrf8/rkE2n9ar gzszKptGBlFZiPjOEXzUPP1wE/4rLQmSSZsMvEYuC1JCmeg4Z4A8rJi0J ICcOxqGxhqb0dhMrRDZLR2C6rR3ZGN7mVkLoOFf4VXAAOirDIrl7TSOKG g9gDVLRwS/tuf2rzYZQ5TmxScdiiTffU80sTaxjPjVHBrEFPVX/ucmwcX MuNdVXJFxLkkHnWF9h0MXq1g8gC5vdhrtddK7ShbBaiJU1tpUkYyieNzT Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="363063979" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="363063979" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 02:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="866882903" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="866882903" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Sep 2023 02:53:16 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 11 Sep 2023 02:53:16 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 11 Sep 2023 02:53:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 11 Sep 2023 02:53:16 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 11 Sep 2023 02:53:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W3yxdPrAX7q4Ny+a7ZVzYfkH+N0SmMK1k7pm0Si+lTHvi/cIwu0nlU0bddDpDIZWwrCQ6B0VMHtSBf4EB7P8kJWxPIosLWSaKqyFMFRIWUCuYejrXdy+IcKVakWzlcLRYiNyBGC8pYdoKXLBrjOozUzeER9UdSChj3Pv2hyIUOxrhRUNowd+eFNSr2+bDi8wjTTZc+hM2Ojx518DD4aWLgGRzAU/nonRDYoJchIZ2j7OSnir/3CKQ1nX16vD5t0qJOGA3qmY1ZoUWB3nz3Aa4a2jfu/tj5uFqSfA4H3Gt68YQwAv0Do27nlbzo33t1GPTWhi5tu7yb585n/aNRzzjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nBiDVOPD3zPH/bFpMyKPchrSmnu8/dJWrH/v7irz69A=; b=deJ2ul5ITNT9p5fz9u4yXYZjXy3nBn/uMACCtX5HLndzBOmecMfQvilfnn5JLE6dPMPwBfDLt9SqYP8DJIlIdyerRIZPeFufx7GKn9C5RQfBjNBxlI44y8ImDPevrZdfiv5GkY/2tP+n/CjRybEr8e47UTvZG0bJp4NiRHv7qrOt+r1h+BqUXsyVGmO1ezQUIdIRdVU4Qmyay35kyAuvJHmZSQ7KStlYl2TeLegvVWJCCl9BBsh2BStYe8Z+rqiljq55Z30a5jQGpF+PnRLSw0T2V7+HLiodLaR/U3zR7sYt0cR30FFUj3aIUljX0h7F2P70tzx8x1neHrXEevUTvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.36; Mon, 11 Sep 2023 09:53:14 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::dcf7:d957:e9dc:2c64]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::dcf7:d957:e9dc:2c64%4]) with mapi id 15.20.6768.029; Mon, 11 Sep 2023 09:53:14 +0000 From: "Metzger, Markus T" To: Andrew Burgess , Simon Marchi CC: "vries@gcc.gnu.org" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v3] gdb: c++ify btrace_target_info Thread-Topic: [PATCH v3] gdb: c++ify btrace_target_info Thread-Index: AQHZ4kK2a6vvW8YgIU2Q7KVOu9fd/7AQ/bmAgAQqAMCAADVDgIAACHlA Date: Mon, 11 Sep 2023 09:53:14 +0000 Message-ID: References: <20230908105319.1963979-1-markus.t.metzger@intel.com> <0d7782da-940c-40da-a511-4f8a36b5455c@polymtl.ca> <87r0n5kr1g.fsf@redhat.com> In-Reply-To: <87r0n5kr1g.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|PH7PR11MB6522:EE_ x-ms-office365-filtering-correlation-id: 7c71a8f7-bce6-401e-ab0c-08dbb2aceacb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dIAi7ZsLx8nymZ7OllhvBEg8K5KSUM943KmQevK6topGZWHVHye5/He2mPKAkSMWkL7VZq+SZQBGhuo9J15RfcoURevdBfckOKfX7MgOPd56SPVKcwpOf/wRaQ7f6UbOhXThJlynh7DNYSKERPp5vSnxf22PESGOviej4cvNWK7drR9AI6pc4uKQKrV+QKRCeRfHxspuBLBi1jjQhKVW+IJqPzkvXo2l4NPPOKFEjrbTIayZDuf701btq3dLxKJhHzvFy+gjKUiGmB0dGJf42iy4LZ0QNueETZwux9lxgswPz0+ukGZVMN98YGWEMh4W6zzQuRaiMMldObcilsfxySkn4uRaSxPoBWxFOr6YiMNdb6qHxb1f4paLjaQCwJz23eA1RkTzdvLHV8+8ugvJoJy9dh97FTDWPc7eCXtD8vREMg6AJpP/iLo8KQQEEpjodxolRKuwm/F7ehiK3LYKlCPJaTe2d351ecqrf39HxoovYcmzwIw7ZU9EPYj32+YaYUNgXArZTX/JydooevdWHfuUkQr8V30V8BQYEt5PalYZ7jHRTUuOIneH9snSPsjvQsjD5Z8Jcw+VIsZK0EgA9syW4SEsZCMfVpiFzhU5SmWhjSK9UeY3yboYFL/s14v+ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR11MB5749.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(396003)(366004)(346002)(39860400002)(451199024)(1800799009)(186009)(71200400001)(9686003)(478600001)(7696005)(6506007)(83380400001)(2906002)(26005)(66556008)(66446008)(316002)(54906003)(8676002)(110136005)(66946007)(76116006)(66476007)(64756008)(8936002)(5660300002)(4326008)(41300700001)(38100700002)(86362001)(33656002)(55016003)(122000001)(82960400001)(38070700005)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VVLARqtRvenn0vEqyF+HFAaqPvPBwzddxlCZ+t5u/VO8Yy8CX/eRAti7Syhd?= =?us-ascii?Q?YQh9FyjoUOPTy8uIt45vK7sS9/8x+dio9pRpjuxOqgdmrzfezn9RFLdVDqLF?= =?us-ascii?Q?lL529cO59OFK7oz8wnvBa7OUzZoHIrT9cXsCuLPvJuRVg3r7Y1+Otg0AlSLj?= =?us-ascii?Q?QhDEDblLMVlLCjUqz4t6tVDLv4wBmT+37DpkY7n2glzvGrg8GdLCQ4bSLeKr?= =?us-ascii?Q?ql937jz/r5deehNPFd5Wpw43sRQlSY0kRuL9nkodfNc9xUvj1eN6nhnjzOk1?= =?us-ascii?Q?NREgEsIp00bKnTL6aJr02m61ZvY2xnOCethQhJMv1cBujGU6xcUEwhtuKCQ9?= =?us-ascii?Q?iwngdO1ca0l3GI92h9CS9Ia6SiMvDq9cWiea/DAFyqORPxsrgnihTqaGUr2G?= =?us-ascii?Q?f/Qrs9eX/NF4emlRL4OvwqMMF1bKO1lXu6B6RxtcyDTnhMDVUJTbLvQzpBXI?= =?us-ascii?Q?yMq4mr4IuLR10uK7wvKXhF+UjO3U4GHKW/Cxc9TthSortQ+y8kTJuDuqotqO?= =?us-ascii?Q?TtmW9Sq0A/G3mUE4vKm1daFceAwS2pOwbfA8hlzx6IZ0v43bwqhaNgzoYn+6?= =?us-ascii?Q?hXUeImPsiyK0BKaKZ+D78f4q/IcsVHH3/Z4LXf/1lujpRj+EUoGgV+yt1ce/?= =?us-ascii?Q?1soQ1joNzlRUPfWcy8RQCbsCu8+VCGSLMVVT/M3o7qKyBHkrl/Eh3ZlqVXBZ?= =?us-ascii?Q?ue54BCtEa7WdnlqWtZM/HD1DIlnXgWRmaZeu02vt0Yj+Mp8AbqGU9rsUVfdY?= =?us-ascii?Q?XOJ84Pk9iS7vDLvDLzoECyIglDNI6TvT/Rh30rrY1OVtLDtyVQF5/dtIoSzB?= =?us-ascii?Q?RKqtLSdvvrLlB/q7K3MTnfx0bvjacAOrZfu40B47CVdzHgwNTP2BfEHPEpd3?= =?us-ascii?Q?uUvWzBM45hV1JHpCRuma7ICAdlqO6NqpKqTLvDgRaeEzWVjQskkIzDweYfur?= =?us-ascii?Q?+dYqSjaqBtX0WZU19lcjcwrBJnAWziIbdD8LmvC+jTRr46vivlCPcSO/yJlf?= =?us-ascii?Q?ZdDXFdQRx4ktgUk0WKLDTQ02IHyjV4Xjk6VW6SMuSztG0WmwK+IQKwAu1bKj?= =?us-ascii?Q?gBxvTyGTYDKtT0E3WS9N9q7bOoMOeGD5bkABh+uXBCq6ayy6qIFdqM2ciYWN?= =?us-ascii?Q?2GCLXpD8lVFO55AUWl24ehFrCtko0K13FyWsaM/+1pmIzI8JTAWm75bMGTE5?= =?us-ascii?Q?WEVV6ohZ8Opu4ilOXdhfj8Tky+SHAGa0luCxnHDertZq6cIILW9236o+Dv7H?= =?us-ascii?Q?U72o6vXm3U1Ly+VHp3Oe+qbnj5XrJtz+D1zHv8K68Tk9Lq19AQpYZCvEByQI?= =?us-ascii?Q?N5+eAV0CDplm8QkhsLDpgbd54qc5aHaBbXyxUBQMlFu709WwZWPRkyEfKBcF?= =?us-ascii?Q?ZRkL3JvCAMvG0E64E6xsfNyv0BDf++HlQmpNPS76xXeRWkJdRIJ9dJPRnNy0?= =?us-ascii?Q?0Dx5zsnxnvOfGE7lgsjQriuQR8U9+I0Zn3zO4c01sc6PypuK5h615VN3hcSE?= =?us-ascii?Q?VUThDUIoCRfbx8MXtHvl6H0DxDw2oez+rQNUxJQLnmqouHZGYg8avEe8N2++?= =?us-ascii?Q?MRhIaMC4QFM/zs8KGF3poj6exzr0gAO/9AX58EzZ?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c71a8f7-bce6-401e-ab0c-08dbb2aceacb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2023 09:53:14.6355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3pfGlMIrxaqH3Er1TndlcDJgT5a0M1ThHZRlp/0yCNX4n1jhy/Hz5AMcNSFJVTljhcEtGJSrL4Vz3yNMcr5e9+7X9NxT6q0Z+zfVVrsWBdY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6522 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Andrew, >>>> - gdb::unique_xmalloc_ptr tinfo >>>> - (XCNEW (btrace_target_info)); >>>> - tinfo->ptid =3D ptid; >>>> + std::unique_ptr tinfo >>>> + { new linux_btrace_target_info { ptid } }; >>> >>>We recently added a gdb::make_unique function, it would make sense to >>>you use it here (it will eventually become std::make_unique once we >>>migrate to C++ 14). >>> >>>So this could be written as: >>> >>> auto tinfo =3D gdb::make_unique (ptid); >> >> I'm not a fan of 'auto'. So this becomes >> >> std::unique_ptr tinfo >> { gdb::make_unique (ptid) }; > >This really doesn't feel like an improvement. > >I also try to avoid excessive use of auto, so I dislike things like: > > auto var =3D some_function (....); > >because there's no hint what the type of var actually is (without >looking at `some_function`). But in the case of: > > auto var =3D gdb::make_unique (...); > >The type of var is right there on the line, so duplicating the type >information is just noise. For me this is a perfect use of auto. A related question is whether auto ptr { gdb::make_unique (...) } is really any better than std::unique_ptr ptr { new type (...) } regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928