From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id 737513858D39 for ; Wed, 19 Oct 2022 14:46:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 737513858D39 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="308116104" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="308116104" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 07:45:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="771819262" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="771819262" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 19 Oct 2022 07:45:58 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 07:45:58 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 07:45:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 07:45:54 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 07:45:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9eeq066lAH0dGP10ztt4+ffghvyHILlm5szLb6wLoll0gLT5dUKSiBsnV55eEsslSj2ThlV8tEISqWk7yVB7ELnqTIwEnl0KbAin1ToBEkBBtnDFmVTMxT0AgRsY2vLlxrAAdHf2C52x3/QU4+FZdFCLOZedIJSqZH2wQSpG8NT+NPaEXuPHrJP9gkJa9GUISVhXl33JTtfcDJsJYf1Ookq+FQ19Y//fxxkM00GemsiiQo1W1EpDY0aFVKR8CKsiF/EExAWnpVbY6Gtg9pBQSX1/rPjGph+M9FTV0wNW8y0zMPP0cKkclHsw1PLZrMUwQ5XvG9U+77gFuy8LPxQeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+CQqz/fpN3Ceej38hnvjxiH//fw3lFoYf3k8+q7YQ0k=; b=hceOUermerY9taBbMsVwreeoG2agx1mFwm9xhauFdWRFf9TmJRxfRKQ4GhU4W6/wTxdoVYvV7QOV6XQW/XOWkdbuAJe6hoQd2JSs1ofYpLidN7pKwYUB2I/NU9LvziPLgCr9okGgpApiVcLcJrTIvX9PVDVsA9jaQFPAno4Rvu1O5UZM2Vuccp6VRnNrmeeN+3vaUOCNWFgZj7V/BJ29BxrtF8HlCjtyJ1yjAyA+AcLr5+TMWG/wseQRXvaEYZ6q+Jqxi3YOtfjc4AM4ia5CsSGYabylT7u4bVNbdNZjqvgwSqhpz0CgjfGAemFUtqQAZasY/A3dbIUZS/utMaczpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MW4PR11MB7053.namprd11.prod.outlook.com (2603:10b6:303:21a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct 2022 14:45:48 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::65d4:f6fa:40b9:2437]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::65d4:f6fa:40b9:2437%5]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 14:45:48 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v6 00/10] Extensions for PTWRITE Thread-Topic: [PATCH v6 00/10] Extensions for PTWRITE Thread-Index: AQHYycDEemcHJ1+FiESD0F0H70wD564V/meQ Date: Wed, 19 Oct 2022 14:45:47 +0000 Message-ID: References: <20220916113646.49749-1-felix.willgerodt@intel.com> In-Reply-To: <20220916113646.49749-1-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|MW4PR11MB7053:EE_ x-ms-office365-filtering-correlation-id: f4c8c0ef-4f95-483a-28dc-08dab1e09c5a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QzBOVP1GyxG3LydtgIvfGpAIgi4ytRvqCewqytZhdRNMVaaSofXGEJcsOfhJ+HIQMUpf+MutQ3rSmg/27DEn/RjNBAZsZf7YwxZbYP20cc5qPVYyihx0Lz1TP+lRlzlrMqwgZoDecSLTEksIn6i+YvzBtBdZC1hL/Z7WEMWZWC+deqfhyiv9J4VyNiVtF8hVkwj11cHGZ2tiIw/9IsE/cLKqS+rhbCwTgzNWJdiCeP0KDnj79SwURBVwSCLjjUU8c8TUb0L5/iijOF+73l0sOgEZd7o89WUn401LxOTi4Ay3cwGXNTGzxRi5fmkMqGmccJ4awt1V8qra06CSZ2vHyIN373zFjeBl97VLYyWf4pHf5TPTjbPaa5/B2S5o0IYumsLPl9xwXntP3VqfN0c1jGsef6eSkaFO7NhKG6F8K1SlX0R0J7c13Z5Gd2EPIG+hkoo8Z6X9SYQdN5P6oUQgQRRhkuiGHV2CKhq9Nv6PmkCAZNlqYAUAzn/GfrkwP1kJTThSV2dzJXF7vkrUSg5FXLT7tUJDeI9ZuZyFf3FKwfcSsGyxqXmtl2gzxw7+fud6A+W94E6pLiM54jCI6QhbSd5GhYUs1jm4gWFCwGLqvY8Jnh4BtehdrhMKndNzQFJbzN6mCWH5HbjWF7c5+eHI7IE8ZgwV/MmOJcMRChgJtMkUhLDxMYAjH9lXK8ByndbhWxwcD8M0TSAOj1p649S1d/5AP9BRRaDq4y3O/ptvnBOVpUmOdfFwpwMJpLBSQ+QC4BIhL6LwPoBpLyt7i6Gvcg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(6862004)(2906002)(5660300002)(52536014)(66476007)(8936002)(83380400001)(41300700001)(8676002)(4326008)(6506007)(66946007)(66556008)(66446008)(64756008)(76116006)(33656002)(4744005)(82960400001)(7696005)(186003)(478600001)(26005)(316002)(9686003)(122000001)(71200400001)(38070700005)(6636002)(55016003)(38100700002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MrDGSaE+tp0jOctazuZfcRxnVkoEdd5NYb7NYos0+f3bY7uMgH2V4CMrRx0c?= =?us-ascii?Q?lz6j/OK36rhXjixxddVAyF4T1bbCqDp7aQP0piEHnWxgopXMzOWyo8gMSfhB?= =?us-ascii?Q?5JRFQ5jw9db0r8V62dbFao9CiUmTBzW3eaDnDJSZwwTDvoFaPmuT6z0hLjNB?= =?us-ascii?Q?VKEKY6wcjU17PLS4FkkElZgAOBcnTBegxRL4KsG5EfRW9fCayW6wFJh1TVvt?= =?us-ascii?Q?GbMXDwxQmsStEWVHFeOvIjff9I73FVSfkJBuMjNxUfskZkXHPMyQPICdANXj?= =?us-ascii?Q?dUSKL3hrYoz1byGGJW/Mz2OtK0hL6JNAY97z2zITUisy2zHQq6bQnXXaM0v4?= =?us-ascii?Q?Tj44Cgl0f99vEP4sLVPrrK+yWidAvRFcYCo2ZgHYcf3ZrUfQvSewSlbvrrf5?= =?us-ascii?Q?PJrXXfc3R5VFptwgX0xBwLdunBmv6kA09h9zI0gmmgfYmzGDPN5KVSTPGMBI?= =?us-ascii?Q?Kncr2Pj9gpoELx6vnprJfLpjXOIpOMIAm7r+K2VxWxXCSoxVJ5LTIYvBoZ/s?= =?us-ascii?Q?uJq7fvAs6qhz4zpVMQZN7TiQouWvylLEnS9km9R8Uga7Ak3wkub23ePT/Sjy?= =?us-ascii?Q?hBtFfKVr3LL9aL7p1BVYs6fMlHWAJIglzM73MEicYFAFZ2pSe2+dlRPv3sNd?= =?us-ascii?Q?i7UkvgZtPc4m/wdznmX4jkoLPRU6TQOQIiQAlKxnRvVR1zX9T5UEvCfH+Hz2?= =?us-ascii?Q?vjBtDimbUmGC7vq26Gb4LYdvRyOANvDig+c0Je2hs0woxIrg2PpwowkjvXa2?= =?us-ascii?Q?Bj54p4z9mvXIAd0yKSOMOf2lzoguHYk+6YOgRymBskQ9YGNdpjqcQXqQFoa0?= =?us-ascii?Q?T9F8q68yA4jMK7x55qsph+Zn7R8L8c1k9BsG+DtbzbAFYk7QM3EcYMMzZ8Kf?= =?us-ascii?Q?Ip94HYIiWeMzhzJc+Hl4hCuyvdpJB+xbeli5rnedpFPmf9dHQonMSPVFaxg0?= =?us-ascii?Q?JVWLHuLCkDB7BXaxlqrdeeIAwqaUKrKC9GpjP3VTRW2ZlzvoA5j9mZ+4E9Gw?= =?us-ascii?Q?AZ45SZfbG7lkYUgrzkCgi8OoELuiIx8vNiN8F0hRDuXB6X748rRhTQLVLkl7?= =?us-ascii?Q?F2z+f0sH4bXWWS7dB0QRNIQ4dr75uFJPBdoKfsNsW1LZnJZ2xj8WjAmmQ/gZ?= =?us-ascii?Q?HxCLYjvXhkZ3VLCJOksJTmQtjxPFSLNcIvwO2EyKzBA8iefbhKdfqpbQFps0?= =?us-ascii?Q?RUXWQIiEOxUsQp1H0dYI3fIsbYotw1387/5JVSsSaDPoIQQC26a5kFbWetri?= =?us-ascii?Q?XKd7qhWPfBvPSWXYt3rDydisi6+VVs2knrwYX6sxGlEH3eNP0RRAueuZyQV+?= =?us-ascii?Q?xMQ79HVBf6z3SlM0BSu7fzEzACWOPU97g1c6KaallhOBkWvRnGsB1iWMmA8z?= =?us-ascii?Q?ku3KGSN+YpY8qIPUDwwwISuXIqMKXGbP5iJzLUQU4G0ALf/PWKrD922dcW7z?= =?us-ascii?Q?ypR8Ho1NDT6IojuqA/1nx85un5KBv3jyralvq11JoM4hllTUyMzNp0mBGz4x?= =?us-ascii?Q?DMLKTVC1XehfQS3sRt8KvS5Akm6agz47bcsLbEcAfZJVAgTppYKcSpGfYGcR?= =?us-ascii?Q?T6topdKLYAGgs17l0A9DBtNfL2eE6zVTp5gjU04NFdrTSjcqAt4nJSgb+5/Q?= =?us-ascii?Q?lw=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4c8c0ef-4f95-483a-28dc-08dab1e09c5a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 14:45:47.9979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hv8eHdccT97AhuPLaizb7UunxK38jOzYS2FDCdWo9SKzFVwMlv5bLxvVuDI8Uanyi8bZEOjSd5k8HW1Hhf/f7JFvO4N/F1rqpuOcGjZgrv4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7053 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2022 14:46:20 -0000 Hello Felix, >The documentation parts basically didn't change since Eli approved them. >I only made a very minor documentation change in patch 7 to reflect the >change to a boolean. > >Here is the status of each patch: >1: Approved. >2: Fixed minor formatting comment. >3: Renamed a define based on comments from Markus. >4: Approved. Only fixed a nit. >5: Fixed minor formatting comment. >6: Approved by Markus, with a request that other maintainers might want > to look at the Python parts. >7: Changed Qbtrace-conf:pt:ptwrite to a boolean. >8: Approved. Only fixed a nit. >9: Reworked GIL, error messages and DECREF logic in py-record-btrace.c. > Reworked ptwrite.py according to Markus comments. >10: Approved. Only fixed a nit. I re-reviewed patches 3, 7, and 9. Btrace bits are OK with the remaining comments addressed. For the python bits, you need a global maintainer's approval. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928