From: "Yan, Zhiyong" <Zhiyong.Yan@windriver.com>
To: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"tom@tromey.com" <tom@tromey.com>
Subject: RE: [PATCH] gdbserver: Install single-step breakpoint for a pending thread whose last_resume_kind is resume_step
Date: Tue, 11 Jul 2023 01:49:35 +0000 [thread overview]
Message-ID: <DS0PR11MB644754EC7028335DBB548915E731A@DS0PR11MB6447.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJVr-EMT89i8KTZ1DcVXJgKw_2f9uKF7YCGSJDfgTLgJxfOm3g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]
Hi Alexandra,
Thanks for your feedback.
Best Regards.
Zhiyong
From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Sent: Monday, July 10, 2023 8:46 PM
To: Yan, Zhiyong <Zhiyong.Yan@windriver.com>
Cc: gdb-patches@sourceware.org; tom@tromey.com
Subject: Re: [PATCH] gdbserver: Install single-step breakpoint for a pending thread whose last_resume_kind is resume_step
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.
On Mon, Jul 3, 2023 at 5:05 AM <zhiyong.yan@windriver.com<mailto:zhiyong.yan@windriver.com>> wrote:
From: Zhiyong Yan <zhiyong.yan@windriver.com<mailto:zhiyong.yan@windriver.com>>
Gdb should not assume pending threads always generate “a non-gdbserver trap event”, for example “Signal 17” event could happen. Now that resume_stopped_resumed_lwps() -> may_hw_step() assumes that the break point must already exist, resume_one_thread() should ensure the software breaking point is installed although the thread is pending.
Signed-off-by: Zhiyong Yan zhiyong.yan@windriver.com<mailto:zhiyong.yan@windriver.com>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30387<https://urldefense.com/v3/__https:/sourceware.org/bugzilla/show_bug.cgi?id=30387__;!!AjveYdw8EvQ!fkg3Ae-1jPyI75siqABZuT57DvfkxmNtWeqO1A1Jly9PEvrBravJqc2Eou3b6H0Qfc31GRg9fixINWkyyZW8IwY$>
I can confirm this patch causes no regression Fedora-Rawhide, ppc64le.
next prev parent reply other threads:[~2023-07-11 1:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 3:04 zhiyong.yan
2023-07-10 12:46 ` Alexandra Petlanova Hajkova
2023-07-11 1:49 ` Yan, Zhiyong [this message]
2023-07-11 18:42 ` Kevin Buettner
2023-07-12 2:17 ` Yan, Zhiyong
[not found] ` <DS0PR11MB644704609A8C731570939D96E736A@DS0PR11MB6447.namprd11.prod.outlook.com>
2023-07-12 3:29 ` Yan, Zhiyong
2023-07-17 9:35 ` Luis Machado
2023-07-12 3:19 zhiyong.yan
2023-07-12 3:25 zhiyong.yan
2023-07-21 20:49 ` Kevin Buettner
2023-07-24 13:36 ` Yan, Zhiyong
2023-07-25 3:36 ` Kevin Buettner
[not found] ` <DS0PR11MB6447E74277EE65464375E086E703A@DS0PR11MB6447.namprd11.prod.outlook.com>
2023-07-25 6:32 ` Kevin Buettner
2023-07-25 6:50 ` Yan, Zhiyong
2023-07-25 7:05 ` Yan, Zhiyong
2023-07-26 3:58 ` Kevin Buettner
2023-07-26 6:30 ` Yan, Zhiyong
2023-07-12 3:25 zhiyong.yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR11MB644754EC7028335DBB548915E731A@DS0PR11MB6447.namprd11.prod.outlook.com \
--to=zhiyong.yan@windriver.com \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).