From: Eli Zaretskii <eliz@gnu.org>
To: Michael Snyder <msnyder@vmware.com>
Cc: brobecker@adacore.com, teawater@gmail.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] record.c: make prec can save the execution log to a pic file
Date: Thu, 02 Sep 2010 13:12:00 -0000 [thread overview]
Message-ID: <E1Or1px-0004q4-Ox@fencepost.gnu.org> (raw)
In-Reply-To: <4C7EDF79.9050904@vmware.com> (message from Michael Snyder on Wed, 01 Sep 2010 16:19:21 -0700)
> Date: Wed, 01 Sep 2010 16:19:21 -0700
> From: Michael Snyder <msnyder@vmware.com>
> CC: Hui Zhu <teawater@gmail.com>, gdb-patches ml <gdb-patches@sourceware.org>
> > However, I still believe that it is better to back it out for now.
> > First of all, I've already suggested that the code in record.c be
> > at least properly documented, but this never happened. Second of all,
> > I think that the current format used in the nodes titles is inconsistent
> > and makes the resulting graph less useful. What I believe we should do,
> > for this feature, is first go to the drawing board to describe precisely
> > what we want, and only then implement it.
>
> I agree. It needs more discussion.
I will go with whatever you decide. Given the clear description by
Joel of how it works (thanks!), I will be able to rewrite the manual
sections, after a few followup questions. So if the decision is to
keep the patch, I can fix the docs quite quickly.
next prev parent reply other threads:[~2010-09-02 4:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 17:13 Hui Zhu
2010-06-16 0:42 ` Michael Snyder
2010-06-16 4:46 ` Hui Zhu
2010-06-16 13:51 ` Hui Zhu
2010-06-18 7:31 ` Hui Zhu
2010-06-22 2:17 ` Hui Zhu
2010-06-25 6:22 ` Hui Zhu
2010-09-02 1:04 ` Joel Brobecker
2010-09-02 1:55 ` Michael Snyder
2010-09-02 13:12 ` Eli Zaretskii [this message]
2010-09-03 1:20 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Or1px-0004q4-Ox@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).