From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24247 invoked by alias); 2 Sep 2010 04:55:56 -0000 Received: (qmail 24234 invoked by uid 22791); 2 Sep 2010 04:55:53 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Sep 2010 04:55:48 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1Or1px-0004q4-Ox; Thu, 02 Sep 2010 00:55:45 -0400 From: Eli Zaretskii To: Michael Snyder CC: brobecker@adacore.com, teawater@gmail.com, gdb-patches@sourceware.org In-reply-to: <4C7EDF79.9050904@vmware.com> (message from Michael Snyder on Wed, 01 Sep 2010 16:19:21 -0700) Subject: Re: [PATCH] record.c: make prec can save the execution log to a pic file Reply-to: Eli Zaretskii References: <4C181DF2.7030604@vmware.com> <20100901231633.GA16396@adacore.com> <4C7EDF79.9050904@vmware.com> Message-Id: Date: Thu, 02 Sep 2010 13:12:00 -0000 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00083.txt.bz2 > Date: Wed, 01 Sep 2010 16:19:21 -0700 > From: Michael Snyder > CC: Hui Zhu , gdb-patches ml > > However, I still believe that it is better to back it out for now. > > First of all, I've already suggested that the code in record.c be > > at least properly documented, but this never happened. Second of all, > > I think that the current format used in the nodes titles is inconsistent > > and makes the resulting graph less useful. What I believe we should do, > > for this feature, is first go to the drawing board to describe precisely > > what we want, and only then implement it. > > I agree. It needs more discussion. I will go with whatever you decide. Given the clear description by Joel of how it works (thanks!), I will be able to rewrite the manual sections, after a few followup questions. So if the decision is to keep the patch, I can fix the docs quite quickly.