* [RFA/Obvious] Fix go32v2 compilation.
@ 2010-10-12 15:01 Pierre Muller
2010-10-12 15:27 ` Pedro Alves
2010-10-12 15:33 ` Eli Zaretskii
0 siblings, 2 replies; 3+ messages in thread
From: Pierre Muller @ 2010-10-12 15:01 UTC (permalink / raw)
To: gdb-patches; +Cc: 'Eli Zaretskii', 'Pedro Alves'
Go32v2 native target doesn't compile anymore...
since a patch by Pedro dating back 2010-08-20 :(
Which sadly means that not many persons currently still try to use
current CVS tree for go32v2...
I almost checked this in as obvious, but
I didn't really get if this function was necessary or not.
Pedro, is setting this function to NULL enough to
maintain old functionality for DJGPP
or should a dos specific function be implemented?
Pierre Muller
Pascal language support maintainer for GDB
ChangeLog entry:
2010-10-12 Pierre Muller <muller@ics.u-strasbg.fr>
* ser-go32.c (struct dos_ops) Add missing fdopen field.
Index: ser-go32.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-go32.c,v
retrieving revision 1.24
diff -u -p -r1.24 ser-go32.c
--- ser-go32.c 20 Aug 2010 18:49:20 -0000 1.24
+++ ser-go32.c 12 Oct 2010 14:54:53 -0000
@@ -843,6 +843,7 @@ static struct serial_ops dos_ops =
0,
dos_open,
dos_close,
+ NULL, /* fdopen, not implemented */
dos_readchar,
dos_write,
dos_noop, /* flush output */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA/Obvious] Fix go32v2 compilation.
2010-10-12 15:01 [RFA/Obvious] Fix go32v2 compilation Pierre Muller
@ 2010-10-12 15:27 ` Pedro Alves
2010-10-12 15:33 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Pedro Alves @ 2010-10-12 15:27 UTC (permalink / raw)
To: Pierre Muller; +Cc: gdb-patches, 'Eli Zaretskii'
On Tuesday 12 October 2010 16:01:10, Pierre Muller wrote:
> Pedro, is setting this function to NULL enough to
> maintain old functionality for DJGPP
> or should a dos specific function be implemented?
Yes, it's enough. Aparently, ser-go32.c has the only serial_ops instance
that isn't malloc+memset'ed, and I missed that.
--
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA/Obvious] Fix go32v2 compilation.
2010-10-12 15:01 [RFA/Obvious] Fix go32v2 compilation Pierre Muller
2010-10-12 15:27 ` Pedro Alves
@ 2010-10-12 15:33 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2010-10-12 15:33 UTC (permalink / raw)
To: Pierre Muller; +Cc: gdb-patches, pedro
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: "'Eli Zaretskii'" <eliz@gnu.org>, "'Pedro Alves'" <pedro@codesourcery.com>
> Date: Tue, 12 Oct 2010 17:01:10 +0200
>
> Go32v2 native target doesn't compile anymore...
> since a patch by Pedro dating back 2010-08-20 :(
>
> Which sadly means that not many persons currently still try to use
> current CVS tree for go32v2...
That's true. I don't have enough time to compile it except
occasionally. Too busy developing bidirectional editing support for
Emacs.
Thanks for fixing this.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-12 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-12 15:01 [RFA/Obvious] Fix go32v2 compilation Pierre Muller
2010-10-12 15:27 ` Pedro Alves
2010-10-12 15:33 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).