From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84059-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17264 invoked by alias); 4 Oct 2011 06:11:54 -0000
Received: (qmail 17251 invoked by uid 22791); 4 Oct 2011 06:11:52 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Oct 2011 06:11:38 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1RAyE5-0006y9-Bz; Tue, 04 Oct 2011 02:11:37 -0400
Date: Tue, 04 Oct 2011 06:11:00 -0000
Message-Id: <E1RAyE5-0006y9-Bz@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: gdb-patches@sourceware.org, ppluzhnikov@google.com
In-reply-to: <20111003215530.GC20272@host1.jankratochvil.net> (message from	Jan Kratochvil on Mon, 3 Oct 2011 23:55:30 +0200)
Subject: Re: [patch 3/3] Implement qXfer:libraries for Linux/gdbserver #2
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <20111003215530.GC20272@host1.jankratochvil.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00062.txt.bz2

> Date: Mon, 3 Oct 2011 23:55:30 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Paul Pluzhnikov <ppluzhnikov@google.com>
> 
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -36412,15 +36412,21 @@ are loaded.
>  
>  The @samp{qXfer:libraries:read} packet returns an XML document which
>  lists loaded libraries and their offsets.  Each library has an
> -associated name and one or more segment or section base addresses,
> -which report where the library was loaded in memory.
> +associated name and one or more segment, section base addresses or SVR4 linker
> +parameters, which report where the library was loaded in memory.

Please reword:

 ... one or more segment addresses, section base addresses, or SVR4
 linker parameters.  These describe where the library was loaded into
 memory.

> +depend on the library's link-time base addresses.  For SVR4 systems
> +are reported parameters @{lm} with address of @code{struct link_map}
> +used for TLS (Thread Local Storage) access, @code{l_addr} specifying
> +bias of the mapped memory address minus the prelinked base address
> +and also @code{l_ld} which is memory address of the @code{PT_DYNAMIC}
> +segment.  SVR4 systems additionally specify @code{struct link_map}
> +address of the main executable in the @code{<library-list>} element.

This is too much for a single sentence.  I suggest an itemized list
instead:

 For SVR4 systems, the following parameters are reported:

 @itemize @minus
 @item
 @code{lm} with address of @code{struct link_map} used ...
 @item
 @code{l_ld}, which is memory address of ...
 ...
 @end itemize

And btw, are we sure that sayin "SVR4 systems" is enough to
unambiguously identify those systems?  How about at least a partial
list in parentheses?

> +  if (*phdr_memaddr == 0 || *num_phdr == 0)
> +    {
> +      warning ("Unexpected missing AT_PHDR and/or AT_PHNUM: "
> +	       "phdr_memaddr = %ld, phdr_num = %d",

No _() ?  Doesn't gdbserver support translations of messages?