From: Alan Hayward <Alan.Hayward@arm.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: GDB Patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH] Document style behavior in batch mode.
Date: Thu, 21 Feb 2019 18:26:00 -0000 [thread overview]
Message-ID: <E82D0F96-74D5-4297-AB9D-A870619A69E9@arm.com> (raw)
In-Reply-To: <83tvgxfa7q.fsf@gnu.org>
> On 21 Feb 2019, at 15:11, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Alan Hayward <Alan.Hayward@arm.com>
>> CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com>
>> Date: Thu, 21 Feb 2019 13:23:44 +0000
>>
>> Style is disabled when running in batch mode.
>>
>> gdb/ChangeLog:
>>
>> 2019-02-21 Alan Hayward <alan.hayward@arm.com>
>>
>> * NEWS: Update style defaults.
>>
>> gdb/doc/ChangeLog:
>>
>> 2019-02-21 Alan Hayward <alan.hayward@arm.com>
>>
>> * gdb.texinfo: Update style defaults.
>
> This is OK, but:
>
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -24514,8 +24514,9 @@ Show the current pagination mode.
>> @kindex set style
>> @kindex show style
>> @value{GDBN} can style its output on a capable terminal. This is
>> -enabled by default on most systems. Various style settings are
>> -available; and styles can also be disabled entirely.
>> +enabled by default on most systems, but disabled by default when in
>> +batch mode. Various style settings are available; and styles can
>> +also be disabled entirely.
>
> Please insert "(@pxref{Mode Options})" (without the quotes) after
> "batch mode", to provide the readers of the manual with a hyperlink to
> where that mode is described.
>
> Thanks.
Thanks!
Patch pushed as:
diff --git a/gdb/NEWS b/gdb/NEWS
index eaef6aa384..8fe961b3f3 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -141,7 +141,7 @@ show tui tab-width NCHARS
set style enabled [on|off]
show style enabled
Enable or disable terminal styling. Styling is enabled by default
- on most hosts.
+ on most hosts, but disabled by default when in batch mode.
set style filename foreground COLOR
set style filename background COLOR
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 6b47026aa0..977cc7bbdb 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -24514,8 +24514,9 @@ Show the current pagination mode.
@kindex set style
@kindex show style
@value{GDBN} can style its output on a capable terminal. This is
-enabled by default on most systems. Various style settings are
-available; and styles can also be disabled entirely.
+enabled by default on most systems, but disabled by default when in
+batch mode (@pxref{Mode Options}). Various style settings are available;
+and styles can also be disabled entirely.
@table @code
@item set style enabled @samp{on|off}
prev parent reply other threads:[~2019-02-21 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 13:23 Alan Hayward
2019-02-21 15:11 ` Eli Zaretskii
2019-02-21 18:26 ` Alan Hayward [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E82D0F96-74D5-4297-AB9D-A870619A69E9@arm.com \
--to=alan.hayward@arm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).