Thanks for review. Here is updated patch. > > + /* Assume the disassembler always read memory forwards. If we > "always reads" Fixed. > > + useless to keep retrying reading that buffer line. Simply > > + fallback to reading directly from target memory. */ > > Should be "retrying to read", I think. Fixed. > > + /* Try fetching a new buffer line from the target. */ > > Hmm, this seems to miss making sure LEN doesn't read beyond the original > requested memory range. It'd be good to add that. Changed to following line which should take care of this. unsigned int length = min (len, info->buffer_length); > > That "unsigned int len" variable shadows the function's "len" > parameter. It'd be good to rename it. Fixed. > > > -- > Pedro Alves