From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 1EDD0385840F for ; Sun, 20 Feb 2022 04:09:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EDD0385840F Received: by mail-qk1-x72c.google.com with SMTP id f10so8124960qkg.9 for ; Sat, 19 Feb 2022 20:09:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BbbJAFGVTM44oadytbUxsQa/SAW9aIjixhiAkReNI+w=; b=HFsA+4QN8yMH0QuQlJlB5/UQUltIk6UBKI855LXRTiQ/zRvVfR0lRDm9jH8ayEKKAj 6TOhrsTpYeAjANZUHkSZR+959nrxE1Oo1XhPDk63ezuEeF8HrQRz26/1m2CdslrAPCyz LsjUqQDt3Buy6gaPR1DK5Lqhf4PmXc5T8/V12SsnETmoQd1oLege0o40JR9GqTaAjRX9 YRwrqHkUWPS39cBtVfMUXiyd8I+60cDMBxUQvipiOY/Mm0Ewomqxf6rjVmKYk+5y4UvE +B2JWcXmR9diMwAWsCtzhKSExdwA/awRzUSWQnmCHd6We6qzbVI/Z5V+SteiWbN5aCv5 2p4A== X-Gm-Message-State: AOAM532iwbiq+s92J7F+yGYgfLFVHuUWYKO6eyKmjuFShMg86W7Cs7jf PUkxxERsfteJEMj9TboCPFGH2BL06GVmyA== X-Google-Smtp-Source: ABdhPJz/8iMA312dGnFSXbtbr3YpfgTH8Z5p2JcsCUHVi3njgPSbzxslC9d+2zg+WhztDGxmgZX16g== X-Received: by 2002:ae9:e718:0:b0:60b:dcd1:940b with SMTP id m24-20020ae9e718000000b0060bdcd1940bmr8916424qka.551.1645330151401; Sat, 19 Feb 2022 20:09:11 -0800 (PST) Received: from [192.168.50.237] (modemcable064.93-201-24.mc.videotron.ca. [24.201.93.64]) by smtp.gmail.com with ESMTPSA id h16sm1496393qth.87.2022.02.19.20.09.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Feb 2022 20:09:10 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS From: Philippe Blain X-Mailer: iPhone Mail (16B92) In-Reply-To: <46f0e775-0904-092d-93dd-df263fbd28d7@polymtl.ca> Date: Sat, 19 Feb 2022 23:09:10 -0500 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220219234029.28070-1-levraiphilippeblain@gmail.com> <46f0e775-0904-092d-93dd-df263fbd28d7@polymtl.ca> To: Simon Marchi X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Feb 2022 04:09:13 -0000 Hi Simon, > Le 19 f=C3=A9vr. 2022 =C3=A0 20:41, Simon Marchi = a =C3=A9crit : >=20 >> On 2022-02-19 18:40, Philippe Blain via Gdb-patches wrote: >> The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013 >> ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to >> disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07) >> to point to the data directory, but its default value mentioned in the >> testsuite's README was not kept up to date. >>=20 >> Update the README accordingly, and mention where the default value is >> set, so that it's easier for futur new contributors to check if the >> default mentioned in the README is still current. >> --- >>=20 >> Notes: >> I noticed that while testing the fix for PR 24069, since I wanted >> to use my '~/.gdbinit' with 'set startup-with-shell off' for all tests= , >> and found out that setting INTERNAL_GDBFLAGS to only '-nw' made some t= hings >> a little worse (as GDB was then missing '-data-directory'). >>=20 >> Meta note: when I sent this patch earlier (and messed-up my CCs) in [1= ], I was >> confused by the fact that my CCs for Simon, Doug Evans and Tom de Vrie= s were >> not showing up on public-inbox, even in the "raw" view [2]. After a li= ttle >> web search I think this is due to them setting the mailman "avoid dupl= icates" >> setting [3]. >>=20 >> [1] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphil= ippeblain@gmail.com/T/#u >> [2] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphil= ippeblain@gmail.com/raw >> [3] https://wiki.list.org/DOC/Mailman%202.1%20Members%20Manual#A7.2_Ho= w_can_I_avoid_getting_duplicate_messages.3F_.28duplicates_option.29 >>=20 >> gdb/testsuite/README | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >>=20 >> diff --git a/gdb/testsuite/README b/gdb/testsuite/README >> index 7552774c78b..2d3f1c45966 100644 >> --- a/gdb/testsuite/README >> +++ b/gdb/testsuite/README >> @@ -168,11 +168,14 @@ INTERNAL_GDBFLAGS >>=20 >> Command line options passed to all GDB invocations. >>=20 >> -The default is "-nw -nx". >> +The default is set in lib/gdb.exp and is currently >> +"-nw -nx -data-directory /path/to/build/directory/gdb/data-directory -ie= x 'set height 0' -iex 'set width 0'". >>=20 >> `-nw' disables any of the windowed interfaces. >> `-nx' disables ~/.gdbinit, so that it doesn't interfere with >> the tests. >> +`-data-directory` points the the data directory in the build directory >> +`-iex 'set {height,width} 0'` disables pagination >=20 > I think this should just say "see the default in lib/gdb.exp", and the > flags can be explained there. That would avoid things getting out of > sync. Yes, you are probably right. I can send an updated patch with that change.=20= Philippe.=20