From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: [MI] Fix segfault for -remove-inferior
Date: Wed, 04 Aug 2010 19:56:00 -0000 [thread overview]
Message-ID: <F7CE05678329534C957159168FA70DEC5716CCBF42@EUSAACMS0703.eamcs.ericsson.se> (raw)
Hi,
I started to play around with MI multi-exec and got a segfault.
Below is the session showing the problem and the patch to fix it.
I think this should go into the 7.2 branch.
(I did not have time to run the test suite)
OK?
Marc
GNU gdb (GDB) 7.2.50.20100727-cvs
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
(gdb) interpreter-exec mi "-remove-inferior i1"
Segmentation fault
2010-08-04 Marc Khouzam <marc.khouzam@ericsson.com>
* mi/mi-main.c (mi_cmd_remove_inferior): Properly access first argument.
### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-main.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
retrieving revision 1.178
diff -u -r1.178 mi-main.c
--- gdb/mi/mi-main.c 11 Jun 2010 15:36:07 -0000 1.178
+++ gdb/mi/mi-main.c 4 Aug 2010 19:40:19 -0000
@@ -1609,7 +1609,7 @@
if (argc != 1)
error ("-remove-inferior should be passed a single argument");
- if (sscanf (argv[1], "i%d", &id) != 1)
+ if (sscanf (argv[0], "i%d", &id) != 1)
error ("the thread group id is syntactically invalid");
inf = find_inferior_id (id);
next reply other threads:[~2010-08-04 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 19:56 Marc Khouzam [this message]
2010-08-05 14:47 ` Pedro Alves
2010-08-05 16:07 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7CE05678329534C957159168FA70DEC5716CCBF42@EUSAACMS0703.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).