From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74738-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22611 invoked by alias); 4 Aug 2010 19:56:55 -0000
Received: (qmail 22601 invoked by uid 22791); 4 Aug 2010 19:56:54 -0000
X-SWARE-Spam-Status: No, hits=-0.0 required=5.0	tests=AWL,BAYES_00,RCVD_ILLEGAL_IP
X-Spam-Check-By: sourceware.org
Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.8)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Aug 2010 19:56:50 +0000
Received: from eusaamw0711.eamcs.ericsson.se ([147.117.20.178])	by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id o74Jw0Ps024861	for <gdb-patches@sourceware.org>; Wed, 4 Aug 2010 14:58:03 -0500
Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.134]) by eusaamw0711.eamcs.ericsson.se ([147.117.20.178]) with mapi; Wed, 4 Aug 2010 15:56:47 -0400
From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Date: Wed, 04 Aug 2010 19:56:00 -0000
Subject: [MI] Fix segfault for -remove-inferior
Message-ID: <F7CE05678329534C957159168FA70DEC5716CCBF42@EUSAACMS0703.eamcs.ericsson.se>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00020.txt.bz2

Hi,

I started to play around with MI multi-exec and got a segfault.
Below is the session showing the problem and the patch to fix it.
I think this should go into the 7.2 branch.

(I did not have time to run the test suite)

OK?

Marc


GNU gdb (GDB) 7.2.50.20100727-cvs
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.htm=
l>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
(gdb) interpreter-exec mi "-remove-inferior i1"
Segmentation fault


2010-08-04  Marc Khouzam  <marc.khouzam@ericsson.com>

	* mi/mi-main.c (mi_cmd_remove_inferior): Properly access first argument.


### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-main.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
retrieving revision 1.178
diff -u -r1.178 mi-main.c
--- gdb/mi/mi-main.c    11 Jun 2010 15:36:07 -0000      1.178
+++ gdb/mi/mi-main.c    4 Aug 2010 19:40:19 -0000
@@ -1609,7 +1609,7 @@
   if (argc !=3D 1)
     error ("-remove-inferior should be passed a single argument");
=20
-  if (sscanf (argv[1], "i%d", &id) !=3D 1)
+  if (sscanf (argv[0], "i%d", &id) !=3D 1)
     error ("the thread group id is syntactically invalid");
=20
   inf =3D find_inferior_id (id);
=20