RE: [patch] Adding 'reverse' to -list-target-features

[Marc Khouzam <marc.khouzam@ericsson.com>]

 

> -----Original Message-----
> From: Eli Zaretskii [mailto:eliz@gnu.org] 
> Sent: Wednesday, September 01, 2010 12:41 PM
> To: Marc Khouzam
> Cc: gdb-patches@sourceware.org; pedro@codesourcery.com; 
> msnyder@vmware.com
> Subject: Re: [patch] Adding 'reverse' to -list-target-features
> 
> > From: Marc Khouzam <marc.khouzam@ericsson.com>
> > Date: Wed, 1 Sep 2010 12:13:32 -0400
> > 
> > +@item reverse
> > +Indicates that the target is capable of reverse execution.
> 
> This is okay, but please add a cross-reference to where reverse
> execution is described.


Updated the docs:

2010-09-01  Marc Khouzam  <marc.khouzam@ericsson.com>

       * mi/mi-main.c (mi_cmd_list_target_features): Add `reverse'
       as a feature reported by -list-target-features.

2010-09-01  Marc Khouzam  <marc.khouzam@ericsson.com>
       * gdb.texinfo (GDB/MI Miscellaneous Commands): Document new
       feature `reverse' output by -list-target-features.

Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.761
diff -u -r1.761 gdb.texinfo
--- gdb/doc/gdb.texinfo 31 Aug 2010 14:45:41 -0000      1.761
+++ gdb/doc/gdb.texinfo 1 Sep 2010 16:42:07 -0000
@@ -29030,6 +29030,10 @@
 execution, which means that @value{GDBN} will accept further commands
 while the target is running.
 
+@item reverse
+Indicates that the target is capable of reverse execution.
+@xref{Reverse Execution}, for more information.
+
 @end table
 
 @subheading The @code{-list-thread-groups} Command
Index: gdb/mi/mi-main.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
retrieving revision 1.180
diff -u -r1.180 mi-main.c
--- gdb/mi/mi-main.c    13 Aug 2010 13:22:44 -0000      1.180
+++ gdb/mi/mi-main.c    1 Sep 2010 16:42:07 -0000
@@ -1700,6 +1700,8 @@
       cleanup = make_cleanup_ui_out_list_begin_end (uiout, "features");      
       if (target_can_async_p ())
        ui_out_field_string (uiout, NULL, "async");
+      if (target_can_execute_reverse)
+       ui_out_field_string (uiout, NULL, "reverse");
       
       do_cleanups (cleanup);
       return;