* [PATCH] Fix gdb.arch/aarch64-dbreg-contents.exp FAIL
@ 2021-04-16 15:42 Luis Machado
2021-04-20 10:05 ` Alan Hayward
0 siblings, 1 reply; 2+ messages in thread
From: Luis Machado @ 2021-04-16 15:42 UTC (permalink / raw)
To: gdb-patches
The test checks for a particular ARCH level, but it needs to check for
ARCH levels from a minimum and upwards.
---
gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c b/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
index ca690f63de8..64f02005469 100644
--- a/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
+++ b/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
@@ -54,7 +54,7 @@ set_watchpoint (pid_t pid, volatile void *addr, unsigned len_mask)
errno = 0;
l = ptrace (PTRACE_GETREGSET, pid, NT_ARM_HW_WATCH, &iov);
assert (l == 0);
- assert (AARCH64_DEBUG_ARCH (dreg_state.dbg_info) == AARCH64_DEBUG_ARCH_V8);
+ assert (AARCH64_DEBUG_ARCH (dreg_state.dbg_info) >= AARCH64_DEBUG_ARCH_V8);
assert (AARCH64_DEBUG_NUM_SLOTS (dreg_state.dbg_info) >= 1);
assert (!DR_CONTROL_ENABLED (dreg_state.dbg_regs[0].ctrl));
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix gdb.arch/aarch64-dbreg-contents.exp FAIL
2021-04-16 15:42 [PATCH] Fix gdb.arch/aarch64-dbreg-contents.exp FAIL Luis Machado
@ 2021-04-20 10:05 ` Alan Hayward
0 siblings, 0 replies; 2+ messages in thread
From: Alan Hayward @ 2021-04-20 10:05 UTC (permalink / raw)
To: Luis Machado; +Cc: gdb-patches\@sourceware.org
Other than a missing changeling, this looks good.
Alan.
> On 16 Apr 2021, at 16:42, Luis Machado via Gdb-patches <gdb-patches@sourceware.org> wrote:
>
> The test checks for a particular ARCH level, but it needs to check for
> ARCH levels from a minimum and upwards.
> ---
> gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c b/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
> index ca690f63de8..64f02005469 100644
> --- a/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
> +++ b/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
> @@ -54,7 +54,7 @@ set_watchpoint (pid_t pid, volatile void *addr, unsigned len_mask)
> errno = 0;
> l = ptrace (PTRACE_GETREGSET, pid, NT_ARM_HW_WATCH, &iov);
> assert (l == 0);
> - assert (AARCH64_DEBUG_ARCH (dreg_state.dbg_info) == AARCH64_DEBUG_ARCH_V8);
> + assert (AARCH64_DEBUG_ARCH (dreg_state.dbg_info) >= AARCH64_DEBUG_ARCH_V8);
> assert (AARCH64_DEBUG_NUM_SLOTS (dreg_state.dbg_info) >= 1);
>
> assert (!DR_CONTROL_ENABLED (dreg_state.dbg_regs[0].ctrl));
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-20 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 15:42 [PATCH] Fix gdb.arch/aarch64-dbreg-contents.exp FAIL Luis Machado
2021-04-20 10:05 ` Alan Hayward
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).