From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57669 invoked by alias); 20 Feb 2019 06:50:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57640 invoked by uid 89); 20 Feb 2019 06:50:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=HX-Received:sk:r187mr3, H*r:sk:mail-pg, hear X-HELO: mail-pg1-f170.google.com Received: from mail-pg1-f170.google.com (HELO mail-pg1-f170.google.com) (209.85.215.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Feb 2019 06:50:32 +0000 Received: by mail-pg1-f170.google.com with SMTP id r11so11367889pgp.6 for ; Tue, 19 Feb 2019 22:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joubster-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5AIDK7/z4AD8ghgzZ42enFlbAMb6VRXGjzGSulOm91k=; b=nTxLw6MBOeZFih+ACZnWKzAULNpt8oZ/qbgKJaUthB9YHy6EQMyhsw4+qJyd2StL9O bdU6nKwCFV15KwI9d21MK//Q7DhEFJXXLEwsTHcEXVjTvI7dGpXEVrR9n4JaYPNX2EiY dM7quUg4dO8ufybwJ/UT1ru2lmWQ29k0NWcMz/5LzFtW9I20QvXBZy9lmbpD1Xmp8kUD lKiLu5AA9q7tywe7clO+A2+q0T8ZETwbTq/kY3QG8tn2Rz67JFZcOqi5G9L0Ta3GlQxO 85i10aFpaawtA7sSLDOsUr2gEsisOqacsKNmXtaO+z1rm45d6tv3aJ8L0ZAO0MH2T98j bc4A== Return-Path: Received: from [192.168.7.108] (c-73-71-252-6.hsd1.ca.comcast.net. [73.71.252.6]) by smtp.gmail.com with ESMTPSA id 186sm74954303pga.36.2019.02.19.22.50.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 22:50:30 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: Feedback sought: patch to enable gdb to build on macOS Mojave From: Joubert Nel In-Reply-To: <87d0nolnnb.fsf@tromey.com> Date: Wed, 20 Feb 2019 06:50:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <3A32D160-EC89-4615-8327-041B154923B9@joubster.com> <20190218133855.7525c484@f29-4.lan> <87d0nolnnb.fsf@tromey.com> To: Tom Tromey , Kevin Buettner X-SW-Source: 2019-02/txt/msg00325.txt.bz2 Great.=20 I read the contribution checklist and I think those are all great guideline= s.=20 Before I prepare a formal submission email, it would be helpful to hear whe= ther the actual code differences seem acceptable: https://gist.github.com/j= oubertnel/267ca0fff4eaad494cc19ec3ba7953ed > On Feb 18, 2019, at 2:47 PM, Tom Tromey wrote: >=20 >>>>>> "Kevin" =3D=3D Kevin Buettner writes: >=20 >>> Worth submitting a patch so that others can easily build?=20 >=20 > Kevin> We'd definitely like to have your shadowing fixes for darwin-nat.c > Kevin> (plus fixes for anything else you ran into as well). >=20 > +1 to what Kevin said. > Contribution instructions are here: https://sourceware.org/gdb/contribute/ >=20 > Tom