public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Enze Li <lienze2010@hotmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] gdb: Fix build error on macOS
Date: Mon,  4 Oct 2021 18:03:16 +0800	[thread overview]
Message-ID: <MEAP282MB029370891A815AD567B60CBDDDAE9@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM> (raw)

PR build/28413 notes that the gdb master fails to build on macOS.

Based on De Morgan's law, the expression
!(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
is equal to (!defined __GNUC__ || defined __clang__ || !__OPTIMIZE).
The expression above looks weird, maybe there are some problems with
this way of judging. When any one of the conditions is established, the
subsequent judgment will be ignored.

This patch works around the issue by rewriting the expression of
judgment after referring to the nearby notes.

Tested by building on x86_64-Linux and macOS(Mojave & Catalina).

Bug: https://sourceware.org/PR28413
---
 gnulib/import/c++defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnulib/import/c++defs.h b/gnulib/import/c++defs.h
index 39df1bc76bc..dbbae2f1fa2 100644
--- a/gnulib/import/c++defs.h
+++ b/gnulib/import/c++defs.h
@@ -286,7 +286,7 @@
    _GL_CXXALIASWARN_2 (func, namespace)
 /* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
    we enable the warning only when not optimizing.  */
-# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
+# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
 #  define _GL_CXXALIASWARN_2(func,namespace) \
     _GL_WARN_ON_USE (func, \
                      "The symbol ::" #func " refers to the system function. " \
@@ -314,7 +314,7 @@
    _GL_CXXALIASWARN1_2 (func, rettype, parameters_and_attributes, namespace)
 /* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
    we enable the warning only when not optimizing.  */
-# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
+# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
 #  define _GL_CXXALIASWARN1_2(func,rettype,parameters_and_attributes,namespace) \
     _GL_WARN_ON_USE_CXX (func, rettype, rettype, parameters_and_attributes, \
                          "The symbol ::" #func " refers to the system function. " \
-- 
2.30.2


             reply	other threads:[~2021-10-04 10:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 10:03 Enze Li [this message]
2021-10-04 16:14 ` Simon Marchi
2021-10-05  8:23   ` Enze Li
2021-10-05  4:51 ` Enze Li
2021-10-06  0:05   ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MEAP282MB029370891A815AD567B60CBDDDAE9@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM \
    --to=lienze2010@hotmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).