From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn2161.outbound.protection.outlook.com [40.92.62.161]) by sourceware.org (Postfix) with ESMTPS id BE6673858C20 for ; Wed, 16 Feb 2022 14:31:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE6673858C20 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5KPySlWjnc6cY4IsUQGJsHCJgeOa+Z0FdJv0GIxzK3AQyuq0QFQ8DPLqWnnqVDQuDfI2WSrltc4F+xXunyCshBmggUPh7gw4VMxf9Dq3YetleaDIN0MJLKvKvZuUJmJF1xW3bJTiuYHKed7gtFh4fK1CcgNephUIeAFd9F+8hzRcOC192pMXSjQla3Mrrwd75zIDI70DGEp9O0iNRHQLPRhpMAotXF0t+MTC9HfOdzobfaEWhGuKrEMnrts+PfTIw6HKzPsvHALN9VtmZRkCgYYTlxWWygGQSVFNibVu+ZRhT9fTM/gxQNo4p34DbI7Zu7KLc6qYCKHNoyLU7NYEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oAJ29gVNd1ycLyevCbC3EnjniDeXp5xpAm/iX6jCFt8=; b=HvHsVpSWBnpQymYPk3TYTkrNK/cjw14Dl0j6wuexotQZWS9FHVhc/5vaTEhMjlRJW/JtKqA1qpDnUp9ZlV3YmkX0Jl+fpjVuwRWq7l91LHmSS4gUt6TrU8wkVlgF6S3qR44Z3BRgCwq1Kknt+pd8thvT0dZpjfIeba99Bcu7R26P8iaAokSsSCnKW+as3Ls4BVQx0so9QCXK4h230tdHZ57nIq2+WjaRz4uuVfzCVZzgqB5A/Uj0RUHRyvgkUQdpA/W7PoveTiBC0Kyt+eBKmW8h6WHtw49sr6+RiJdeUTg53ALI2irVKDP3/iHW1x0UwTwzfzdwjWLpeUTfTdTcmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by MEAP282MB0520.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:68::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb 2022 14:31:25 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::7527:42d7:2a06:cecc]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::7527:42d7:2a06:cecc%4]) with mapi id 15.20.4975.019; Wed, 16 Feb 2022 14:31:25 +0000 Message-ID: Subject: Re: [PATCH] Add initializers to bound_minimal_symbol From: Enze Li To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org Date: Wed, 16 Feb 2022 22:31:20 +0800 In-Reply-To: <877d9wrvb7.fsf@tromey.com> References: <20220208204245.2186900-1-tromey@adacore.com> <877d9wrvb7.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 Content-Transfer-Encoding: 8bit X-TMN: [5Jyz3EIgA0MAzGA0gmxTatFK7U5EHtNJ] X-ClientProxiedBy: HK2PR06CA0003.apcprd06.prod.outlook.com (2603:1096:202:2e::15) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f411fcfb-ef6f-4032-250f-08d9f159030a X-MS-TrafficTypeDiagnostic: MEAP282MB0520:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dEuazvXmDAGixcWmQefMyo6+4KwuNFh54bKAE9cWeGehEZijx3rTWYlOxiewV6MVMyRou3KPX5cyQp+6+r4q1nG1RaoY9MqeBBslgZ2MKdQD6ZHwAePkbNMGpvbwINEvwTG2jLpFZ/nGCdDLmT+LyDm8+yK2YKNUFGcb46Ktz+ANTtJCPrxYQEChwGV3TnO8szdvqCYvBuSDR8NJ88sV1mVGb3sHztgZqWqFijiV79iPW4CcE9A4gEu/gK/388nCgTwNAe4fNwsfQanFW10+KjufRoc42zV8uoehgP5sQ5rGfW7a2MmHuwCvJzbE0Y/eWZEBUY3mgUC1G7lqfJiJYXrq/zyOEZOvNBuCpQDjxx6oNDQdMLEqLAULhhCwZteDubGRGwWylobmlncj/RSylmJ4Ybow5jX336m/ikGlPG7EEoYQUE4N5ZuXzEJupF93htsMplO0Am9SRPF2pzF+HSkMoKV5nZGMNiO8IOIDvb6r+ZOZhiHziADWlh7+PGo/tu2ziXxjB0w8l8wDJ09/ncPFFQ9x6dSuVSOOpA4TI3/CuFbdRO3dM4Ce0RI01KfZtJIQPI9+X3f3zqO0TAoncw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M05iVytrZk0wNmQrK2hRLys4MllXNlhqZVROZWZoMkZ6bzBUUTFSNHZRTTZV?= =?utf-8?B?YnQ1aFJBSDR5WGU0UDFrQmZzekowTWEzbTZzQ2htM1VPRzlJUzNyb3lBVW14?= =?utf-8?B?WTBHSnBiUE9lVFlobFpiV1ZmaUxnVy85VTJRKzR6eUlpZVE0Ymd5OVpiVTdF?= =?utf-8?B?SGtHSUoyNmpmbWdyNlNGUFFSK2hSK294ZzVOYTc4TFBYVDdGM2FjV2lXS1hN?= =?utf-8?B?dDV0by9peTZOQ3F5aGNPbjF4czVtY1hxUUV2WlVNcWRhd0dUd28yQlRXVkc1?= =?utf-8?B?N1hrSFZJbEdWanBNT2h4VTJHR0lhWWtSbksxWTE4U3B5SS9YNmdKVlk4emNS?= =?utf-8?B?VXE2NXQwNFlLVEFMVFhrNHlMWU9ZYm5IK3J1dmdsQlhEMldjdGJhY1NBMVlB?= =?utf-8?B?U29LaVZTM1NsbERDOGxQU2FoU01ndUZKS2xnVnRyRnJLcTRQWjdLUWYxMHA0?= =?utf-8?B?cUloaEVWOGk3T3FQOW15Wm5wekgvbFJEbi9xeGdqZU54Q2RKUDZJZGN3WXk3?= =?utf-8?B?blJoc1dNU215RG5uWXZtUW1SUG1EU1Y2cFJydWNRMjlFbXYxdzV5Zlppb0lZ?= =?utf-8?B?a25hRVRoT3lPL0ZadlBwdzFEVEZzekNqWFlaWSsraGxldkZnSi9oUkFvWDkw?= =?utf-8?B?T01wK21pVmg2ekx6YUMrTjVxekZTRFlJMGcvSzkxU0lHTkduTzI1UHMzWVFM?= =?utf-8?B?S3NaK2w5V0NzWmF3Y0pJdk56R3o3eWRORXBHTStPbVhDTlF3S0FQRnB6YUh4?= =?utf-8?B?QU9CMkVTazF4R1FpbzJiYiszd2lQdTJyczhpd2tGckJyZXBIZERISHRrMnI3?= =?utf-8?B?SjNPeE5mMzJBS244QldnWDVROU9sYm90RjMwY0VSWXNJL2doQ2Y4M1JpZVBR?= =?utf-8?B?ZXgwQW9sL24zakZVbDVTbmxkK2haYzhvVTlUcG4va2trTlZUbnNCV0xkWVhG?= =?utf-8?B?MTlpa0tVMG4vcjZvUEJsK0xoSXlXTnBuWGcwbzAyNUI0WkFKMGZBcmdGZ28z?= =?utf-8?B?amdqOGVFQmIwZUROTnRFN1JhZ1llc3ZiMXpEamphZFdmdVJuWHJvQzVLOW5V?= =?utf-8?B?M1ZIV0R0ZEU5MmU4WFV4ZGd4QkNoVXAzdjkvZ2xOTmRIbU9hU1VVdW5HWkpR?= =?utf-8?B?UklmQ2RwWlIyY2QxMjQ3Szl5eW9wMjBkanRhUVR5Qk4vdkNaTW5oeTRNblBK?= =?utf-8?B?aElVS0VxeXV6VjBhOE81RWE5clQwSGRQUlVxYjFwTTgrRy80dnBKVFJ2Q0JQ?= =?utf-8?B?cDNsb3E3RXNTRFRBYm9sK3I1WlkxWVBKTVduR2dxQXJKWEVMQT09?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: f411fcfb-ef6f-4032-250f-08d9f159030a X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 14:31:25.8296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEAP282MB0520 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 14:31:36 -0000 Hi Tom, I also encountered a similar error message when I compiled with clang.Then I found this thread that you are discussing.  I use the following commands to build, $ ./configure --prefix=`pwd`/build CC=clang CXX=clang++ \   CXXFLAGS=-std=gnu++11 --disable-unit-tests It says, =====================================================================   CXX    macroscope.o linespec.c:4276:31: error: no matching constructor for initialization of 'struct bound_minimal_symbol'   struct bound_minimal_symbol mo = {minsym, objfile};                               ^    ~~~~~~~~~~~~~~~~~ ./minsyms.h:29:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided struct bound_minimal_symbol        ^ ./minsyms.h:29:8: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided ./minsyms.h:29:8: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 2 were provided ===================================================================== On Tue, 2022-02-15 at 08:41 -0700, Tom Tromey via Gdb-patches wrote: > Simon> Hmm, I see this with g++-11: > > I'm also using gcc 11 and I don't see this error. It seems that Simon is referring to the use of the C++11 standard. > > Simon> Not sure what's the best way to fix this, possibly to > addconstructors > Simon> to bound_minimal_symbols. > > I wrote the appended and this also built fine.  But I don't know ifit > would work for you. > > Tom With the appended patch, it built fine for me with clang.  And I also tested it with gcc-11 as Simon did and again there were no problems. $ ./configure --prefix=`pwd`/build CXXFLAGS=-std=gnu++11 \   --disable-unit-tests BTW, all tests were conducted on the latest openSUSE Tumbleweed. It has: - gcc (SUSE Linux) 11.2.1 20220103 - clang version 13.0.1 Thanks for fixing this. Cheers! Enze