From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn2145.outbound.protection.outlook.com [40.92.62.145]) by sourceware.org (Postfix) with ESMTPS id 7F2E33858D3C for ; Tue, 19 Apr 2022 13:32:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F2E33858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XbN1y2bre/9fTwrfd4O9xEOCxOkJz5ihYvnU/TPG2TCOs6A8C7D+OF8koulM3f6frDDuicLM1Qs09iejKFkJNBHMksyGEL3vFQdzzFvZh0PuSm9g1a33U6fF6DUUBnXEW8lOyu6TEIbLYCi0hCHbJV+F6dExf2cbLZl6kKqksJvW8jansag/JLs5KVrnY7ZcLFcLDTnNyL5f9nYHAIpbQMb0P3rV9IkUhmsQ8vfX/TgX4v1ZD/UhU2RIvCfvwE9u8XHG+ApEU+o/XIh2syoBVcm0UhFHanZXz7veyCNei9dKTPiCp2kbnZhLW3gRoyfRYRDGZRIAa9pg3UTeODFj3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lz2TyIT5i6J6iKKvPs2tc5aqv0puZgcd51JM/8FAngc=; b=EeYzmJqu5MANko1MQU+yWZ7tWsgEXXAAQoB8Dqxv3/ix41Isph2uIelWn6X8lkKctSdbAhzbS3k7OWMUkxMxIwMkXt26c65KEq7EoLpCfGCfgpWeY5Ndk1MGCHtW16dQvTHGUtXQhXpZ8AlWmGrlpIeq0JrlXUbKowHLyPDQxzqKqnwD0VNMSeucTcHAtmiJOV2TeFz3qcR7tmOc7muLDAvQcyudSmA14bRTVG88g4Srgk9StVDgVfs9Bij713twsO1GHvOIe8cqUXflbWolA3zWeVBPwFEmU9riI58SgEMF0TIE3brYAIdBjkYZMrHtQvxmoF7J24GlojgemII9Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by MEYP282MB3463.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:15d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 13:32:45 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::5804:c2bb:bc94:3cec]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::5804:c2bb:bc94:3cec%6]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 13:32:44 +0000 Message-ID: Subject: Re: [PATCH v3] gdb: fix using clear command to delete non-user breakpoints(PR cli/7161) From: Enze Li To: Simon Marchi , tom@tromey.com Cc: gdb-patches@sourceware.org Date: Tue, 19 Apr 2022 21:32:37 +0800 In-Reply-To: References: <87sfqez4de.fsf@tromey.com> <6affe6c7-cf0f-0c3d-8271-65d6f8a3aba6@polymtl.ca> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.0 X-TMN: [d3qSA+Z9Q9GRezp5nw6wIgtsMyWarkuf] X-ClientProxiedBy: HK2PR02CA0213.apcprd02.prod.outlook.com (2603:1096:201:20::25) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: <08487b24b597a61026cd7070eff1eba41d80198c.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef311662-cbe2-4d99-25a0-08da22091546 X-MS-TrafficTypeDiagnostic: MEYP282MB3463:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N8M7OplkLfA8PL5T/3ARV6Xx7GRyzM7u4DO+PGkJpjLS/RYqhjYbsqJ3ULXKHbh2DnDRuZ4W1ihEvUPgcdF4/Dd66SEWdC7zPTm9zuCn5vYCDhEU3Rj6/u3YUx8UUd/vE8E5AnsGbd0lCB0C+Ur1M6c1qaBtxeysOPZqwH0j5lsbyr/YHKgWfrIyLLOU4oDnHsjgC6W33qI0zy3F7UVX19oS6xf08nuIMn3zQ45dvcQmEPzrCylM0ZFIF+pi7DwleihbJ0+WzDTKtGyFmfgqIncMcKzl0HvMEcSDkkSHPTNvJOQkVm4sEnNgsmukI2650sdvUQeBu/qqkX5auBN7K6nFG6JFxS4Dwhtwf6ur4b+K/UJXk3cirOQbcy/ZwmbMTIluqFpuE7mewHsuc9z/AfAWXf+rL/+y58ZC6MLuhUu7TZIHjrCYcVjqgBPoSBj+G8JOoJvTfSJmeEO3b+hCIH/48fLriqb4rNkVkhnrBs6WgO3UJ1ZjebiCvlQw7v65gT2kc00k+Mbfo8mnzEfjpH0oXy+Y8zKxbAOG817RtRL01CDeHcTvX2r9yPNZEakIUvd1tJLS4Xf1KcT8DFdlLRl/1aleWRUBabhLeYdCtA8cFfZ5c3KSwi/KGelfAZFd X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE9FYWNTcGE2UndPaGNkVjNEODJWMHhNRFBralZkVm9CbUJzN2gxVEVuVjly?= =?utf-8?B?dy9mK0hOR05FU2tReFU5cnJ1THZ1eEtGT0ZXU3I0RjUxYXBHNnBqNS8xTm5T?= =?utf-8?B?NXQvM0dTcm56QkUxWXpvOWJjWGZTYlgwSDNZWTB6NnUvckdwVXhCU2FzeGgy?= =?utf-8?B?U0hBTmlybDdTNmN4Rmw3L0FWYnkzU1hXc3RManA1UUhIVHA1K1VxZEVueG9n?= =?utf-8?B?aHlmSFJmc3BzaHNUaGFWVkpKNmdvckVreVhKOFUzTmo5akoxVXZ4SFlQaFR0?= =?utf-8?B?d2p6V0REMWVDalVOZ21BcXArOXFzby9WVi9SVjBwdXBxREwvUzJoVXA1aFlr?= =?utf-8?B?VnRaWUZXVkRhMlpYS3l2UWpZeTdDQnd0SGJ6dlltTnEzZWtxRkh3RDB2VGE0?= =?utf-8?B?U1paK21Ed28xWVVka2JuV0d4dGVKTG5BaHN4MUJjWVZXOVNNZU9CeVc2dmVC?= =?utf-8?B?WE9QSXRtczRKdFk1dXZUL2pDSXdkeDF4ZDUrVm9hSmRzMnZPeFBKNjBRVjA0?= =?utf-8?B?Z0hTM1hrVlh2ZGxGYVZxU1NieHdsUVZ3aVZlZ3JYODNIK3l3MjZGd1owSVgv?= =?utf-8?B?aVI4Z3VUV1QrVWRFNGtkb1pVZlJSTHV1SHg2bWF3MFQwUXhKN3V3R3hwT01T?= =?utf-8?B?c1U1VE1wOHlLM1lmbStyaGFFaC9RMjkybVdhSUlYQnordURoNFVuVHBsZVJu?= =?utf-8?B?VlBwZjdlS3FKNGFpaVBqSFl5SzkvNHVwVEJmcWZXNlVoM2MxekNkbzRFSFA5?= =?utf-8?B?eFdueWJNOTNnVUlGYnRiYU1QeThKcG9aVk0vZDBHZEZweWxCbGE1ZFVlUkxR?= =?utf-8?B?TDVGYUZiTi9reThiSUFkTkNoU3gxWlFwWlVzR0V3emVvb1dDTUlVZ0pjcjY1?= =?utf-8?B?YWlLSWp0RWlHVjduWVQ4enR4RG5BVVlBNlhoUWJuTk9VTS9IMlpRcGpqYTRw?= =?utf-8?B?R0xZQVhIakdXSG1JOUI1SVN6eGd4R3BSWTVpYjA1c3dGczZyeDducFNlbzNs?= =?utf-8?B?SG9tMStWS3V4QUVzOUVqQnRIUTljQ01MNUZxSENsMy9qL1UrR1BiYUk2VW1N?= =?utf-8?B?cXZZYnZHbGZKQnZHeGl4OTJXbWVsZk1aOWV3UzNmQ1ZzbHl4bk9DVHdnQWIw?= =?utf-8?B?ZnVIOGxDQkduQXVCb0NYN3lEY3FZTENSUUhiTjdvaURtQnEzckxIczBOTVFJ?= =?utf-8?B?b29QZmlGZDZ4bCs2M0ZHTENVVW5TTDJGbkhaZEFWaWpRVE44S0N1Y1lObDBv?= =?utf-8?B?WkZiTEhuNnh1UzltOVkza0duZU82WkNNQnk1QjlVb0k1Y1RVbWtCQ3ZWUzJx?= =?utf-8?B?TzB5OEsvVkpaUllyNmNrd0dRdkRsTlRJRHRnQ3ZOOUxCY1VVdFhEMHFseWgz?= =?utf-8?B?Y3ZsNzJ4aDFMZ0EzdWF6RXhZZnJZaHdXa1R0NXhISHE1eGFDaUJ4MmZ1djhZ?= =?utf-8?B?NjlMSGNoZkxTVXdzVVdEaWR2cHhoUXdCNTQ4T1pDQURDSFY0UmIydXRmZU1l?= =?utf-8?B?Z2VmUkFVM3FUOWFMNC9Xc3R6ZGNJcHFTaFNrNzlJMmZhc0lacHVsV3Q5aTg5?= =?utf-8?B?ZFRBaGpWSVRjNk5uSTFyMjd6bGt3NlNINXE0OWpyc3FoOVJ6bnlYcGgvaWlu?= =?utf-8?B?QUwwU0lGM2ZOUDY5ZW9HcTlFNXNEcmRKQnYza3NsUG05NG1wejFtREM0MEFm?= =?utf-8?B?TWFCdFJkWWNNVWJFM1F4aUV6a2FBWGtzK1VsQk5pcDZ5YXluUU9WOXRhRkpl?= =?utf-8?B?Vm5UZkNMbEcxU3Bja09HcUhVTWxra0Q0RmdEcG1YTEdsKzFhbk1SRVVEMXRS?= =?utf-8?B?bHlsV1FLS0REdlhFeWVOZStUZ3BGL2dTclpCMHFVQUEyYTFCelk1OGhqM0Qw?= =?utf-8?B?RFhqWkJkUHhTQ0VMaHJIUDVUTERLdWtycUxiVERRaVlRazJoSTU1Z2RlNnMy?= =?utf-8?Q?t0llEFUDdhQ=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: ef311662-cbe2-4d99-25a0-08da22091546 X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 13:32:44.9251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEYP282MB3463 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 13:32:55 -0000 On Mon, 2022-04-18 at 23:37 -0400, Simon Marchi wrote: >=20 >=20 > On 2022-04-18 19:49, Simon Marchi via Gdb-patches wrote: > >=20 > >=20 > > On 2022-04-15 23:42, Enze Li via Gdb-patches wrote: > > > The clear command shouldn't delete momentary and internal > > > breakpoints, > > > nor internal breakpoints created via Python's gdb.Breakpoint. > > >=20 > > > This patch fixes this issue and adds a testcase. > > >=20 > > > Regression tested on x86_64 openSUSE > > > Tumbleweed(VERSION_ID=3D"20220413"). > > >=20 > > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D7161 > >=20 > > Hi, > >=20 > > I see this test failing on Ubuntu 20.04: > >=20 > > =C2=A065 maint info break -1^M > > =C2=A066 Num=C2=A0=C2=A0=C2=A0=C2=A0 Type=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Disp Enb Address=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 What^M > > =C2=A067 -1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 shlib events=C2=A0=C2=A0 keep= n=C2=A0=C2=A0 0x00007ffff7fd2fd1 > > inf 1^M > > =C2=A068 -1.1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 y=C2=A0=C2=A0 0x00007ffff7fd2fd1 > > inf 1^M > > =C2=A069 (gdb) maint info break -1^M > > =C2=A070 Num=C2=A0=C2=A0=C2=A0=C2=A0 Type=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Disp Enb Address=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 What^M > > =C2=A071 -1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 shlib events=C2=A0=C2=A0 keep= n=C2=A0=C2=A0 0x00007ffff7fd2fd1 > > inf 1^M > > =C2=A072 -1.1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 y=C2=A0=C2=A0 0x00007ffff7fd2fd1 > > inf 1^M > > =C2=A073 (gdb) FAIL: gdb.base/clear_non_user_bp.exp: maint info > > breakpoint -1 error > >=20 > > Simon >=20 > Sorry for the noise, I didn't see that Tom had already reported that > failure. >=20 > Simon Hi Simon, Any feedback is welcome. I reproduced the issue on Ubuntu 20.04 you reported to me. Thanks a lot. :) Enze