From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn2185.outbound.protection.outlook.com [40.92.63.185]) by sourceware.org (Postfix) with ESMTPS id 923EC385840C for ; Fri, 28 Jan 2022 13:41:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 923EC385840C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iLNokTlleq6Jvy8dwaqeHWdsKSTW8IyccDnbKVeIMeUpUnCwptMwcr1OZpTKlPLW4UCfodJClCsDMh43ezJCtln2YU+0e2aUUcMCR7hq4Y1YV2YD7tIbhumUNwc2UT3WvrCpT5VDP6feAyyl74FUBS2b7Ae9LcvgH3KJE0MRq8H9woMJC3WiiYhnuAGiDOeIxL4CDP8JjQRHDJij5ZWC9Y0trjaYzsQr6NTBHPETVP+dYLDSanEAT6ZWossJx++OTCUh1/nH/vi7oe+bps2fEUM4Uu4YpHPMC+4PZ0S/I8V6sJL1iJzEXkjHKxi6fhMPfY4hgdtv2tQwuCPA6UW6cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=96ou9vYxtn7Rs0VG0AtH8zN8WHamf7rBXVVnsA6n5Ro=; b=bIXbtSgJTq6E9nSjt6khLeVm6t5dpBpzNxIO2SEoSaPl38mGeEyXRqkLUZfvy38JbpyMWW3CEOOQeJoX8pKsMQEx1OHKaHpXWXhThW9pExaf//pMKMwpdk3PNnzgPypTRCG/t1z7fCuWzOc0GIpOFE20Ta1yH8haxXGi8MwVQhOlXGtFLl26H7pH73qfuibv03raMVwgFMdnBnhxjgvEmPJG7XlKPcz3odPiaxwmhgk8lIYrJbWPMTn1Oi9i5HIuBc0E2SOIDdhkgTeReucFX882RkuCgbh3o+6ACxlmQmPr8Njtcbt+CTmmojPSCiQ0d4/1O9w+WR0mbkxJXY/sSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by SYYP282MB1775.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:79::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Fri, 28 Jan 2022 13:41:37 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::ed26:b57c:fb6b:4f4b]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::ed26:b57c:fb6b:4f4b%6]) with mapi id 15.20.4930.018; Fri, 28 Jan 2022 13:41:37 +0000 From: Enze Li To: gdb-patches@sourceware.org Subject: [PATCH] gdb/build: Fix Wpessimizing-move in clang build Date: Fri, 28 Jan 2022 21:41:16 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [ELDYIme8f57RHoFnbCBG2BooNQ9Vb6wT] X-ClientProxiedBy: HK2PR04CA0052.apcprd04.prod.outlook.com (2603:1096:202:14::20) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: <20220128134116.27757-1-lienze2010@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 951c3527-7f01-47eb-6bbd-08d9e263e7c4 X-MS-TrafficTypeDiagnostic: SYYP282MB1775:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mEdy7zjNBoHeimfqu62kXLG3eCj+dXyuZaCG9q1LLVvHcrTumNSe2M9p1I0T9Pm9JFOTeTkJ4aOHaO47bJDRXwWAKnA6UbLh7+BKZT9+YBIIG73nV/g6Umy4eTY3qyb2RhWkKq89YxJSOUZuPeAq8wIuZm/6K+BWhBc0rfsYXLzT/01JySB7/osQQg2zZloikOAkE1Vt5Avjj9sQzGWcAdCVoiESLzTt7ZvF7+WrPXWZMHhr6RLbD0JayLUZ30D+z2SyX4Vz9Nx1o497o8ISALPPlkn3+nn9A4sC5Ca098ALpDUN3Or8yKWKqfZ1yG9U52hojme79H5IjDvapI1P4XrWay7BBNUWjgc87KjtPlZQpok272x4wXqQbYgdtENbN6o/6klggSCeAH4H1txFEJqhanh9h8sAczNSVt1BNnF4x+B7nogDezvzNH60huZM5eNH4BahpSnSxBeZ3gTf4BvIeRX/hhNcVrbcZAHafDQohYznrVGsmS7MF+dIYp8S5HTpGss9rj9Opr+3GMF1LAO1aXYzy0Q7MLizgofoGsFHJfs4cSQctYnrLCLGUN7/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YCPoHYGt4RGn6lkfeHtk8neIj7VjX7opuKhNA7bQa2BY/mNX4K3C7+rFtGKd?= =?us-ascii?Q?BzWPsDk2PPMUMsBu6yaikf2zoLiH94jQ1fNrj7qEwusZkQjeGy+fvUUdOe9I?= =?us-ascii?Q?PbhqPFNvD8GWS/+Ke0xM6vAuFxkjAaBCaTVxCyea7WC4zrOi+GePQQ/iu2GZ?= =?us-ascii?Q?oEfWsTEU6YfnWfTxjYFfPFbjDiSD+bVbWgYacoZhJ7ZkoFMykP16Nv5otT2l?= =?us-ascii?Q?c4gpGSFfdNr3jxXOQz3ivBgZnya565x+Y0YKEYe4jL6HWAvlCsKxKRWsEQfv?= =?us-ascii?Q?eYUia2D0w7dSM6UEHJ37SY5GDddwti8tSUunrSKuHGW6JHNEhL3yFwAZR+OJ?= =?us-ascii?Q?ueGagwp1FdAdGOn4B3YLaAqYg1OcKN98ZHTv9VLdUWgX5ueBwU3Y1OggQAy7?= =?us-ascii?Q?5hbiMGgETn0b1P9IfwUw9nCm/jPSmzjJToOFfElXR5jRhHxLyIx3VB6Vknnq?= =?us-ascii?Q?WhYyGirE33f/sc4X5XD+zHPikZOv1arqVCWoY5tdz9+2uFvBknG0PS5ZyOHl?= =?us-ascii?Q?lmjjhTPDZMEP0HdIx8XcRj8gCMCI0Rj0W2a+QvRI5oTuDZdIE+2CW/9ahJFt?= =?us-ascii?Q?rmZtpdumCYqYa35w5M5RDLYpisRmESmWetb3pJTyNxIx7aCAIuuNYfZC4jJ2?= =?us-ascii?Q?a2X/axTP95aa3UMHK33wEv/x7RrF1yiZ89je9VecgdsFcA/iogE1ljNuySyh?= =?us-ascii?Q?HOt2A+gh5rzyZPBSJWOL5kpiAVovS3U+/kWbGyWBo0sCMchLDvxMvSDkYBfa?= =?us-ascii?Q?gJwJ8kv0h+dtF5VGBOi2CCQc80zf7ySjeg8FgTmzutAu/mHCoDuXFMBNrkpc?= =?us-ascii?Q?094xXp6uCX5M/BKn5KzA873THXQ21K4rWItZUPJ0E32y4aOtlL2v2a0Eucjz?= =?us-ascii?Q?srajewppvZzNJujDnkqNaMQVjl0XBbB6yARrjV9fMlrG36U0hnEiqW4gtbNw?= =?us-ascii?Q?K8efmsDtzuEAF7nlVXK1/Q=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 951c3527-7f01-47eb-6bbd-08d9e263e7c4 X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 13:41:36.9872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYYP282MB1775 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 13:41:43 -0000 When building with clang, I run into an error: ... tui/tui-disasm.c:138:25: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] tal.addr_string = std::move (gdb_dis_out.release ()); ^ tui/tui-disasm.c:138:25: note: remove std::move call here tal.addr_string = std::move (gdb_dis_out.release ()); ^~~~~~~~~~~ ~ ... The error above is caused by the recent commit 5d10a2041eb8 ("gdb: add string_file::release method"). Fix this by removing std::move. Build on x86_64-linux with clang 13.0.0. --- gdb/tui/tui-disasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 445503a5af9..70f7429d32b 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -135,7 +135,7 @@ tui_disassemble (struct gdbarch *gdbarch, /* And capture the address the instruction is at. */ tal.addr = orig_pc; print_address (gdbarch, orig_pc, &gdb_dis_out); - tal.addr_string = std::move (gdb_dis_out.release ()); + tal.addr_string = gdb_dis_out.release (); if (addr_size != nullptr) { -- 2.34.1