From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn2182.outbound.protection.outlook.com [40.92.63.182]) by sourceware.org (Postfix) with ESMTPS id 1B58C385840C for ; Fri, 28 Jan 2022 14:34:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B58C385840C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ihTuEEDqKARG6PVSg4gwYV0pNfzCKzvoD/QwcFMPWMw0oRos0gimUXP1FbR/6eZ7qosMJfxTH+TsB0V8oW56llY5BzoVzH5VOZ+s0m8S9+PvVy7D6yabOjpHuKsc7UCz+k/y+h01pSUocOptIURnXkJIb1Dgvt4U4wnubymiwewQuPy/FANXihibeA7Xvve+moSGNxNaFtXjvIucrcPfWKAJp8+7WBdtxAAJdUOY6Hk+N52tCCWpFnleCk/wONfYflKJGx/0JR43QEyqYUwjA00jcflODYTC3542wAoVKekDj3NO53OxUEwmb1L2JaNQ4gjdlFU+uo3jeHDjFd5Vqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F81/FVKEsDBtJ6OqM2nvyAdb9AoRaOuRMw4zynYeZ78=; b=Q33lUeVG/hUnWRWqMGKhZ7/AHrjOv+gO7VILl1JAEsTGF2NCGl2BsPez+B154dvqUeesFTDTtMLOBIEOO7UJH/uEwLDV/HtFEKDFB/wyaNh4EKyXWvc62nuOmfdqoizaAKakXrxIft8i4vPOXj0+NFnCacGvcK2CH1pK6t7sTMz1nzvaSsbsog13WF6ixH1Xw/t7vXlOwMWjwiGVExdaXQNxH5XfO+Y7n3qHSQQFarBmTYz/fNv6hN9NMqYB1DfKj/e466+EqCd955sKftitDt6hu3qm+gz7ECO5FL7hUi76KIFBtnNiBclm7A+gH3mmPbfYY5RP65zsj1tV8Aatjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by ME4P282MB0710.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:91::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Fri, 28 Jan 2022 14:33:55 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::ed26:b57c:fb6b:4f4b]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::ed26:b57c:fb6b:4f4b%6]) with mapi id 15.20.4930.018; Fri, 28 Jan 2022 14:33:55 +0000 Message-ID: Subject: Re: [PATCH] gdb/build: Fix Wpessimizing-move in clang build From: Enze Li To: Simon Marchi , gdb-patches@sourceware.org Date: Fri, 28 Jan 2022 22:33:49 +0800 In-Reply-To: <4aa938bd-1d99-b6fe-d3d7-c1de42057d07@polymtl.ca> References: <4aa938bd-1d99-b6fe-d3d7-c1de42057d07@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 Content-Transfer-Encoding: 8bit X-TMN: [gwj5BNHbgctzS/TcpjotgYxpv/Ca8Wz3] X-ClientProxiedBy: HK2PR04CA0059.apcprd04.prod.outlook.com (2603:1096:202:14::27) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: <73b19109eddd590db852df0082152b673ad5e4a8.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 21176203-c7e3-4da7-fff4-08d9e26b3695 X-MS-TrafficTypeDiagnostic: ME4P282MB0710:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1z9FXyh9kyHiduP7smixpwkMfnCqSqccgbd195K7VuxqTQxE+Vt3UUYUHzk3ZfIaJd3vKaXY5e6bw+TKbtpNPKqB22jhzDek9B0rkOgehXrUtnbszye1AWnuqF3PCyEt2qToFuXZNrw0gMG2JvsMZyD3ZKH3qfuD+V0MEZ9R87wzYzQlcqpE2tEV9ipWc2qeTz+mvaXcD6D0knYvXiCchace/l1kVa8ts3sCCGHHPWzTDJ9iIZEk1OiucgL9MqVjvUBhQn4IrzxL7UaPBGA/6O+i9srTYXuA9YIx9z5QwMh6X6xOvsb2k/gamvVMJ91AKcWvMDwQECgGSD3YUhscffiky1yGTn2QGjdFi0d+kC90UTLairVP9fXW9K5YdSO2JJ3upLwaV2f8x7PeHv4Tzm94pXgh3FTqMchdBehzqT4BTtx2V+He6f7MJFgaDsjWRfWyC5lxhLb6DDakw1W52UBH54iLSFR5llihCScuzxFMn+fwamo10gMivSUjrt6PMz6DZUEjIBFKARBZZGlZH28ebFqTED8ciI10i9OtU/LyUwsjtgj2zQQY36grHKQW X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlA5bzFtVW9WMFM1ZXk3YmhJWEs3alM3d2VDeElIR1BES0UzanE5NjFEWHNp?= =?utf-8?B?N3RXb3BpYkdQaGRjNkVXR3lkcGhMWFoxOTRBMVVBY2RHVUduNVJaTHlFNnho?= =?utf-8?B?aHlDL0lleTlFM3N3RDRTVzBPb1RWN1ZrSHNSWC9ueThXV3FmY1VpRmkvRVBy?= =?utf-8?B?eklnMzFiaEtyTDBMYjljUDA0YnhVR25DbFFnajllbUwxZkM3SWJ5a3p1SFZK?= =?utf-8?B?N0pldzg3RWlLeVNNTzhxbEFoa0lkUUZWNk5NaXVQNmU2S3BOKzYrTTJ2bk5t?= =?utf-8?B?TjRyMHFVdm94SFBDdFZWUDlWdEFqaXNYamlrWjk1dzF4K1lyYnhGakY0R2xw?= =?utf-8?B?M3dicWRpQksvblArUG1tVFN5QXNIMnZSVFpYUzBBbG9hNzV2dmw4TS94bWlB?= =?utf-8?B?ZFhwZGlZUmNmcWExeGppZjg5MEdlZE9YNFpGM29hMEwrak5nMXZUU1k0cjda?= =?utf-8?B?blZrMmJPRE43TjRRSUUxVmlrbGk2b0cyaXpBOWY4TzhWVW92c3JoS2YrMXBj?= =?utf-8?B?OWk4bkgvcktwVmZRNlNCczJkQ2Q4dlowb0phZEo5bk5UT0VLSGRLRWxuMmh0?= =?utf-8?B?SnE2S0pySnIxNmpsTWxNaGR4Nlp6OUJkTkYzcU5zb1l0b1lad1QrcWNkcFVD?= =?utf-8?B?Q050T3ROU2QzSkgzcEdIK3VxWDFlOHoxOGxTbkJ3ajVqS25hYVhDUEU2RzJ0?= =?utf-8?B?Rmwxa2lmL1NUNG9uc2x2cktaWHNDSzYweDNaWDRpL1JLempHWllyeDR0TmNv?= =?utf-8?B?RDUvSTd1MmRpSGFockVqS1BISXU1M3g5Sml3YUhjZC9tcGJHSUcrRHBweUZj?= =?utf-8?B?YzgrM0lBSXpSWUNGVFNVdlJYYmNaRG5RRmxzU2NiM3hFMkpTYjdNL0xmdVk1?= =?utf-8?B?RlVjYU4vdkdQeDRCeVpFeXFxb0l6QUNDVGpML1RTTDUyQ1ovazhBR2hINXJW?= =?utf-8?B?d1JvU2o4ek9uOEp4VWJXbTgwS2FxM052MXJFNDBoOTE1Qk5BSWFTOS9LV0hF?= =?utf-8?B?K1F0T214ZEhmd0FZVk52TVc5ekFPYmlLQkhwS2VUZGttNGtZQWZHdjNGVmtJ?= =?utf-8?B?bUNJZzdxUU5yMUluYlpaTExqd1pVdHhKdWlyMlNZUlpmTWp1T0lhK1AwZGxm?= =?utf-8?B?TmM4S1IwT3pRd2drZ2U0WTBSOURnYlVuakxZZzE0aU9ZUTNFNEtIc0NQbVBX?= =?utf-8?B?aVJ0VmFpTzJuNU1jYk43SEFTOEZWQ0d4TU0rWUJLYnk0bnpXd2RJQWlGcmlG?= =?utf-8?B?QkM3R2orYXpqeWlqUE1JMUZQZGhSQlFXa0YzbDBxYmkvem1IUT09?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 21176203-c7e3-4da7-fff4-08d9e26b3695 X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 14:33:55.5595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME4P282MB0710 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 14:34:01 -0000 On Fri, 2022-01-28 at 09:25 -0500, Simon Marchi wrote: > > > On 2022-01-28 08:41, Enze Li via Gdb-patches wrote: > > When building with clang, I run into an error: > > > > ... > > tui/tui-disasm.c:138:25: error: moving a temporary object prevents > > copy > > elision [-Werror,-Wpessimizing-move] > >       tal.addr_string = std::move (gdb_dis_out.release ()); > >                         ^ > > tui/tui-disasm.c:138:25: note: remove std::move call here > >       tal.addr_string = std::move (gdb_dis_out.release ()); > >                         ^~~~~~~~~~~                      ~ > > ... > > > > The error above is caused by the recent commit 5d10a2041eb8 ("gdb: > > add > > string_file::release method"). > > > > Fix this by removing std::move. > > > > Build on x86_64-linux with clang 13.0.0. > > --- > >  gdb/tui/tui-disasm.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c > > index 445503a5af9..70f7429d32b 100644 > > --- a/gdb/tui/tui-disasm.c > > +++ b/gdb/tui/tui-disasm.c > > @@ -135,7 +135,7 @@ tui_disassemble (struct gdbarch *gdbarch, > >        /* And capture the address the instruction is at.  */ > >        tal.addr = orig_pc; > >        print_address (gdbarch, orig_pc, &gdb_dis_out); > > -      tal.addr_string = std::move (gdb_dis_out.release ()); > > +      tal.addr_string = gdb_dis_out.release (); > >   > >        if (addr_size != nullptr) > >         { > > Oh, thanks!  In fact, this is the spot that did prompt me to add this > release method, so it's a silly oversight on my part to not remove > the > std::move.  Thanks patch is ok.  Do you have push access? Yes. Should I push it now?