From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn2185.outbound.protection.outlook.com [40.92.62.185]) by sourceware.org (Postfix) with ESMTPS id C48663858031 for ; Tue, 23 Nov 2021 13:22:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C48663858031 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UAR9Hucek93+KPvgAQNLMqXzOrlte7n6DtvkLL1NTMbBceoxg+doENoBfNCMZyMSLUrbJ7q6JhXjs1kyO1xOkGWTa/97G1amDy+SEstVRJU9DL3O6UOZTiWpWj3cS81fs1H++avfPEvvehtrrDZxuGoQiz0UwD74PuvVy6LD5AV5JNKCeRIs6dPWCEon2ePR+eGthXUbPfle/L/xPJ6+08fKevece+LuKnRl6sdCVZ8BoQ3WSyREJBA9PYUsjiNPiGMs+cFCaYfuRPj7zOs8WsQabpUv+mkXA4vXNN9fnsnrINKpNV1EQ4H7mKY5unewRb8beoJJSFYv65zioJqhBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I6MC9Ae+cZgXkjrZ0CHfN6XUvlMqO759uoUC6OT+Pxc=; b=HgdY7LuswgWc+7Fw/ybS23nGE6pFWgUSh6fPasKPNqbMkj5J2WKx06OtjBbz4DhhafMedy5V10M424tjzpnNd7EBf3FTo95Xh0kTqdHTWp/caobtzIRcp7TPlFXXNRipwyxWrBS588JIdr4QTvv1I7Ob3y8PMspB05nqJ2UswJJVDnka3TBxHeGuu0eIRHFN4nmaJok+5GV+ukHHvoQmge6CxDdOGXHRqHoK4e3U3IQKX1I639m2wkAlw5o7IG3H0C0F70BkqRu8uQbJf3rktDL7O/SaraeFw8L6PMBns1L1lNIDnjdJhDMvU9e/G5PwjJ1U5eCrE2/6nBwdf1tQ5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by MEYP282MB2087.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21; Tue, 23 Nov 2021 13:22:23 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::b1d5:bf09:16b0:4b2c]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::b1d5:bf09:16b0:4b2c%7]) with mapi id 15.20.4713.025; Tue, 23 Nov 2021 13:22:23 +0000 Message-ID: Subject: Re: [PATCH] gdb: AC_INIT should be called with package and version arguments From: Enze Li To: Simon Marchi , gdb-patches@sourceware.org, Joel Brobecker Date: Tue, 23 Nov 2021 21:22:17 +0800 In-Reply-To: <6b270217-7410-9ae2-cfeb-a05c158704c2@polymtl.ca> References: <6b270217-7410-9ae2-cfeb-a05c158704c2@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 Content-Transfer-Encoding: 8bit X-TMN: [Nzb9cBozkJVTWXnEbF2Paq1aWvmRk8C+] X-ClientProxiedBy: HK0PR03CA0100.apcprd03.prod.outlook.com (2603:1096:203:b0::16) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: <3b8f2731ed5cc38c2b017faa528d8d4b2b8a6f39.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.3.105] (61.48.211.155) by HK0PR03CA0100.apcprd03.prod.outlook.com (2603:1096:203:b0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Tue, 23 Nov 2021 13:22:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ae7c3b9-dee2-40e9-e2ec-08d9ae8448ee X-MS-TrafficTypeDiagnostic: MEYP282MB2087: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gh41tqyAL4GR/I/ok0GSvSMx7M9HAMrkwQgZfYh3f8eiAhDCqfW+2WYL7xAIcwjVYpSfeqstWcY3wXQKlMdTO/81TM/pANFanB/RqmkUVjqUopQNl3EoVnGe3c9HRNHTVw5jsHEQUGpn+12lLJ/XQnob0rj4smhTw6HtA2Ojpx8k2FARU96ZNfhzcfD6v1INPplboTepVL7cqF0xivxmsclEzwb3squ7+yuxw1WfEJwkRqAJkmnkppLcqdktPp6Qxm1mTfBxdxXvKyjtq9gcKjJzsO1WysDISMfes14YxqOH1rDvTWl/gC/vA/P6BJtmnFOfY47x4MsLnwFs02jHfqe0sCY48D4slqBlz2F8Lkb9OEJgv8iBBU6XaJjGJ1nASWX3CFfAED2ZafQBGZhisv76gYgF6GQMWnk1SdLmbqhi8XVJ4qTsl96dT+b2KBWmUzjMdm9MbfaI7VKI29QltdRG7t6tIpzKAW2dKKKXeca+Aj/8iaoO/bVHFnbFh6NwAIejmIYw/I7YaxLbTFfieLSDckL/8qUsXbF+a4JMojawr+qf7ogL00zT2jf+U2M19jMM1RjngSzbFQxn558WxQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZSihlUIcd4NQT7VlY0OWe723AMNqurXBHOc27D9yCyBp/eeZwt3qOzuPD85cs0qhYrHH54O+B+JAqBchDzDunEFenZf4QGMaNaE+zjCa5r9V5fIjBoQPvffKjfQw1ROjc3GIqdpx5ljnqAc6FxwmHb3eNvOPrG0e04o4mP8UCHFOt/y03U8OujyvP1GXX/jMavMHxaZdC4yvbjDc1KMsNIbzyZUU5Zfc4jGh1rr2vtfT2/6mWGxXDSg0LF5FOHBu6sxBnPZVnZL78nHSLlcN775qeTe9uZnTnyeoL4gruxz2Gae/efGbDsHaMZVhRI7TqQtNzy5w9pi+UW7NpjJldF6P5OaR26pk9nIWwf52ejDBHbNNyO2WkGVCjv10hMkfW1diKppAOjoKyh9u2x57JFZrR6OlbIb4MJBVckPjihjdP8oaE2DikX381Ks7JZZky/57KuoKIXrSKSv7RbjntJlKHGj7keQ5dtQlWEN0QNcDy2yaLOVJJmql8DnDvejjbKAv0NCXuBx08NkcEW6whfiDX4ckuOkWbjkEm2NXF7k7rTiDibDPZkBfrlkNeUZGMny06OJnn9ZSP4uT17xxcWcysFMP5wnZRD67qFTlZ+ChoNxWMohRG4FQk1I5ZlIv8w8ZkZFwRkcsMaupQmbE+5kxCmEDi8A3o4FE8XQp751gXxxdyTmeKpwMcdwX9Fw8dYJbCahsBK0+Y/zUCjdpjQ== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-8dac2.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae7c3b9-dee2-40e9-e2ec-08d9ae8448ee X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 13:22:23.4455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEYP282MB2087 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 13:22:31 -0000 Hi Simon, On Sun, 2021-11-14 at 21:52 -0500, Simon Marchi wrote: > On 2021-11-13 23:09, Enze Li via Gdb-patches wrote: > > This patch adds package and version parameters to AC_INIT and > > regenerates the configure script. > > Just wondering, is there practical reason to change this other than to > "do things right"?  I'm not against it, I would just like to know the > motivation behind it. > When I made this patch, I wasn't thinking too much about it. I just ran into this little snag when I was using the configure script to get the version number. As far as I know, standard GNU software provides this feature, and the package name and version information is defined in the header file, which can be used directly in the project. As you can see, when executing the "./configure --version", we can see the following message. ----------------------------------------------------------------------- configure generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. This configure script is free software; the Free Software Foundation gives unlimited permission to copy, distribute and modify it. ----------------------------------------------------------------------- But what we expect is something like this. ----------------------------------------------------------------------- gdb configure 12.0.50 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. This configure script is free software; the Free Software Foundation gives unlimited permission to copy, distribute and modify it. ----------------------------------------------------------------------- In fact, this is not a serious problem, but I think we should fix it and make it consistent with other GNU software. > > diff --git a/gdb/version.m4 b/gdb/version.m4 > > new file mode 100644 > > index 00000000000..2fa57f680ef > > --- /dev/null > > +++ b/gdb/version.m4 > > @@ -0,0 +1 @@ > > +m4_define([GDB_VERSION], [12.0.50]) > > > > We already have the version number in gdb/version.in.  I don't know > if > we want to hardcode it at two places.  At least, this should be > coordinated with Joel, responsible for the release process including > bumping the version number. > > Simon > I really didn't think about the release process thing. Thanks for the heads up. I'll fix this in the next patch. Thanks, Enze