From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn2166.outbound.protection.outlook.com [40.92.62.166]) by sourceware.org (Postfix) with ESMTPS id 72A1C385F026 for ; Fri, 28 Jan 2022 15:08:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 72A1C385F026 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N74EYNoHgoD/QqNaEk8b2CO2RueiFeLpEc9ijOTVsmFeft9u9lS/9iKpquum8sl8iE+4Qx0WRgnLB2Vm15TgDRgCVoKF2JEdF5LrRtqwna477WUsjUekHl2ZNeCXFgbWyVTybTFUd7Ju8lk3oosFmbmwxrXGmOb78VVLm1/yZNoc2xfH9TszUg2X4PxB3J6Ffo+WVTycLcyUOihi+FJqAVRRwMRvoWRjIgA53f+QyuPT3A+UfN6SLMDP7/am+WOUGFIjJGf6euKMOfwOub/9C0odMO4AEhwMU5hmB6oyGV1fC+EksuTKehb3iUJHfIp7Ue64Aa8eBlbHS3p7bTqm4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=73ysIu6k8+Bk6AHqjeUnvclXGXdt7D0Ici0kAXFyDnA=; b=SUGunLlC8X2SJT6iYaKwLcmGMLAyYzViC3cLbXLW/bGOP+fTsctsi+fJqAvkX/glJCj26LuDpcuI5jTeDI592gc9DWfVwRQvzHXxe0Abk0CC/c4c2NJidw8wRJf0Pm50H4lW0Qcaf2K+oNH2Y75iHgzuvPeB4XCeC+9AU464T9AqtQ7skq95lrEpQ5Fp0Gl/P0I/ZOIzOMN/62YE3j7jCwQ5afXbxMSh40nsSCTqUEcclJ6QiX2IYm5lmrjtQodM0kpdg1oGRBGpzyprGJluZqZC4N62faS91XCyu8yrxzldd5CsPnVraKsZ/EkS+4onqwWFZi8myIZIJ8Vm94GKug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by SYCP282MB0606.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:90::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Fri, 28 Jan 2022 15:08:28 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::ed26:b57c:fb6b:4f4b]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::ed26:b57c:fb6b:4f4b%6]) with mapi id 15.20.4930.018; Fri, 28 Jan 2022 15:08:28 +0000 Message-ID: Subject: Re: [PATCH] gdb/build: Fix Wpessimizing-move in clang build From: Enze Li To: Simon Marchi , gdb-patches@sourceware.org Date: Fri, 28 Jan 2022 23:08:23 +0800 In-Reply-To: <6e39e3c0-93e4-de6e-6cd4-38450a2ede80@polymtl.ca> References: <4aa938bd-1d99-b6fe-d3d7-c1de42057d07@polymtl.ca> <6e39e3c0-93e4-de6e-6cd4-38450a2ede80@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 Content-Transfer-Encoding: 8bit X-TMN: [GsWkWGX71EN4iBECh25VnonrvfBBIysM] X-ClientProxiedBy: HK2PR0302CA0020.apcprd03.prod.outlook.com (2603:1096:202::30) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: <587673aa5642743ebc5e015bacf88560d05876ec.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67cce9bd-4fbf-4587-afd7-08d9e2700a59 X-MS-TrafficTypeDiagnostic: SYCP282MB0606:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +4hGa0CmqDHRwiEw1taR+Y11fVdX1coPtjMoIcwIESJlVhErqWbxYRrk6uios2e/T/ryU2KnZDHQKWl9lY3h4ecc5V4cFaoWe3of9Kq9tqCxEU0M7k9H13IDYZp5s7dPtVegl3m0VRJk6Kpk6VJzUN5c37PSV+TfUUv1BECSUbK9n6k7glhLJMG+F4rdVsRJwolHxGAYOwjktiQBbB1aDww5N090niVkxH12PRdGTDZiFDWadouRGbjQAoDxzaP0wvVPGThXfN1sxArgxd2FxXBL3NjD+J7r0ljEoYYnlYGvPe+ORO47/TCeMujpVS2jEZrR8Ic6u+xrkjrOhxm52aKtpKtSjvsrFFDviB6UbGpOylx3Kv0Ea++fEjkWmHdiYnUFuPqWbZhybzUt6Sr1hCtWJ6hjLuWVWF31idKRArC3YCLzKQxE2CRpjBYywmd38Thif9aMfcMcOH1pRDIfQqx+XLE4IGLkSYiSzgdwz17mxJGEQSoXlUMrQJvYWgR1wAlhANRiph7VmrF162qLShJESL1P8Akba1y79KL7kxHYVpNBDKuSFLKSmmQw6rOo X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmJPV1N0WXh6N0N6UVdQRzUyWXN2eUJrVzFoVzh1bTd0azJETnFQV25xNHFH?= =?utf-8?B?WXJ2anJiVThtMVNnckJleU5TVVRWY01Jbk0zNXZWUHphTFpIdXpjNHJnUkIr?= =?utf-8?B?c2daeHVmbUhjVkJVSnNpQXJOZEQzaVlTVDFlTEJza0pmbTV6NWJRbWg5VVhQ?= =?utf-8?B?Mlp3cVRkeTZqTTJPaHYrcWUyTEJPNzYwWjZQY2YxTUJvRjVaUjNjSlRndHFC?= =?utf-8?B?Qm5hbzRxNzNaQllac2hZMCtSekw4UmJtUCtzbjZrdU52U3R3UmE2OThJVkM4?= =?utf-8?B?WWVaemsyODhWVTN1S2V3aFZURW9rV00rdUtXd0Y1ZktaaWRoSUEzdjl3U3I2?= =?utf-8?B?Sm5uK01LZTJMOWJ0bGpIRkNCMHE0UXVSdlVXZmRzcnBZbExzNFJsWldUYy9h?= =?utf-8?B?dVptcXZZSDh5RGV3NTZ6eUtMR0Z3UDViZXVwdGlYU1doVGI1b0FTRncwa0F1?= =?utf-8?B?U1pQd1RLbnYwMW4xanJ4SEEzbkZHaGE3Y1lvWUE4ZVh1TFRsYzVZdysvQmFj?= =?utf-8?B?RHQwLzJuNVJiUS9vRGpBMHQzTXpaODltelVRR2FINjM2ell0MjJEeEppTDgv?= =?utf-8?B?T0xWZ3RrS2pLb3BxbnpoMTdEOTgzaXpMbEJXMGpPSDFoQ1VlWXhFK0krVU9C?= =?utf-8?B?ZDQrZ09IeG9CT3NJK20zelhiYS9ZRElRUVFKd0FiSTFGRG9GeUNiRlZuMmF2?= =?utf-8?B?cjFBZ1dZZmVDR0ZQTkhZK1k1bDFLUzlNc1VXZ1V0VDk0cFZDRWszZGJyU3N5?= =?utf-8?B?R1F0ZnArVDFUeTJjUHQyYnJxcDgzZnJBV1lPOTR1Mmd0eWV5cTFpUnpPNENM?= =?utf-8?B?R2o4Si9Yeks3WlhybUErWDQrK0pCc1BzNURCcmtTNjBSWmRjWHR4NXI0bXlH?= =?utf-8?B?UTNHbm8zUmlaeWp2VEJReTJJbFZNMGppVTdDYVRxZmhYVTVVWTlCMTduRHNE?= =?utf-8?B?eHMySHFaT3FTM1piZXlTRHViZk1xRkVOMGR2bEs5N1Z5RDFTYWl2eG5OTHBs?= =?utf-8?B?S215WlAyRlM5SzU1clBwdEVJckxGYlBwY0FNR3hPRGh0UzRjQVh0TlhUSCty?= =?utf-8?B?S0k4d1krNmNHcE1XdEFiTTFkL2xubGZCOVhzWkNWajFDb0FVVHNLMWVkS3BB?= =?utf-8?B?K0Y2bm9uMWkxTUI3R1ZQZzJtWGNxVWdmTFN1UTlKeGxKWGk4dDZkbkxoMThR?= =?utf-8?B?bVBaYTJjRm9NWXg5NVI5dXBXWGgweVdwZEtLTS9KZFloQ2tiUy8yWTlVTEVl?= =?utf-8?B?REVQMEtmc0F6UWh4ZmtuZFRBQlhZaWluSEp5THdraWo0QTRmZz09?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 67cce9bd-4fbf-4587-afd7-08d9e2700a59 X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 15:08:28.8437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYCP282MB0606 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 15:08:37 -0000 On Fri, 2022-01-28 at 09:58 -0500, Simon Marchi wrote: > > > On 2022-01-28 09:33, Enze Li wrote: > > On Fri, 2022-01-28 at 09:25 -0500, Simon Marchi wrote: > > > > > > > > > On 2022-01-28 08:41, Enze Li via Gdb-patches wrote: > > > > When building with clang, I run into an error: > > > > > > > > ... > > > > tui/tui-disasm.c:138:25: error: moving a temporary object > > > > prevents > > > > copy > > > > elision [-Werror,-Wpessimizing-move] > > > >       tal.addr_string = std::move (gdb_dis_out.release ()); > > > >                         ^ > > > > tui/tui-disasm.c:138:25: note: remove std::move call here > > > >       tal.addr_string = std::move (gdb_dis_out.release ()); > > > >                         ^~~~~~~~~~~                      ~ > > > > ... > > > > > > > > The error above is caused by the recent commit 5d10a2041eb8 > > > > ("gdb: > > > > add > > > > string_file::release method"). > > > > > > > > Fix this by removing std::move. > > > > > > > > Build on x86_64-linux with clang 13.0.0. > > > > --- > > > >  gdb/tui/tui-disasm.c | 2 +- > > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c > > > > index 445503a5af9..70f7429d32b 100644 > > > > --- a/gdb/tui/tui-disasm.c > > > > +++ b/gdb/tui/tui-disasm.c > > > > @@ -135,7 +135,7 @@ tui_disassemble (struct gdbarch *gdbarch, > > > >        /* And capture the address the instruction is at.  */ > > > >        tal.addr = orig_pc; > > > >        print_address (gdbarch, orig_pc, &gdb_dis_out); > > > > -      tal.addr_string = std::move (gdb_dis_out.release ()); > > > > +      tal.addr_string = gdb_dis_out.release (); > > > >   > > > >        if (addr_size != nullptr) > > > >         { > > > > > > Oh, thanks!  In fact, this is the spot that did prompt me to add > > > this > > > release method, so it's a silly oversight on my part to not > > > remove > > > the > > > std::move.  Thanks patch is ok.  Do you have push access? > > > > Yes.  Should I push it now? > > Yes, please go ahead. > > Simon Okay, pushed. Cheers! Enze