From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn2181.outbound.protection.outlook.com [40.92.63.181]) by sourceware.org (Postfix) with ESMTPS id 242FE38133E6 for ; Tue, 7 Jun 2022 13:44:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 242FE38133E6 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQGJNSMbSlcQ1l7mAmRafvQWrP1oqIgBigWDw1K4BMBsTjj9pxERe1LelyJjiCfv+8tyzQYjWzACyv4FHcY6ZQZKyTdGVFlwwEfauxkjPbal3U5LaQLj53ew/0epzrDdYwP/Ug25EDWrP7zNotA9DoQDV0C9bsLQcIMELtWENDUv5v8EHZvdB74h+KR8Jl/I1ecxThmgDYEEsgZBuefsE7aqLSv5Z+7L6aFXZnSXlRlTGrwGHR+TKmKutSVWA7PqBQIgVJiW9VFaRfT9A/QXTyruHHyERb2S+3Gf/T1Nfo7PY65byxWJLHes6fu+r/zP+OqZalDyDkBDZN/t8OSSOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RSqEeqim174+qlnkTBh1ehWciyI+UCqt8wqq+k0XXbY=; b=J95b5KRXN5dElZNW0l+86zmS8YpVeBrEIPkj7fPQY0nrDEy7WWKJbknEn4OAcI8DiUGF9uEIxfIYfX1O1wR3NhhaFHrAQluKISVkkeIwzgMV3I40XozbB5e3WZUsnKo5zPQXCPltjAu0IYUMpzaHg8fGzbH4RUsZ5l0qKoyS41VVG0WE9ZW2gcU33Vu6N6w2MENFfss2GiULtMEE0MBq36c1b9alVnRlNnCJrZnT2A7vVeTR/hlgVZz4fldfeR9zqpVFn6k7PRzSrq+YhPoZu8H98qvEkxoeCSfi7DipLye3OkNT55mTcmnaXa7rR5rPJLHP6nntyMlDqcF2JTp0Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) by MEYP282MB2198.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:c2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Tue, 7 Jun 2022 13:44:46 +0000 Received: from MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::91db:2ea8:566:e0a3]) by MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM ([fe80::91db:2ea8:566:e0a3%5]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 13:44:46 +0000 Message-ID: Subject: Re: [PATCH v8 3/3] gdb/python: Export nibbles to python layer From: Enze Li To: Eli Zaretskii Cc: tom@tromey.com, gdb-patches@sourceware.org, pedro@palves.net Date: Tue, 07 Jun 2022 21:44:41 +0800 In-Reply-To: <834k2kp31l.fsf@gnu.org> References: <834k2kp31l.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 X-TMN: [dqhmxIEyTatLhFfDLG0LMznotc601nbv] X-ClientProxiedBy: SI2PR06CA0001.apcprd06.prod.outlook.com (2603:1096:4:186::21) To MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:71::10) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a1ffe8e-5f22-475c-6cf9-08da488be239 X-MS-TrafficTypeDiagnostic: MEYP282MB2198:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5mnLW0+ELpko4ZFNDIwGyJ69XdR13MkiIoOxzXpfMdKF4uCOuJCSZ6I8OiH/nUStkjtCaxbYzgdRGAeL5/k+3Ezx7Qt8NnISK/Vyu9cZNTtikuwyNjuDLEqrzAfVbMmNth8NKuoAZB8NT9h/s6RvZQ6eHuc5aopkpAI4TJZDpD3rWY7KYgy/Y/RN63zVliJTLNUPFKw35O1c2IcFa+/l8UGP1kP6F/CWpMmUk0sK6UIwY3zriIJxEBDjgCdRdWCIlKHsnklTVMo9ZdV8TGhLiO+zmMFLamTZzYT7IzJMG4lWQUhBayBaQClesky5RvU5SEP4/hx2caWPZKjxbWEgDHur4aMAZo24L5Est8ZvXogH9vTYqo6fMHP2JvjESq6FLLQX7qzdloga5BIJPdGUYKy5vddIeNIIsrfd4cqm+YmFfhkDyz0t5W84dngIEHIvJNALEL5wKqjsjjj9MAUOCYTF9AJFNEcz8KZo92ou4HYNE/IPyrguLqUZdQFtcQJdHfaVmLkkfBKQcdMBntPwU1pZC7HM+3IR8u4y0S/KRkJzo/P1zC63rrew/PR+UkI19Mb3GscTrniI3ITgMwliwA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZS9yRCswWkhFSklNaS82K2VyUWwzdFMrVlNneTNnQ2tkYWVJeXAvZnFlNHpp?= =?utf-8?B?QXdDYmNmQmRsM05mdC84TFJLNVVUQWJDVS9Pa29zNEhqN0d2dTZwbnNuMjZv?= =?utf-8?B?Y1hRaEZ4NTZ4anArU0tIYy8vZXllQktPZlNVMU9Ybyt3VGU5TUFkZ252TUJR?= =?utf-8?B?ZU95dFZrWkFzYTM3bHhjZEVkQ2NkQ2V2bXNDcXplTkFBeEE2Uzc0eHdCd01I?= =?utf-8?B?dWJtV0Q4aXcwVzdvYnFNbFNvSjBqUHRXMjNJTjFQTittYnVQSDlhQUV0UTZU?= =?utf-8?B?eU5MY3JHc1cxcEZKYllsYnpCbE9SY0s2dlFaWWlOckp3b2JLM2JRTkVGdit6?= =?utf-8?B?cWJPRkNPSml2cHdvTXJIV0EzOWVFZ3NBWVdDcEFzR1EzNkN6bmdXL25SMFhW?= =?utf-8?B?K3FKUENza2Y5RWxYYkhvV3hDMVp2c3EvempVTDF2OC9pL0dFcGo3UnpVR1Nl?= =?utf-8?B?OVk1bVJSTXloODN3bStNeHE4Rk9zYkRLQXViTVkyb00xUm81NTF5WVhobmM1?= =?utf-8?B?aFBVVWxUd1gxZFpzaHVQZGhMejhvZXJoSTU0NUJsWGpSbVgwRUlmVTIvSmpu?= =?utf-8?B?all6dzBYNXRDaVp3NWR0TkcwbWF2VFNwYmxVQytXOFdRaXArSWhobk9LOFRT?= =?utf-8?B?cFNnZnk4T1JjSzBUck51V3A0b3YxNHpIeWczeE1HNFMvaVFLTzFDLzNVbTJN?= =?utf-8?B?d1hPbTNaK1EyOGcyeWd4aWJWZXRaa1lTczYrN215ZHZicHVvcllnRnI3OVlF?= =?utf-8?B?L3A5RXFwTG15NWJtMTRhR3dXY0RnZm1ud2RBYTRBSFFZRVZuWWY3VnBDb202?= =?utf-8?B?TlFFWjAyaWxZZlFmeVlwc0xvM0ZBbkVMRW5lMC9OdE9TMm1vSE4rclJhUk5l?= =?utf-8?B?d1lscmRiM3EyVGhQSVBRQjRlVmNYeWU4cE1wdWIwWDNQNHNkVXhDLytwQThB?= =?utf-8?B?MUkwUEZycGxKcEQwUVM3alpQWTVwd2NDMDhjN0VrVDM3VUd0d3Q0TjVKQnBm?= =?utf-8?B?MTJYOG92TDUzS3RpY3N4VHBWNmJQV2Y2cGpMYlF3eFVyUGUvM042bWFFVmMy?= =?utf-8?B?cC9CSHJwZVVIU2ZrdlM1Vmo2WGljcFdHMlJ2aVByV1NZd0xBMWVCZGtwUmFw?= =?utf-8?B?alhqRzFsWWdobTBNc29RajNNR1hRSk9QN3g4RkdTZFM4NGZoOFd4TXQ3ZHpw?= =?utf-8?B?MXo3cWhZTUtMUzBSTGVoT3NGS0NlcHdzbVl6UGZVQjZUNjFqUnVaQ0NSVnl3?= =?utf-8?B?a1A1UlkwM2FBeEdCQmhSVUFXZ25lRDZieTdDclNJVVBHVUY5NVhiOG5sYy9H?= =?utf-8?B?TGNsUXk5N2h2RHVlSENReFVhcE9iYTBWUjlEbzFQcTFoVURVN1RMKzV0VUNM?= =?utf-8?B?YVpHd3FmVFE1OVFrOW1ad3JRcEpJQWhhbmpzRW8yRzVZNUlYa1RCWWFMSFF0?= =?utf-8?B?MHl4ZUdLdkloWERKUlZKZmdIK1hHK2hNWGJ5MkdMbnMrdGg0czF4UjRXdzJB?= =?utf-8?B?bkVwdjJNeVdIUzRMTU1pZ3E4NzBIMWxSbllEZDFGd2NqV3JTU2s3SUFuV1ly?= =?utf-8?B?c2wrUHI0ZWpFSkdnVDNWWmpXS2NIRVN4eDZiTFJWREp6U2hkbVdBR2lsT1Fu?= =?utf-8?B?UTJyeFVFZDBwbysxeklVTEM0TkprQVd0eUc1VU1ZRDd2eVBpZWVGM2JrelZV?= =?utf-8?B?TnlrSUdaTjVUMkk0akZFdlI3K3F1NWhQZFZ4OTRBQ2N5akpXNDIyWXMzbEFB?= =?utf-8?B?QUJmcGhIbE1ZWURkaW51aUlqa1BYK3AzVS9NeFpRamNJMEQ0MVA2a1JMM3Zw?= =?utf-8?B?K0dDNnk0OHNJZzNLeEpaamNweGtsU2ZEanFDbFRsayszdlp4bkd2VTNESG81?= =?utf-8?B?OGFra0x6MlRKYkZMLzJWTWxRMjl4U2FUVk45Sndibm1nalU5MDBGa044YW5k?= =?utf-8?Q?P2G6ov1m9+s=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 7a1ffe8e-5f22-475c-6cf9-08da488be239 X-MS-Exchange-CrossTenant-AuthSource: MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 13:44:46.4258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEYP282MB2198 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 13:44:52 -0000 On Sat, 2022-04-23 at 12:22 +0300, Eli Zaretskii via Gdb-patches wrote: > > Date: Sat, 23 Apr 2022 17:16:55 +0800 > > From: Enze Li via Gdb-patches > > Cc: gdb-patches@sourceware.org > >=20 > > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > > index cb5283e03c0..5fd757d4891 100644 > > --- a/gdb/doc/python.texi > > +++ b/gdb/doc/python.texi > > @@ -1094,6 +1094,11 @@ union} in @ref{Print Settings}). > > =C2=A0address, @code{False} if it shouldn't (see @code{set print > > address} in > > =C2=A0@ref{Print Settings}). > > =C2=A0 > > +@item nibbles > > +@code{True} if binary values should be displayed in groups of four > > bits, > > +known as nibbles. @code{False} if it shouldn't (see @code{set > > print > > +nibbles} in @ref{Print Settings}). >=20 > The part in parentheses will produce better output if you use @pxref: >=20 > =C2=A0 @code{False} if it shouldn't (@pxref{Print Settings, set print > nibbles}). >=20 > Also, please leave two spaces between sentences, not one. >=20 > OK with these nits fixed. >=20 > Thanks. Hi Eli, I was looking through my drafts, and I realized I never sent this email. Thanks for your review. I have made the changes locally as you pointed out. Best Regards, Enze