From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-oln040092253052.outbound.protection.outlook.com [40.92.253.52]) by sourceware.org (Postfix) with ESMTPS id 82FF8385703F for ; Sun, 6 Dec 2020 05:53:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 82FF8385703F ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iDGqX7a+A5u0BtfvGkobDByqCpl2PrzPZ1BYmw62A061pkHJIEq9xp8+O/MzzzQDjyQtej/cetv0Rtjm/617Dy5R1+b1jnh5FWt+6iapwN7sSWxEyXF4v9qpTz7HE3I2/dh+GbaZC05R7UnmQ8JfTYGAHKS2Nmt9DdQfOMw6/vLhCv6I6PER8uYoenHczkJgN0FsUGIpn8c4F7mM0fldB7XZDElQ3Iy1K7XvzZseibXy2Q/2QVfwVoF7jyoPdJRMBtJ0mXkrUmxOPVsl6bHk262bb/1Yk8LSPrU2B/oqwl6H4AKszonz8/E3fPesDJ8MGCRmAWh/bpdQCnr5JJYVWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gKEGafMY94jeMMu9r8Z9GAX29ZX90qcQszeFslahjI=; b=mL/tvCvRjT1wk229Ib4h2BDhgbCGMVU/HuLepNicv6d6kw35ZrQbAhuESR3VHe4SFkb/dvdpG0QkySyGEyhNOIUQm8NENaDN0dsnWPKDPvIkKhQ+OO889FCOwOOkwSu6wi7AMDZvV608KW7vj6QcjDQM/feYtNzG0CloD9Gorew0HEzZhLSNELxp5iDgqKlmRbbm0uY4tyPC+r2TLpebWTEIrN+oPLzR2NiYhggbxO97986uRHPI/OQmANspv1dWWT9xmbpUUDiHDgc7JwPnrEMw9hmBMikEHMwZoxEYcBYlhfgF7XHKyl1pZP/TI6OtU4hxj4xJ3IzopHriqs3Y5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from HK2APC01FT018.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::4f) by HK2APC01HT193.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::375) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Sun, 6 Dec 2020 05:53:44 +0000 Received: from MEAPR01MB3672.ausprd01.prod.outlook.com (2a01:111:e400:7ebc::43) by HK2APC01FT018.mail.protection.outlook.com (2a01:111:e400:7ebc::183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Sun, 6 Dec 2020 05:53:44 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:6B47675FB9E06928B5FEC6BE6A43A394A86C72F4A12D14CD83583764DAFFCCD1; UpperCasedChecksum:5A5A66890E27847EBA97144431C926BC88CE328312F36B9E2E10809C8F8BCAC4; SizeAsReceived:8670; Count:48 Received: from MEAPR01MB3672.ausprd01.prod.outlook.com ([fe80::5851:af56:ad62:8ed]) by MEAPR01MB3672.ausprd01.prod.outlook.com ([fe80::5851:af56:ad62:8ed%7]) with mapi id 15.20.3632.021; Sun, 6 Dec 2020 05:53:43 +0000 Subject: Re: [PATCH] gdb:Add new 'print binary-groups' feature To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <837dpyfx3l.fsf@gnu.org> From: Enze Li Message-ID: Date: Sun, 6 Dec 2020 13:53:38 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 In-Reply-To: <837dpyfx3l.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-TMN: [5f6dW3X1tDrOzS4gzsHU0MA4qH6wBBbv] X-ClientProxiedBy: HK2PR02CA0128.apcprd02.prod.outlook.com (2603:1096:202:16::12) To MEAPR01MB3672.ausprd01.prod.outlook.com (2603:10c6:201:3a::15) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from MacBook-Pro.local (61.48.215.208) by HK2PR02CA0128.apcprd02.prod.outlook.com (2603:1096:202:16::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Sun, 6 Dec 2020 05:53:42 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 12b5134f-1d21-4c27-ea8e-08d899ab4a1b X-MS-TrafficTypeDiagnostic: HK2APC01HT193: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L08C+6cyoOtovB4xQYO4Up0/M86rwqQ6EtgnAKOP26EXVn/V+bTVy1MmroCugV/3yISX/nXfaihvniXEsd66VsZ+9bbxYcKWU8b3KLC8ipRN9vwpGJmcgCamM0cRhci6NhEr8GR3yf+bQYfgqC3w5vtngcDF7b5wdpziJlVAoM6ydliXGjn1bO6rvO9jRvBW1WBCuKZ9B6KPSVR3PLsnhA== X-MS-Exchange-AntiSpam-MessageData: nc9Ji1k2t6JW72sDAm6AsgoGY4E/uRDuc0n1TkkMHr7XobMG6R0ipAHRtMfj4E/J4GdzarEl6sFzsjqOOQlkt24vFRaFqEyF7+g+pTktZ/xIHtwpjn0ia89fx3/qAbeN037WCdwLzZQqd7W8WJm6mw== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12b5134f-1d21-4c27-ea8e-08d899ab4a1b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2020 05:53:43.6515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT018.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT193 X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_MUA_MOZILLA, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2020 05:53:53 -0000 On 12/4/20 4:33 AM, Eli Zaretskii wrote: >> Date: Sun, 29 Nov 2020 21:00:05 +0800 >> From: Enze Li via Gdb-patches >> >> Make an introduction of a new print setting that can be set by >> 'set print binary-groups [on|off]'. The default value is OFF, and >> it would be changed by users manually. > Sorry, I missed this. > >> And of course, 'show print binary-groups' is also included in the >> patch. > "Binary-groups" is an unusual name. How about "set print nibbles" > instead? "Nibble" is accepted terminology for a group of 4 bits. Agreed.  "Nibble" is a better choice. Thanks for the review. Enze