RE: [PATCH 1/1] gdb: Enable complete to show members of anonymous classes/structs.

["Willgerodt, Felix" <felix.willgerodt@intel.com>]

> Felix> Not knowing too much about LOC_COMPUTED, I am assuming that this
> is the right
> Felix> symbol class for this case and that we should adjust
> Felix> completion_list_add_fields() for it.
> Felix> But it could very well be that I missed something.  Any comments
> welcome!
> 
> I don't think there's any requirement that 'this' be LOC_COMPUTED.
> 
> LOC_COMPUTED just means that the symbol's address is computed via some
> function call (normally into the DWARF code to handle an exprloc).
> However, nothing says it couldn't be LOC_REGISTER or LOC_ARG or
> something.

Why is the code in completion_list_add_fields() restricted to LOC_TYPEDEF
currently? That is what I don't understand at all, and why I (over-) cautiously
added LOC_COMPUTED in the first place.


> Felix> +  if (sym->aclass () == LOC_TYPEDEF
> Felix> +      || (sym->aclass () == LOC_COMPUTED && t->code () ==
> TYPE_CODE_PTR))
> 
> It seems like this could match many local symbols -- like, nearly any
> local variable that has pointer type.  But, completing on these fields
> is not desirable; instead you only want to examine 'this'.
> 
> Instead you probably want something like what lookup_symbol_aux does:
> 
>   if (is_a_field_of_this != NULL && domain != STRUCT_DOMAIN)
>     {
>       result = lookup_language_this (langdef, block);
> 
>       if (result.symbol)
> 
> That is, use the current language (or in this case perhaps some search
> language, I don't really know) to find the name of 'this', then use it
> if this symbol matches.  Probably this should be done in the caller to
> avoid a lot of repeated calls.

So we need to compare the symbol from lookup_language_this() with the
symbol we are currently looking at? Okay, I will try to find a solution
that is not repeating the call per symbol basis, but per block basis in the caller.
I will try to post a new revision soon, but it might take a bit.

Thanks,
Felix
 
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928