* [PATCH 1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp
@ 2024-05-22 8:14 Felix Willgerodt
2024-05-22 15:24 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Felix Willgerodt @ 2024-05-22 8:14 UTC (permalink / raw)
To: gdb-patches
In a remote testing setup, I saw this error:
~~~
(gdb) FAIL: gdb.base/foll-fork.exp: check_fork_catchpoints: runto: run to main
ERROR: tcl error sourcing gdb/gdb/testsuite/gdb.base/foll-fork.exp.
ERROR: expected boolean value but got ""
while executing
"if { ![check_fork_catchpoints] } {
untested "follow-fork not supported"
return
}"
(file "gdb/gdb/testsuite/gdb.base/foll-fork.exp" line 434)
invoked from within
"source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
invoked from within
"catch "uplevel #0 source $test_file_name""
Remote debugging from host 172.0.1.3, port 37766
Killing process(es): 1171
Quit
~~~
The actual reason for this were some connection problems. Though the
function check_fork_catchpoints shouldn't return an empty string, especially
as it promises to always return 0 or 1. Fix that.
---
gdb/testsuite/gdb.base/foll-fork.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/foll-fork.exp b/gdb/testsuite/gdb.base/foll-fork.exp
index ecf2111d4fd..0d801f004e4 100644
--- a/gdb/testsuite/gdb.base/foll-fork.exp
+++ b/gdb/testsuite/gdb.base/foll-fork.exp
@@ -42,7 +42,7 @@ proc_with_prefix check_fork_catchpoints {} {
global gdb_prompt
if { ![setup] } {
- return
+ return 0
}
# Verify that the system supports "catch fork".
--
2.34.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp
2024-05-22 8:14 [PATCH 1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp Felix Willgerodt
@ 2024-05-22 15:24 ` Tom Tromey
2024-05-23 6:23 ` Willgerodt, Felix
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2024-05-22 15:24 UTC (permalink / raw)
To: Felix Willgerodt; +Cc: gdb-patches
>>>>> "Felix" == Felix Willgerodt <felix.willgerodt@intel.com> writes:
Felix> The actual reason for this were some connection problems. Though the
Felix> function check_fork_catchpoints shouldn't return an empty string, especially
Felix> as it promises to always return 0 or 1. Fix that.
Thank you. This is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp
2024-05-22 15:24 ` Tom Tromey
@ 2024-05-23 6:23 ` Willgerodt, Felix
0 siblings, 0 replies; 3+ messages in thread
From: Willgerodt, Felix @ 2024-05-23 6:23 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
> >>>>> "Felix" == Felix Willgerodt <felix.willgerodt@intel.com> writes:
>
> Felix> The actual reason for this were some connection problems. Though the
> Felix> function check_fork_catchpoints shouldn't return an empty string,
> especially
> Felix> as it promises to always return 0 or 1. Fix that.
>
> Thank you. This is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks, pushed!
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-23 6:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-22 8:14 [PATCH 1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp Felix Willgerodt
2024-05-22 15:24 ` Tom Tromey
2024-05-23 6:23 ` Willgerodt, Felix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).