From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Metzger, Markus T" <markus.t.metzger@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v4 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt.
Date: Tue, 10 May 2022 13:42:52 +0000 [thread overview]
Message-ID: <MN2PR11MB4566A969B5EA43F84948EE978EC99@MN2PR11MB4566.namprd11.prod.outlook.com> (raw)
In-Reply-To: <838rre27y7.fsf@gnu.org>
> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Freitag, 6. Mai 2022 13:54
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: Metzger, Markus T <markus.t.metzger@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH v4 07/10] btrace, gdbserver: Add ptwrite to
> btrace_config_pt.
>
> > Date: Fri, 6 May 2022 13:40:07 +0200
> > From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> >
> > +@item Qbtrace-conf:pt:ptwrite=@var{value}
> > +Control recording of ptwrite packets. This was added for backwards-
> > +compatibility.
>
> Suggest to rephrase the second sentence to remove "was added". The
> manual is supposed to describe the current situation, not the history
> (which becomes less and less relevant as time goes by).
>
> The documentation part is okay with this not fixed.
>
> Thanks.
I fixed it locally to say "This allows for backwards-compatibility".
Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-05-10 13:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 11:40 [PATCH v4 01/10] btrace: Introduce auxiliary instructions Felix Willgerodt
2022-05-06 11:40 ` [PATCH v4 02/10] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2022-05-06 11:46 ` Eli Zaretskii
2022-05-06 11:40 ` [PATCH v4 03/10] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2022-05-06 11:48 ` Eli Zaretskii
2022-05-06 11:40 ` [PATCH v4 04/10] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2022-05-06 11:40 ` [PATCH v4 05/10] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2022-05-06 11:49 ` Eli Zaretskii
2022-05-06 11:40 ` [PATCH v4 06/10] python: Add clear() to gdb.Record Felix Willgerodt
2022-05-06 11:50 ` Eli Zaretskii
2022-05-10 13:42 ` Willgerodt, Felix
2022-05-10 14:04 ` Eli Zaretskii
2022-05-11 8:22 ` Willgerodt, Felix
2022-05-11 11:43 ` Eli Zaretskii
2022-05-06 11:40 ` [PATCH v4 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2022-05-06 11:53 ` Eli Zaretskii
2022-05-10 13:42 ` Willgerodt, Felix [this message]
2022-05-06 11:40 ` [PATCH v4 08/10] btrace, linux: Enable ptwrite packets Felix Willgerodt
2022-05-06 11:40 ` [PATCH v4 09/10] btrace, python: Enable ptwrite listener registration Felix Willgerodt
2022-05-06 11:40 ` [PATCH v4 10/10] btrace: Extend ptwrite event decoding Felix Willgerodt
2022-05-06 12:04 ` Eli Zaretskii
2022-05-10 13:43 ` Willgerodt, Felix
2022-05-10 14:11 ` Eli Zaretskii
2022-05-11 8:19 ` Willgerodt, Felix
2022-05-06 11:47 ` [PATCH v4 01/10] btrace: Introduce auxiliary instructions Eli Zaretskii
2022-05-10 13:42 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4566A969B5EA43F84948EE978EC99@MN2PR11MB4566.namprd11.prod.outlook.com \
--to=felix.willgerodt@intel.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).