RE: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations

["Willgerodt, Felix" <felix.willgerodt@intel.com>]

> -----Original Message-----
> From: Andrew Burgess <aburgess@redhat.com>
> Sent: Freitag, 26. April 2024 17:02
> To: gdb-patches@sourceware.org
> Cc: Andrew Burgess <aburgess@redhat.com>; Willgerodt, Felix
> <felix.willgerodt@intel.com>; John Baldwin <jhb@FreeBSD.org>
> Subject: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations
> 
> Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no
> longer needed.  These are:
> 
>   1. 'init_registers_amd64_linux' - the comment claims this function
>   is auto generated, but I don't believe that this is still the case.
>   Also the function is not used in this file,
> 
>   2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any
>   more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but
>   neither are used in this file, so lets remove the declaration.
> 
> The amd64 in-process-agent still builds fine after this commit.
> 
> There should be no user visible changes after this commit.
> ---
>  gdbserver/linux-amd64-ipa.cc | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc
> index 13c8a5bb360..a6346750f49 100644
> --- a/gdbserver/linux-amd64-ipa.cc
> +++ b/gdbserver/linux-amd64-ipa.cc
> @@ -23,10 +23,6 @@
>  #include "linux-x86-tdesc.h"
>  #include "gdbsupport/x86-xstate.h"
> 
> -/* Defined in auto-generated file amd64-linux.c.  */
> -void init_registers_amd64_linux (void);
> -extern const struct target_desc *tdesc_amd64_linux;
> -
>  /* fast tracepoints collect registers.  */
> 
>  #define FT_CR_RIP 0
> --
> 2.25.4

Approved-By: Felix Willgerodt <felix.willgerodt@intel.com>

Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928