public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
To: Tom Tromey <tom@tromey.com>,
	"Willgerodt, Felix via Gdb-patches" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/1] gdbserver, linux-low: add a couple of nullptr assertions.
Date: Wed, 30 Aug 2023 06:40:13 +0000	[thread overview]
Message-ID: <MN2PR11MB4566EE544209907B4739C30B8EE6A@MN2PR11MB4566.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87ledtsvng.fsf@tromey.com>

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Dienstag, 29. August 2023 17:42
> To: Willgerodt, Felix via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
> Subject: Re: [PATCH 1/1] gdbserver, linux-low: add a couple of nullptr assertions.
> 
> >>>>> Willgerodt, Felix via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> > This safeguards a couple of places that may theoretically return NULL but
> > must not in this specific context.  These were found by a static analysis tool.
> 
> Seems fine to me.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, I just pushed this.

Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

      reply	other threads:[~2023-08-30  6:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29 13:48 Willgerodt, Felix
2023-08-29 15:41 ` Tom Tromey
2023-08-30  6:40   ` Willgerodt, Felix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4566EE544209907B4739C30B8EE6A@MN2PR11MB4566.namprd11.prod.outlook.com \
    --to=felix.willgerodt@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).