From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2048.outbound.protection.outlook.com [40.107.92.48]) by sourceware.org (Postfix) with ESMTPS id 8A640385781B for ; Sat, 3 Apr 2021 06:50:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8A640385781B ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfanMm4afQQZ2x+RwUq3jOySJdP4eKetY4nRZRsahmhPg0kwwCbsoL6Smoa6KIa8YOhGjEnFVQJmIbZWQ1AUobp+8udD0JKepDXFfUe2KLSNzRtPMLc52KV6rlcmQj5hz3uJy+f/7VnUt0Tyd8pA7u232+CjFxjWOy44703F73N2O9MuB4dEhYyDubiIk+99fcJPexypoi1cUhCUptffdazrojxeYAuVNa+NW+hXkjQKYx3HqYJxhc6HICCJcMudUnwjhMOqmczEAr9cQFvAVGd+d8fRMgtn0jJpw/VoZHngCdfnWG1slFH996rZ2vK0vrFJEGzb8Z1cknnH8VGn/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wyz0ddD5JHGZQQiHJxGG2iLkVNGNzC4Dv89y54zrnTQ=; b=TK3yoODx9spkKEiA7gDOmLKGHdhSGogYw37Jg34OMIbtVVoXuZoBP5djJsEi6iSAl6tFe14/xPur288TpWMLtEYfQ8aLMHsXlzrTsuGPzuos/DU8HtcAWS+2mpIeetQO/PAXbgQUORWK3c08SKUraxT81MjCFcNjrxIGYLCGnkHROsFiT88vkOKKpYdBN+OCPjV/1qP6GtML9E6V5tapPQITSamo7tgvOsun4qVXiyefe5J7I3UJMPkId1/3x9GHs6tpwyxLj9tQfJ+YR5eaGzxcj4qznCOUvDPcTaiZBkQsbZbG0CfhmPrUHFuMIYd1RGJPgU3N/isI6ucPMKNvAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from MW2PR12MB2474.namprd12.prod.outlook.com (2603:10b6:907:9::13) by MWHPR12MB1552.namprd12.prod.outlook.com (2603:10b6:301:a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.26; Sat, 3 Apr 2021 06:50:25 +0000 Received: from MW2PR12MB2474.namprd12.prod.outlook.com ([fe80::7c27:7292:f19f:28a]) by MW2PR12MB2474.namprd12.prod.outlook.com ([fe80::7c27:7292:f19f:28a%5]) with mapi id 15.20.3999.029; Sat, 3 Apr 2021 06:50:25 +0000 From: "Tomar, Sourabh Singh" To: "Tomar, Sourabh Singh via Gdb-patches" CC: "George, Jini Susan" , "Sharma, Alok Kumar" , "Kumar N, Bhuvanendra" Subject: RE: [PATCH] gdb-Fix-macro-info-lookup-for-binaries-containing-DWARFv5 Thread-Topic: [PATCH] gdb-Fix-macro-info-lookup-for-binaries-containing-DWARFv5 Thread-Index: AdciUnF0km9kg1cCS/qZecphFiZR/gGAxAkg Date: Sat, 3 Apr 2021 06:50:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2021-04-03T06:50:21Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=b23c87c8-c4e3-4cbb-899f-4d072b0e9ead; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 x-originating-ip: [203.81.243.244] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: acfc6989-364f-4927-cbaa-08d8f66cc271 x-ms-traffictypediagnostic: MWHPR12MB1552: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qcP3Jrh1mQ897UVhKki0OVn1ySoIOfzdVswnl8561C4YkfFb7NotOgsj1hpfwZ47UlCxL62aYCKFHZJdbf1XgR+w46mYjrImXu54YaU+AvRN5OUPaTfq07POWaxsgYN75K5dAXqHW/4JWay35JtXeTjfm4GLmbPATN3YqsJr4O7IgoaSmcj13dIT7aOu7SY/TdKUQDiSHmp9FoDTLNhad+LPotoMuaDEXt6Zdi6rYoUcyrZxhyBRy8MeDLg2LPK7RuQrD9G7FlP7UtZMLgiSIWRY6zCYxRkRXhtWEnBICKfhlH4R+37vrvoq/zH4by37dCtp+yXR0vjEJuAaCnhmn8rdQPKXBWeVUFJ3fZnejEJ8V+Ku46osHpQKN7Ih4lfqSc5D0Oi8Dosqm92BwmcZOpKHPb6WfwEQ9w+bM2q/3p/uSjT9ZFQ0RRfTe/EsojNyfcZs38jFDxJHmigDuUb0JWwf+vjfPANq+OegKqBlk5PShu6/V97KRRM2wwbaN0uk1xlyB+nDiYIJLvkRF2ZXBHSqabvk6PJmxYdFKORVwINApEIxebVMz9nqtcXc1CZrJos6u2YFbc6vOsXjdvkRmUctIsd9yG1VsrrfsvBxJAVuuFNbt9SWrdkinViK5X6bCFUJa2PkPmhOtq/dOk5SSoc/VBbVq90OkyH44w82CRbS9hOTutWmjILWwnpXM1PW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2474.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(478600001)(5660300002)(7696005)(53546011)(6506007)(2906002)(83380400001)(4326008)(52536014)(66946007)(66556008)(54906003)(26005)(66476007)(38100700001)(64756008)(66446008)(76116006)(8676002)(71200400001)(6916009)(8936002)(9686003)(316002)(86362001)(55016002)(33656002)(186003)(403724002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Yk/d2SEOgnttIDa+X9JcbmXegNI3VWMy7p9DXjnEuGFOqVz7q16Bydax2JE4?= =?us-ascii?Q?oQXiB5utlqGQcjnPSpEsjEsSdaHzupk+cdbsXNY1fVgiHaZLEwtEkcnieh37?= =?us-ascii?Q?Pqw6EZsuUua88H2h8InegQrDN7+0rfWX1wZl9R5S4xftqctBe7GTpV5pfPGe?= =?us-ascii?Q?/DvN3L+t8qic+o8uJZRDPZdgh1nzxCUCAT/CJZDxCDNwzRSw14FfETm9Ct4r?= =?us-ascii?Q?Fc9f1dCwpJCPif1QPa1h4ZxlUOvkwddjZYuQzVOJQ7InZoqtYOizJD0i0YmN?= =?us-ascii?Q?TbtyisrApG47eLn9FXm/rT1xNja/12o/BkgmIVLcFwfWqCkaYFTf1fmtd7nh?= =?us-ascii?Q?OnDG7a/zxoGM1kN8cthtkfUvncYlG1KQF+ZtiTQxAoNxB/vHo4vvRzA+oPVm?= =?us-ascii?Q?q+YK3H1Z5HlaaNRr8PzV89kGWRzWO7foiN7ZlvTehQKowBGmFnWekiut1GHq?= =?us-ascii?Q?yKNWFaozu8sBpqiwPM4nloY1kKXaPJuTRMCOgStakVLU31/Sl1jUf0EYwGVj?= =?us-ascii?Q?A5yVLuIOcj3WO9DVEsq/bXGLDzxfMJgvRXP2rnX6bkFeXARghdC82Fq8/8EF?= =?us-ascii?Q?SVDWHEHanbxiDXJMwe2dGAcWmpk1fiocA3eqUdkYtBGmF3Hr7zRhD/cjFkv1?= =?us-ascii?Q?Y35u50Lnzp183ueZIfffDpZRhC+vFT2Zb3gjhJHEZFlxptKmJQyX60ZOuyty?= =?us-ascii?Q?D3ikem7p7CusbVV7TMjOZfSW2buvhU+jM1m5iWptlvMP7RPeaad3T/7StMAW?= =?us-ascii?Q?QGdtxcTx08H3hUdYbnpU80IfVfcUO21ba5UxArJHlh9EF9hyNSDiPkxBT4tM?= =?us-ascii?Q?BhTf64CvZZycdhquWXbG2vJz1jMVj2xf2UDwnUaeyz7tej0X1liz8mPhD4cB?= =?us-ascii?Q?mH+qj+Bca2pHYjErLFWqc2oRP1lLeQOrJWszDOUn/C/wTnJ32ySHnN/LtrI2?= =?us-ascii?Q?DzAFXRcRw6RwN5GCev9AMI5n3X61SyUWkCIRfnzxDTMaiO00yDEODZLD8pj/?= =?us-ascii?Q?mK5IJxOqFAtBe/2IU9Y0ESTVSRYi4NU9nVO04hDOicdF6cSC/TpT7X4pS6az?= =?us-ascii?Q?4590Alv9AJM596941S3T6ytCynsWO/dSkHWTCd8KH4IhmCawEW+yii1wO1oC?= =?us-ascii?Q?HztyU/v5WyaGmfvUv4eEfM2x844ZpGXUEJiuEy2HAx77FrDRGbvg5FEC847V?= =?us-ascii?Q?XbmB20b9xgcdqY/aI8Xtm4srwAVADF/eCN8IP9ft0Ets8ZVlrN2hKylTMXLs?= =?us-ascii?Q?ktU+p1it04+XgHUIsPi7V+Qr5+cNcI7VhPux2geuKYrQNgCn/HD6qXN9ySI2?= =?us-ascii?Q?/Z8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2474.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: acfc6989-364f-4927-cbaa-08d8f66cc271 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2021 06:50:25.0154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wf9AtBhBut0ibQ/2US+NX1JLSU5Pd55HRdHxExsTMOq4ecs133eg27DvSf1qhs6LY53dEL8JabXhRnPp/mzVRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1552 X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2021 06:50:40 -0000 [AMD Public Use] Gentle PING! -----Original Message----- From: Tomar, Sourabh Singh=20 Sent: Friday, March 26, 2021 8:43 PM To: Tomar, Sourabh Singh via Gdb-patches Cc: George, Jini Susan ; Sharma, Alok Kumar ; Kumar N, Bhuvanendra ; A= chra, Nitika ; E, Nagajyothi Subject: [PATCH] gdb-Fix-macro-info-lookup-for-binaries-containing-DWARFv5 [AMD Public Use] Hello Everyone, Requesting review on this patch, Please have a look. Problem Description/Summary: - clang emits DWARFv5 conformant line tables(ie. .debug_line section) which= makes 2 things explicitly: 1. The current directory is explicitly present in the directories field and= has index 0. 2. The current compilation filename is explicitly present and has index 0. This leads to a subtle issue in GDB while accessing macro information: Consider the following program: ``` #define OUT 4 int main() { int a =3D OUT;} ``` Compiled as `clang -gdwarf-5 -fdebug-macro test.c` GDB session: ``` $gdb a.out -q .... 2 int main() { int a =3D OUT;} (gdb) info macro OUT The symbol `OUT' has no definition as a C/C++ preprocessor macro at /home/t= est.c:-1 ``` This issue cannot be reproduced using GCC compiler as GCC doesnot emit DWAR= Fv5 compliant tables even At `-gdwarf-5` flag. Issue is stemming from line-header.c. When performing a file name lookup fo= r macro filename GDB mistakenly appends FULL path after checking following = condition, which as **one may notice** for directory index `0` will always = evaluates `true` for DWARv5 line tables and `false` for DWARFv4 line tables= . ``` If (dir !=3D NULL) return gdb::unique_xmalloc_ptr (concat (dir, SLASH_STRING, fe->name, (char *) NULL)); = ``` Result of this, macro `filename` getting populated with fullname. Event= ually macro lookup results in failure due to mismatch in `main_file->filename` and `sal.symt= ab->filename`. This patch attempts to fix above problem by extending the check for file `0= `, i.e for file `0` do not append the fullname. Testing: - NO regressions in GDB testsuite before and after the fix. We also tried add a test case for this fix, but was unsuccessful. GDB test suite uses full path to the test files and this specific problem i= s not reproducible when user specifies full path. i.e Not reproducible case= s: 1. `clang -gdwarf-5 -fdebug-macro ./test.c` // macro visible inside GDB 2. = `clang -gdwarf-5 -fdebug-macro /ABSOLUTE_PATH/test.c` // macro visible insi= de GDB Reproducible: 1. `clang -gdwarf-5 -fdebug-macro test.c` //log shown above. gdb/ChangeLog 2021-03-26 Sourabh Singh Tomar * dwarf2/line-header.c: Updated the comment and extended check in function `line_header::file_file_name` for DWARFv5 line tables. Thank You, Sourabh.