[AMD Public Use]

Hi Tom,

Thanks for reviewing this!

>>>      * gdb.base/macscp.exp: Append -g3 to additional_flags for clang.

>>> +2021-03-10  Sourabh Singh Tomar  <SourabhSingh.Tomar@amd.com>
>>> +
>>> +    * gdb.base/macscp.exp: Remove -g3 from additional_flags and
>>> +    append -fdebug-macro to additional_flags for clang.
>>>+
>>>This diff seems a little weird - there are newer ChangeLog entries visible.

Thanks for suggestion/correction. Cleaned the changelog.

>>>I suspect the second call to get_compiler_info isn't needed, and this could be phrased as "else if { ... clang ... }".

Done. Thanks!

Overall changes:
- Rebased on tip.
- Addressed review comments.

Thanks,
Sourabh.

-----Original Message-----
From: Tom Tromey <tom@tromey.com> 
Sent: Thursday, March 11, 2021 12:40 AM
To: Tomar, Sourabh Singh via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tomar, Sourabh Singh <SourabhSingh.Tomar@amd.com>; George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>; Kumar N, Bhuvanendra <Bhuvanendra.KumarN@amd.com>
Subject: Re: [PATCH] [gdb.base] Enable macro test for clang compiler

[CAUTION: External Email]

>>>>> ">" == Tomar, Sourabh Singh via Gdb-patches <gdb-patches@sourceware.org> writes:

>> Requesting review on this patch, Please have a look.

Thank you.

>>      * gdb.base/macscp.exp: Append -g3 to additional_flags for clang.

>> +2021-03-10  Sourabh Singh Tomar  <SourabhSingh.Tomar@amd.com>
>> +
>> +    * gdb.base/macscp.exp: Remove -g3 from additional_flags and
>> +    append -fdebug-macro to additional_flags for clang.
>> +

This diff seems a little weird - there are newer ChangeLog entries visible.

Maybe you have other patches after this one ... that's fine, but it's good usually to make a new branch when submitting to avoid this kind of thing.


>>  get_compiler_info
>> -if { [test_compiler_info "gcc-*"] || [test_compiler_info "clang-*"] 
>> } {
>> +if { [test_compiler_info "gcc-*"] } {
>>      lappend options additional_flags=-g3  }

>> +get_compiler_info
>> +if { [test_compiler_info "clang-*"] } {
>> +    lappend options additional_flags=-fdebug-macro }

I suspect the second call to get_compiler_info isn't needed, and this could be phrased as "else if { ... clang ... }".

Tom