RE: [PATCH 6/6] gdb: convert the 'start' breakpoint to use inferior keyword

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Monday, November 28, 2022 12:26 PM, Andrew Burgess wrote:
> Now that we have support for inferior specific breakpoints, the
> breakpoint created for the 'start' command can make use of this
> keyword.
...
> diff --git a/gdb/testsuite/gdb.base/start-inferior-specific.exp
> b/gdb/testsuite/gdb.base/start-inferior-specific.exp
> new file mode 100644
> index 00000000000..50e4e109116
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/start-inferior-specific.exp
> @@ -0,0 +1,55 @@
> +# Copyright 2022 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# Check that a breakpoint created for the 'start' command, will be
> +# silently deleted if the inferior being started exits before reaching
> +# main.
> +
> +standard_testfile -1.c -2.c
> +
> +if {[use_gdb_stub]} {
> +    return
> +}
> +
> +set srcfile1 ${srcfile}
> +
> +set binfile1 ${binfile}-1
> +set binfile2 ${binfile}-2
> +
> +if {[build_executable ${testfile}.exp ${binfile1} "${srcfile1}"] != 0} {
> +    return -1
> +}
> +
> +if {[build_executable ${testfile}.exp ${binfile2} "${srcfile2}"] != 0} {
> +    return -1
> +}
> +
> +clean_restart ${binfile1}
> +
> +# Start the first inferior, this will exit before hitting the 'start'
> +# breakpoint in main.
> +gdb_test "start" \
> +    [multi_line \
> +	 "Temporary breakpoint $decimal at \[^\r\n\]+" \
> +	 "Starting program: \[^\r\n\]+" \
> +	 "\\\[Inferior $decimal \[^\r\n\]+ exited with code 01\\\]"]

Can $inferior_exited_re be used here?

> +
> +# Now load a different binary and run it.  This inferior should run
> +# all the way to completion without hitting a breakpoint in main.
> +gdb_load ${binfile2}
> +gdb_test "run" \
> +    [multi_line \
> +	 "Starting program: \[^\r\n\]+" \
> +	 "\\\[Inferior $decimal \[^\r\n\]+ exited normally\\\]"]

Also here.

Thanks
-Baris

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928