From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by sourceware.org (Postfix) with ESMTPS id 1CFC4385B524 for ; Fri, 23 Dec 2022 10:55:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1CFC4385B524 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671792917; x=1703328917; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=j+rwxf/u4hrh6k+5/AaJivPaolCj55WHNnaK6p8wQxM=; b=a7T4+/xmuqongKDwtDYKmmM5ND3vgcyAFxu7ERjq9Dq2M57ZJJzwttkZ MD2WjYfagqkDxfIOEk7pIghsTm7LWVKKc4JSW4VbWHNzPtyodtTl6RAFY ITg9a+GzfR/PWj18cAvMTWH78000Dz7wMqxib1Od/gTyyWnc7O7KnoRrr RjZj2/B0dqYRU+DSJ49et/1ZiV30A7GSonHyiORCbEje2yVoL/oJsLPbh BZD7jYnNEYgyydUkUajEG0CvhiLX1W0w/Q/GqGKZfSBrnszWhFqLnv0+5 8QKZQTSeB1c2GtwCrEYbPS/oIT49ZqLOCMCLo+mFJRtEKQ1lSum7D0zrA Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10569"; a="320371032" X-IronPort-AV: E=Sophos;i="5.96,268,1665471600"; d="scan'208";a="320371032" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2022 02:55:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10569"; a="645549799" X-IronPort-AV: E=Sophos;i="5.96,268,1665471600"; d="scan'208";a="645549799" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 23 Dec 2022 02:55:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 23 Dec 2022 02:55:15 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 23 Dec 2022 02:55:15 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 23 Dec 2022 02:55:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=abRQqlYa4no+PNSYjp2WJ9LKCNeTwkOb6zAYlDHykcMnzFfZtMeqkMA3Z1FC4XCBq28HxZjv2kduosWcnv9hrDFLGhxQFmSZIiPh3+U94gHH2ygZ6RZ1SLedmZ1we773ZektFQUSOc3+kn9KnCYpa4c6ComKsH7ryqtPPYHdBbfqafeBV0vy2KV7QtunO+ZAF8nWeMET4VcH142vO2iRArooTzHA3b8I1YpZH+vDG3JjhprbdPA1H6+imuC0HeEctGwYCAswrEaRyXnzwU4mwHJghgqrMOoy55JkHeuLxNDMyeOCjbnfdrm49yUpAumLSQbvzcXkU0j+x6TjCnBtQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDv5aYOzW8KUo+Lns5hO8HxOvD2Hej4QUTIfj1AdtVE=; b=i6wdeWPW2sT6Wb2s7QaWgAulTnu+j1hVHGhDE193XgVjUIxPvjcUiiMqvWaaiYx1A42RTrK+GPZWeUjHotJt3PNrt/9NbWfdqtWPm26NoibjfaJ+fPlBsP2jzuMYT1S6QjHBCpI2tQkq2hd48E+f9v0f6URqLZUGrO0/qSpah581FNO1RLt2zJXL4O4fkSIvuy1zarYRUc5sdrgST/2A58iCbKgV9M1r2GPVchHEEegYEZwbkfqV7OCCgRjTEaR9zB3AagJPAnghhrIElEI2SU2OQCOjJ+FCJOsuDvmTVyOHSTUUX0PqHWXKwNRHLANTof54Sj7pDcNuN8ztOotfUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR1101MB2271.namprd11.prod.outlook.com (2603:10b6:301:52::23) by SA3PR11MB7626.namprd11.prod.outlook.com (2603:10b6:806:307::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Fri, 23 Dec 2022 10:55:12 +0000 Received: from MWHPR1101MB2271.namprd11.prod.outlook.com ([fe80::c801:5fec:f9a6:c87a]) by MWHPR1101MB2271.namprd11.prod.outlook.com ([fe80::c801:5fec:f9a6:c87a%2]) with mapi id 15.20.5944.013; Fri, 23 Dec 2022 10:55:12 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCH 0/6] Inferior specific breakpoints Thread-Topic: [PATCH 0/6] Inferior specific breakpoints Thread-Index: AQHZAxw2dgh54v3ALkOlRXdthhV0na57cw1A Date: Fri, 23 Dec 2022 10:55:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR1101MB2271:EE_|SA3PR11MB7626:EE_ x-ms-office365-filtering-correlation-id: 68719ffc-2495-40f8-a4d7-08dae4d42ac7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6CHxPKOEHbi6R4dmZHzsXB9GG5gi+CuN95wYHZ9AQI5qOoH2ykQeAzKMOyjIyATOzlDdrWdrcPndPRaJwZjKI0hXGnpgYFQmfxdxZbaPDlgWkb2CQG1IpIdNblcNoHKQksYCHm5KqQnXKWJfXmRgO8W7WYwnMT+Qr9q0QOeB3fscW3u4ukAq3X51RuL29yddj+a75RrpHQCp8c1g56TcS0zkgvU6Y0S3cW4ptNiCSkfDioF2eq7iGMmsUtkURH2mHelTcKzEsPOJtZlzEQB0OYuaQJ4iCy5HsCRrWjJBBxyNQ1ZL9cBMbjEL7sImDbn1UKa8/BqZrvsAzCcJTq8EXwPG2T6Ik7kejp3zXRa7Xzi6i3KJOgHsahqDfYvNFRM8wKuEjTaSeoRb61WUQhx/FIlAk+zvsSkFauIqeW/9ABxTJ1JNElBFJDhjxKYH6vDBzqv44vn1aokmY26OafvemSloa2kL0j8bzcYQl/SpMWmeBXt9EoF45SdmyP3cBWCrYTW9HNDEXtBvVy6LKp1wBjSUJ6/PCOG43JBfY1P2dwWpepB58MLRow7NbFiE3mIlf5JO851vSO4Cs1d5CWuzX6qOvLoiPLAnD+2VH5b2g2T6avdP4u+2kG6C0d4I/s734AcoONqHCP5x6/uOabqRY3ja9y0X5Dy58QD4dfijRnsy77y41lIeiUhrzwE12ycC7S8qsBEmhbv8abMTgn+bKQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2271.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(136003)(396003)(376002)(366004)(451199015)(86362001)(478600001)(64756008)(66556008)(66946007)(66446008)(186003)(66476007)(9686003)(76116006)(26005)(55016003)(6506007)(316002)(71200400001)(110136005)(38070700005)(7696005)(38100700002)(82960400001)(8676002)(122000001)(41300700001)(33656002)(2906002)(8936002)(53546011)(4744005)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RuMzWM1tVlL/9iF8IZIL81GkONv3PQPqYhqnzh5k1d5RNAHxwCOe8B/t618C?= =?us-ascii?Q?GV75OokAhkHYaGV9javA7ePnw2QnkmxagIjWOXMqLS0kCNDmyVCfqIJUCeov?= =?us-ascii?Q?62Y/ddTOImNxkqSY5cGOHcot62QWPmnwm2N+BJErwcHA2RSdg3IHt4tBRa4R?= =?us-ascii?Q?miM+3GrIiDttY3Zk4J9j08yxl/78vjaXmhI5IlAkp3Jt9pFmrG1BOehdNvMB?= =?us-ascii?Q?/vG9mWRKhrf29oNYTjj/kUXAZOJjiVixfqFhKAcQNsQLbHMekpF7phACjRqB?= =?us-ascii?Q?ykwoBtV7T7s5rLqf1XwhAFg+v7Yjj4WSqI3sy111SOZZB4SRVpZZN4cokGmE?= =?us-ascii?Q?c95736GkrcXmfp2599JYPKKm8ckDNTtGUPqa+SIOWXpGrQem499Svn/ouDzj?= =?us-ascii?Q?9PVz4DhE3G1e7Ci7T/keWAxXGuwdkzYg0TEW6TomYbc63eSS/R7c6NygEbXK?= =?us-ascii?Q?ikejjs5K876821Np2skGemyjvqo5Oiw0SpEokNkNteJ86H2qaoXioA6PpfYN?= =?us-ascii?Q?mp2SKixrPVTCSD3hXJk6ambWo0lt99Ssux3lcdumJiqojL7yeyJnI8DsZCxS?= =?us-ascii?Q?r8fQBABOu9VfcZpXFT1YebZ+EDUFDzppkNtx/jaV+DyThAmdlArAPtVy8bS8?= =?us-ascii?Q?wAsQy+6CxSI7olNjxBGOKx5703n+L/z+gi8k0NYel7o1b3OnG/Gl3mvRizQB?= =?us-ascii?Q?g/Ei8O0E7Gm2HWkJqP7LrLjLqFHvSsNtbGONdv0OfEoe9llUMEb9yNQfzbaj?= =?us-ascii?Q?wuTkS8Q/BOoSUnjwk90E0mDmRx4fDOYsJH9XBfjDX+xbgoPvgfca+n/qPuib?= =?us-ascii?Q?WI0pC5fmnyC96iBHXWkzcTvPtFn18DG3TcXiU9eRFakFYBCF4sJKpu36c36+?= =?us-ascii?Q?lemG+/L1UZRGyY00YWbdx5bxXrZ/edCZuQVNG6D/R4wTf89dRB1NM+tZX3Y/?= =?us-ascii?Q?yNKskmXNRhmQTda359zVQ4AmDAdH3eKudDw58tIp0FU8crgMM91Uz6ahMBHn?= =?us-ascii?Q?sfXDXPqR58mWhMJav3nkNJiGuUA6GEtwByL4gbrvahvcKOdxVF3R8PpAJ/oZ?= =?us-ascii?Q?xxGgog8ahVZNdhwN0RXmKPdUj6cqnHG4xJR5toeFmHlNjnAckSOJEnIpsrSM?= =?us-ascii?Q?W3SQR4Fy5tsl02/a9s06BnD1EpZRGt5J7n0tu29Zt7rcJnBXU5TF6znSgZn/?= =?us-ascii?Q?ElM/eAKSByjZz2QtiK63dh1AGek9YZ4TGbJVFFY529TZ5dCnp6LNK6nMdzHc?= =?us-ascii?Q?MBNFC8vvbePcfZKZgTf7UPDanZFA94gICXW+FudXJcEYcPc6SHdnaOmkB5c5?= =?us-ascii?Q?gwo8t/+LjGAaYXSZ6uYFeDffIOMWRyY69Q0BPkp3wdyHhGp0xnjZ2R5hb6/w?= =?us-ascii?Q?nxS4NYp6Sm7Dw0SdH+LcTxMwKTNCJ68HEIWOtueRFucc8A7MSbI0OCxYaU8T?= =?us-ascii?Q?uBaTxb2yDZ6apfJgvNzz7CFNy3E5BehPtwPtLpfvS/DS4fI5KAPg61rQmRrc?= =?us-ascii?Q?7cCK+tX9D5ye/ap4sF5WRqiP9cbtB6NtJe5pxhgSrfjYJebe4Zsm4J0wR8ju?= =?us-ascii?Q?lrU2k0F+NbbP3kip8U3GaoEgXlgDHBRrqwq2G3OKlZDvJiTD8g+r4/s0QUP1?= =?us-ascii?Q?jw=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2271.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68719ffc-2495-40f8-a4d7-08dae4d42ac7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2022 10:55:12.7648 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 82UJxQEesUDqZqDMp+ZzUtRlH9sDAMZ4k+R4dyUsBJ8P2QbtfhqO61U7gti2FR0PvG37NUpGpasY1Q6TNI4c8idg5EefpyCAWYOQnah7n18= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7626 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Monday, November 28, 2022 12:26 PM, Andrew Burgess wrote: > Adding inferior specific breakpoints to GDB. These are like the > current thread or Ada task specific breakpoints, but cover inferiors. > = > Patches #1, #2, #3 are unreleated bug fixes that I ran into while > adding this feature. > = > Patch #4 is possibly a bug fix, or maybe a tightening of our CLI rules > for specifying thread/task breakpoints and watchpoints. This one > could be dropped if it's not wanted. > = > Patch #5 is where I add inferior specific breakpoints. > = > Patch #6 converts the 'start' mechanism to use inferior specific > breakpoints. FWIW, I've gone through this series and posted my comments for patches 3, 5, and 6. Patches 1, 2, and 4 looked fine to me. I haven't run the tests. Regards -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928