From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
To: "Carl Love" <cel@us.ibm.com>
Cc: gdb-patches@sourceware.org, "Rogerio Alves" <rogealve@br.ibm.com>,
"Will Schmidt" <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] Powerpc: Add support for openat and fstatat syscalls
Date: Thu, 7 Oct 2021 19:52:11 +0200 [thread overview]
Message-ID: <OF499743BD.418B9A20-ONC1258767.0061CCF4-C1258767.006229AD@ibm.com> (raw)
In-Reply-To: <22a9ea816266f1b9e6948a396a1dc45cb5f8f153.camel@us.ibm.com>
"Carl Love" <cel@us.ibm.com> wrote on 05.10.2021 22:59:06:
> + else if (syscall == 286)
> + result = gdb_sys_openat;
This looks OK, but ...
> + else if (syscall == 291)
> + result = gdb_sys_fstatat64;
syscall 291 is actually different between 32-bit
and 64-bit: on 32-bit it is fstatat64, but on
64-bit it is newfstatat.
Given that this routine seems to be used for
both flavors, it should be correct for both.
(Also, there seem to be many more syscalls that
are not handled even though they could be. But
that can be left for another time I guess ...)
Bye,
Ulrich
next prev parent reply other threads:[~2021-10-07 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 20:59 Carl Love
2021-10-07 17:52 ` Ulrich Weigand [this message]
2021-10-07 19:43 ` Sergio Durigan Junior
[not found] ` <OF499743BD.418B9A20-ONC1258767.0061CCF4-C1258767.006229AD@us.ibm.com>
2021-10-11 21:17 ` Carl Love
2021-10-11 21:57 ` will schmidt
2021-10-12 19:13 ` Carl Love
2021-10-13 13:08 ` Ulrich Weigand
[not found] ` <OF8D70D176.67629273-ONC125876D.00479F81-C125876D.004826BA@us.ibm.com>
2021-10-13 21:55 ` Carl Love
2021-10-14 11:21 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF499743BD.418B9A20-ONC1258767.0061CCF4-C1258767.006229AD@ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=rogealve@br.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).