From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B285B385840C for ; Thu, 7 Oct 2021 17:52:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B285B385840C Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 197HX7tt009372 for ; Thu, 7 Oct 2021 13:52:17 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bj1dsyb45-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Oct 2021 13:52:17 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 197HmhNn032137 for ; Thu, 7 Oct 2021 17:52:16 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03wdc.us.ibm.com with ESMTP id 3bef2cutty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Oct 2021 17:52:16 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 197HqFWP35127668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Oct 2021 17:52:15 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3DBFABE051; Thu, 7 Oct 2021 17:52:15 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25F60BE053; Thu, 7 Oct 2021 17:52:15 +0000 (GMT) Received: from mww0272.dal12m.mail.ibm.com (unknown [9.208.64.29]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 7 Oct 2021 17:52:15 +0000 (GMT) MIME-Version: 1.0 In-Reply-To: <22a9ea816266f1b9e6948a396a1dc45cb5f8f153.camel@us.ibm.com> Subject: Re: [PATCH] Powerpc: Add support for openat and fstatat syscalls To: "Carl Love" Cc: gdb-patches@sourceware.org, "Rogerio Alves" , "Will Schmidt" Message-ID: From: "Ulrich Weigand" Date: Thu, 7 Oct 2021 19:52:11 +0200 References: <22a9ea816266f1b9e6948a396a1dc45cb5f8f153.camel@us.ibm.com> X-KeepSent: 499743BD:418B9A20-C1258767:0061CCF4; name=$KeepSent; type=4 X-Mailer: IBM Notes Release 9.0.1FP7 Octobe4, 2013 X-Disclaimed: 55975 X-MIMETrack: CD-MIME by Router on MWW0272/03/M/IBM at 10/07/2021 17:52:14, CD-MIME complete at 10/07/2021 17:52:14,Itemize by Router on MWW0272/03/M/IBM at 10/07/2021 17:52:14 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: aK1tRMljGrlu1v7VMCcnLTn61FBUPD2r X-Proofpoint-ORIG-GUID: aK1tRMljGrlu1v7VMCcnLTn61FBUPD2r X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-07_03,2021-10-07_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1011 priorityscore=1501 phishscore=0 mlxlogscore=630 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110070113 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2021 17:52:20 -0000 "Carl Love" wrote on 05.10.2021 22:59:06: > + else if (syscall =3D=3D 286) > + result =3D gdb=5Fsys=5Fopenat; This looks OK, but ... > + else if (syscall =3D=3D 291) > + result =3D gdb=5Fsys=5Ffstatat64; syscall 291 is actually different between 32-bit and 64-bit: on 32-bit it is fstatat64, but on 64-bit it is newfstatat. Given that this routine seems to be used for both flavors, it should be correct for both. (Also, there seem to be many more syscalls that are not handled even though they could be. But that can be left for another time I guess ...) Bye, Ulrich