public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
To: "Carl Love" <cel@us.ibm.com>
Cc: gdb-patches@sourceware.org, "Rogerio Alves" <rogealve@br.ibm.com>,
	"Will Schmidt" <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] finish-reverse fix for setting break on correct entry point when executing in reverse.
Date: Sat, 24 Jul 2021 17:32:12 +0200	[thread overview]
Message-ID: <OF5B9EAD7A.D10A14C8-ONC125871C.0054FB44-C125871C.0055587E@ibm.com> (raw)
In-Reply-To: <c0c094b965859b97d78adde32b075b4dfc480646.camel@us.ibm.com>



"Carl Love" <cel@us.ibm.com> wrote on 21.07.2021 18:39:16:

> gdb/ChangeLog
> 2021-07-09  Carl Love  <cel@us.ibm.com>
>    * infcmd.c (finish_backward): Add if gdbarch_skip_entrypoint_p and
>    call to gdbarch_skip_entrypoint.

I think you correctly identified the problem, but the fix is not
quite correct.  Note that you may actually be on the global entry
point (e.g. if you did a reverse single-step before) - in that
case the code with your change would set a breakpoint on the
*local* entry point, but that will never be reached any more.

I think the correct fix in the case where we have global and local
entry points would to always reverse single-step whenever the
current PC falls between the two entry points (inclusively), and
reverse continue to the local entry point otherwise.

Bye,
Ulrich

  reply	other threads:[~2021-07-24 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 21:22 Carl Love
2021-07-21 16:39 ` Carl Love
2021-07-24 15:32   ` Ulrich Weigand [this message]
     [not found]   ` <OF5B9EAD7A.D10A14C8-ONC125871C.0054FB44-C125871C.0055587E@us.ibm.com>
2021-07-29 21:00     ` Carl Love
2021-08-04 23:51       ` Carl Love
2021-08-16 12:09         ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF5B9EAD7A.D10A14C8-ONC125871C.0054FB44-C125871C.0055587E@ibm.com \
    --to=ulrich.weigand@de.ibm.com \
    --cc=cel@us.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=rogealve@br.ibm.com \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).