From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 4498E3855007 for ; Thu, 29 Jul 2021 11:49:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4498E3855007 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16TBfswb102352 for ; Thu, 29 Jul 2021 07:49:30 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3a3d97ge7q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Jul 2021 07:49:29 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16TBghCx108809 for ; Thu, 29 Jul 2021 07:49:29 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 3a3d97ge7e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Jul 2021 07:49:29 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16TBkvrW013353; Thu, 29 Jul 2021 11:49:28 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma03dal.us.ibm.com with ESMTP id 3a235s40pc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Jul 2021 11:49:28 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16TBnRki27197728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Jul 2021 11:49:27 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 427C313608E; Thu, 29 Jul 2021 11:49:27 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 35A4D13608B; Thu, 29 Jul 2021 11:49:27 +0000 (GMT) Received: from mww0272.dal12m.mail.ibm.com (unknown [9.208.64.29]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 29 Jul 2021 11:49:27 +0000 (GMT) MIME-Version: 1.0 In-Reply-To: Subject: Re: [Patch v2] Handle .TOC. sections during gdb-compile for rs6000 target. To: "Alan Modra" Cc: "Carl E. Love" , "gdb-patches@sourceware.org" , "rogerio" , "will schmidt" Message-ID: From: "Ulrich Weigand" Date: Thu, 29 Jul 2021 13:49:23 +0200 References: <21185e6d3118c97c9dde66df366bb9ff3b31dede.camel@vnet.ibm.com> X-KeepSent: 8B0A2AAC:426BD117-C1258721:0040DAD5; name=$KeepSent; type=4 X-Mailer: IBM Notes Release 9.0.1FP7 Octobe4, 2013 X-Disclaimed: 2387 X-MIMETrack: CD-MIME by Router on MWW0272/03/M/IBM at 07/29/2021 11:49:27, CD-MIME complete at 07/29/2021 11:49:27,Itemize by Router on MWW0272/03/M/IBM at 07/29/2021 11:49:27 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: OYIHhONZvexxpWgNQYLttBVVLVzIrcTF X-Proofpoint-GUID: ksDU3Aa3YjW43MLhJEjsWdvm9r4DOwua X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-29_09:2021-07-29, 2021-07-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 mlxlogscore=965 impostorscore=0 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107290074 X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 11:49:31 -0000 "Alan Modra" wrote on 29.07.2021 10:26:11: > On Thu, Jul 29, 2021 at 09:18:18AM +0200, Ulrich Weigand wrote: > > > > > > "will schmidt" wrote on 28.07.2021 21:08:21: > > > > > + sym->section =3D toc=5Ffallback; > > > + sym->value =3D 0x8000; > > > + bfd=5Fset=5Fgp=5Fvalue(abfd.get(), toc=5Ffallback->vma); > > > > For compatibility with BFD, shouldn't this be rather: > > > > bfd=5Fset=5Fgp=5Fvalue(abfd.get(), toc=5Ffallback->vma + sym->v= alue); > > > > Alan, can you confirm? > > No, see bfd/elf64-ppc.c:ppc64=5Felf=5Fsec=5Ftoc. A long time ago I chose > the value of elf=5Fgp used in elf64-ppc.c to be the start of the toc > section rather than the value of ".TOC.". The value is somewhat > arbitrary. Yes, I could change it to be the value of .TOC., but for > now the value above is correct. I see, thanks for the explanation. Will, the patch is OK for trunk then. Thanks, Ulrich