From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
To: "Carl Love" <cel@us.ibm.com>
Cc: gdb-patches@sourceware.org, "Rogerio Alves" <rogealve@br.ibm.com>,
"will schmidt" <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] Powerpc: Add support for openat and fstatat syscalls
Date: Thu, 14 Oct 2021 13:21:36 +0200 [thread overview]
Message-ID: <OFADFC81EE.AF8E895D-ONC125876E.003E44FC-C125876E.003E675B@ibm.com> (raw)
In-Reply-To: <0395c04977602476887fec6bdff16f1148d72ffd.camel@us.ibm.com>
"Carl Love" <cel@us.ibm.com> wrote on 13.10.2021 23:55:43:
> Powerpc: Add support for openat and fstatat syscalls
>
> [gdb] update ppc-linux-tdep.c
>
> Add argument to ppc_canonicalize_syscall for the wordsize.
> Add syscall entries for the openat and fstatat system calls.
> + else if (syscall == 286)
> + result = gdb_sys_openat;
> + else if (syscall == 291)
> + if (wordsize == 64)
> + result = gdb_sys_newfstatat;
> + else
> + result = gdb_sys_fstatat64;
Please add braces around the nested if to avoid the
ambiguous else.
Otherwise, this is OK.
Thanks,
Ulrich
prev parent reply other threads:[~2021-10-14 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 20:59 Carl Love
2021-10-07 17:52 ` Ulrich Weigand
2021-10-07 19:43 ` Sergio Durigan Junior
[not found] ` <OF499743BD.418B9A20-ONC1258767.0061CCF4-C1258767.006229AD@us.ibm.com>
2021-10-11 21:17 ` Carl Love
2021-10-11 21:57 ` will schmidt
2021-10-12 19:13 ` Carl Love
2021-10-13 13:08 ` Ulrich Weigand
[not found] ` <OF8D70D176.67629273-ONC125876D.00479F81-C125876D.004826BA@us.ibm.com>
2021-10-13 21:55 ` Carl Love
2021-10-14 11:21 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFADFC81EE.AF8E895D-ONC125876E.003E44FC-C125876E.003E675B@ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=rogealve@br.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).