From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 858373858C2C for ; Thu, 14 Oct 2021 11:21:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 858373858C2C Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19E9mafd014765 for ; Thu, 14 Oct 2021 07:21:42 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bnnvgqyys-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 14 Oct 2021 07:21:41 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19EBHiJS015595 for ; Thu, 14 Oct 2021 11:21:41 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma02wdc.us.ibm.com with ESMTP id 3bnm39r07c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 14 Oct 2021 11:21:41 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19EBLeRN34210554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Oct 2021 11:21:40 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5540EC605D; Thu, 14 Oct 2021 11:21:40 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4AEB2C605A; Thu, 14 Oct 2021 11:21:40 +0000 (GMT) Received: from mww0272.dal12m.mail.ibm.com (unknown [9.208.64.29]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 14 Oct 2021 11:21:40 +0000 (GMT) MIME-Version: 1.0 In-Reply-To: <0395c04977602476887fec6bdff16f1148d72ffd.camel@us.ibm.com> Subject: Re: [PATCH] Powerpc: Add support for openat and fstatat syscalls To: "Carl Love" Cc: gdb-patches@sourceware.org, "Rogerio Alves" , "will schmidt" Message-ID: From: "Ulrich Weigand" Date: Thu, 14 Oct 2021 13:21:36 +0200 References: <22a9ea816266f1b9e6948a396a1dc45cb5f8f153.camel@us.ibm.com> <287929e6460980eb4e0d12a52593689ebf4f309a.camel@us.ibm.com> <9bf3148807544fd7b83ec9334e9c18cf7b9bee81.camel@us.ibm.com> <0395c04977602476887fec6bdff16f1148d72ffd.camel@us.ibm.com> X-KeepSent: ADFC81EE:AF8E895D-C125876E:003E44FC; name=$KeepSent; type=4 X-Mailer: IBM Notes Release 9.0.1FP7 Octobe4, 2013 X-Disclaimed: 31943 X-MIMETrack: CD-MIME by Router on MWW0272/03/M/IBM at 10/14/2021 11:21:40, CD-MIME complete at 10/14/2021 11:21:40,Itemize by Router on MWW0272/03/M/IBM at 10/14/2021 11:21:40 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rTLKG6V0USKhk8gpCubTB9cs8-EmR6tj X-Proofpoint-ORIG-GUID: rTLKG6V0USKhk8gpCubTB9cs8-EmR6tj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-14_03,2021-10-14_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=582 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110140068 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2021 11:21:43 -0000 "Carl Love" wrote on 13.10.2021 23:55:43: > Powerpc: Add support for openat and fstatat syscalls > > [gdb] update ppc-linux-tdep.c > > Add argument to ppc=5Fcanonicalize=5Fsyscall for the wordsize. > Add syscall entries for the openat and fstatat system calls. > + else if (syscall =3D=3D 286) > + result =3D gdb=5Fsys=5Fopenat; > + else if (syscall =3D=3D 291) > + if (wordsize =3D=3D 64) > + result =3D gdb=5Fsys=5Fnewfstatat; > + else > + result =3D gdb=5Fsys=5Ffstatat64; Please add braces around the nested if to avoid the ambiguous else. Otherwise, this is OK. Thanks, Ulrich