Re: [PATCH] SYMBOL_LANGUAGE assertion failure on AIX

["Sangamesh Mallayya" <sangamesh.swamy@in.ibm.com>]

Hi Ulrich,

Thanks for the help.
I am able to commit the changes 
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=b971899198607b844f5a37e39dc561766c3b331a

Thanks,
Sangamesh



From:   "Ulrich Weigand" <uweigand@de.ibm.com>
To:     Sangamesh Mallayya/India/IBM@IBMIN
Cc:     keiths@redhat.com (Keith Seitz), gdb-patches@sourceware.org
Date:   10/24/2018 11:34 PM
Subject:        Re: [PATCH] SYMBOL_LANGUAGE assertion failure on AIX



Sangamesh Mallaya wrote:

> Thanks for the review and comments.
> Attaching the changelog file and git formatted patch.

>                * xcoffread.c (read_xcoff_symtab): Fix SYMBOL_LANGUAGE 
assertion
>                failure.

GNU coding style is to mention in the ChangeLog *what* was changed,
not why the change is done.  "Fix assertion failure" doesn't describe
*what* actually was changed, so it should read more like this:

                 * xcoffread.c (read_xcoff_symtab): Pass deduced language 
to
                 symtab_start instead of always using language_unknown.

(You can and should still describe the reason for the change, e.g. that
it fixes an assertion failure, in the git commit message.)

You should have git commit access yourself now, right?  Feel free to
commit the change now.  (If you don't have access, please let me know.)

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com