From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53003 invoked by alias); 26 Oct 2018 10:37:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98326 invoked by uid 89); 26 Oct 2018 10:25:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=sk:ulrich, U*Ulrich.Weigand, mallaya, sk:Ulrich X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Oct 2018 10:25:41 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9QAPQwb039656 for ; Fri, 26 Oct 2018 06:25:39 -0400 Received: from smtp.notes.na.collabserv.com (smtp.notes.na.collabserv.com [192.155.248.81]) by mx0a-001b2d01.pphosted.com with ESMTP id 2nbw03axk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 26 Oct 2018 06:25:37 -0400 Received: from localhost by smtp.notes.na.collabserv.com with smtp.notes.na.collabserv.com ESMTP for from ; Fri, 26 Oct 2018 10:23:36 -0000 Received: from us1a3-smtp07.a3.dal06.isc4sb.com (10.146.103.14) by smtp.notes.na.collabserv.com (10.106.227.88) with smtp.notes.na.collabserv.com ESMTP; Fri, 26 Oct 2018 10:23:32 -0000 Received: from us1a3-mail142.a3.dal06.isc4sb.com ([10.146.38.78]) by us1a3-smtp07.a3.dal06.isc4sb.com with ESMTP id 2018102610233286-339593 ; Fri, 26 Oct 2018 10:23:32 +0000 In-Reply-To: <20181024180424.31F38D801EB@oc3748833570.ibm.com> To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, keiths@redhat.com (Keith Seitz) Subject: Re: [PATCH] SYMBOL_LANGUAGE assertion failure on AIX From: "Sangamesh Mallayya" Date: Fri, 26 Oct 2018 10:37:00 -0000 References: from "Sangamesh Mallayya" at Oct 23, 2018 12:09:33 PM <20181024180424.31F38D801EB@oc3748833570.ibm.com> X-KeepSent: D856DC9D:DAD47188-65258332:003870AC; type=4; name=$KeepSent X-LLNOutbound: False X-Disclaimed: 34979 X-TNEFEvaluated: 1 x-cbid: 18102610-7093-0000-0000-000008DFE25E X-IBM-SpamModules-Scores: BY=0.085348; FL=0; FP=0; FZ=0; HX=0; KW=0; PH=0; SC=0.388783; ST=0; TS=0; UL=0; ISC=; MB=0.002350 X-IBM-SpamModules-Versions: BY=3.00009938; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000268; SDB=6.01108192; UDB=6.00574027; IPR=6.00888278; BA=6.00006130; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00023917; XFM=3.00000015; UTC=2018-10-26 10:23:34 X-IBM-AV-DETECTION: SAVI=unsuspicious REMOTE=unsuspicious XFE=unused X-IBM-AV-VERSION: SAVI=2018-10-26 07:39:45 - 6.00009140 x-cbparentid: 18102610-7094-0000-0000-000065494401 Message-Id: Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: Quoted-printable MIME-Version: 1.0 X-Proofpoint-Spam-Reason: safe X-SW-Source: 2018-10/txt/msg00615.txt.bz2 Hi Ulrich, Thanks for the help. I am able to commit the changes=20 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;a=3Dcommit;h=3Db= 971899198607b844f5a37e39dc561766c3b331a Thanks, Sangamesh From: "Ulrich Weigand" To: Sangamesh Mallayya/India/IBM@IBMIN Cc: keiths@redhat.com (Keith Seitz), gdb-patches@sourceware.org Date: 10/24/2018 11:34 PM Subject: Re: [PATCH] SYMBOL_LANGUAGE assertion failure on AIX Sangamesh Mallaya wrote: > Thanks for the review and comments. > Attaching the changelog file and git formatted patch. > * xcoffread.c (read_xcoff_symtab): Fix SYMBOL_LANGUAGE=20 assertion > failure. GNU coding style is to mention in the ChangeLog *what* was changed, not why the change is done. "Fix assertion failure" doesn't describe *what* actually was changed, so it should read more like this: * xcoffread.c (read_xcoff_symtab): Pass deduced language=20 to symtab_start instead of always using language_unknown. (You can and should still describe the reason for the change, e.g. that it fixes an assertion failure, in the git commit message.) You should have git commit access yourself now, right? Feel free to commit the change now. (If you don't have access, please let me know.) Thanks, Ulrich --=20 Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com